Page MenuHomePhabricator
Create Task
Maniphest T333167

Enable commit-message-validator for the CampaignEvents repo
Closed, ResolvedPublic
Actions

Description

Commit-message-validator, as the name would suggest, is a tool that validates commit messages according to the guidelines. CI can run it automatically as part of the test pipeline, but is not configured to do so for most MediaWiki repos. I'm wondering if we would be interesting in enabling it for the CampaignEvents repo. Some of the guidelines might be hard to remember, and this tool would automate that part of the code review process.

Details

SubjectRepoBranchLines +/-
Zuul: [mediawiki/extensions/CampaignEvents] Enable commit-message-validatorintegration/configmaster+1 -0
Customize query in gerrit

Event Timeline

Daimona created this task.Mar 27 2023, 2:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 27 2023, 2:00 PM
Daimona edited projects, added Campaign-Tools (Campaign-Tools-Current-Sprint); removed Campaign-Tools.Mar 27 2023, 2:00 PM
Daimona moved this task from Needs Input / Design in progress to Code Review on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.
Daimona added subscribers: MHorsey-WMF, cmelo.

@cmelo @MHorsey-WMF Would love to hear your thoughts on this.

cmelo added a comment.Mar 27 2023, 6:11 PM

Yes, if this can run automatically, I think it would be good. Thank you!

Daimona added a comment.Apr 18 2023, 2:55 PM

@MHorsey-WMF What do you think about this?

MHorsey-WMF added a comment.Jun 6 2023, 1:28 PM

Do it.

gerritbot added a comment.Jun 6 2023, 1:55 PM

Change 927683 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[integration/config@master] Zuul: [mediawiki/extensions/CampaignEvents] Enable commit-message-validator

https://gerrit.wikimedia.org/r/927683

gerritbot added a project: Patch-For-Review.Jun 6 2023, 1:55 PM
Daimona claimed this task.Jun 6 2023, 1:55 PM
gerritbot added a comment.Jun 6 2023, 3:58 PM

Change 927683 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/CampaignEvents] Enable commit-message-validator

https://gerrit.wikimedia.org/r/927683

Stashbot added a comment.Jun 6 2023, 4:01 PM

Mentioned in SAL (#wikimedia-releng) [2023-06-06T16:01:51Z] <hashar> Reloaded Zuul for https://gerrit.wikimedia.org/r/c/integration/config/+/927683 # T333167

Maintenance_bot removed a project: Patch-For-Review.Jun 6 2023, 4:11 PM
Daimona closed this task as Resolved.Jun 6 2023, 4:14 PM

It's enabled and working now, see for instance https://integration.wikimedia.org/ci/job/commit-message-validator/17043/console

MHorsey-WMF added a comment.Jun 6 2023, 4:23 PM

Amazing, thank you!

Aklapper renamed this task from Do we want to enable commit-message-validator for the CampaignEvents repo? to Enable commit-message-validator for the CampaignEvents repo.Jun 7 2023, 1:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL