Page MenuHomePhabricator
Create Task
Maniphest T333408

libup is not running on mediawiki/extensions/GPGMail and mediawiki/extensions/PasswordlessLogin
Closed, ResolvedPublic
Actions

Description

Libup is not running or working on two extensions according to the logs:

https://libup.wmcloud.org/r/mediawiki/extensions/GPGMail

$ date
--- stdout ---
Fri Feb  3 02:04:35 UTC 2023

https://libup.wmcloud.org/r/mediawiki/extensions/PasswordlessLogin

$ date
--- stdout ---
Thu Jan 19 07:37:02 UTC 2023

Please have look and try to restart libup on the extensions. Thanks.

Not sure if that are all repositiories where libup is not running (See T314424 for a feature request to see the timestamps in a list)

Details

SubjectRepoBranchLines +/-
build: Updating npm dependenciesmediawiki/extensions/PasswordlessLoginmaster+641 -603
build: Updating npm dependenciesmediawiki/extensions/GPGMailmaster+647 -609
Customize query in gerrit
TitleReferenceAuthorSource BranchDest Branch
tasks: Handle runs that crash before audits completerepos/ci-tools/libup!39taavitaavi/auditsmaster
Customize query in GitLab

Related Objects

Event Timeline

Umherirrender created this task.Mar 28 2023, 10:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 28 2023, 10:24 PM
gerritbot added a comment.Apr 3 2023, 7:46 PM

Change 905300 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/GPGMail@master] build: Updating npm dependencies

https://gerrit.wikimedia.org/r/905300

gerritbot added a project: Patch-For-Review.Apr 3 2023, 7:46 PM
gerritbot added a comment.Apr 3 2023, 8:12 PM

Change 905300 merged by Umherirrender:

[mediawiki/extensions/GPGMail@master] build: Updating npm dependencies

https://gerrit.wikimedia.org/r/905300

gerritbot added a comment.Apr 3 2023, 8:13 PM

Change 905306 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/PasswordlessLogin@master] build: Updating npm dependencies

https://gerrit.wikimedia.org/r/905306

gerritbot added a comment.Apr 3 2023, 8:20 PM

Change 905306 merged by Umherirrender:

[mediawiki/extensions/PasswordlessLogin@master] build: Updating npm dependencies

https://gerrit.wikimedia.org/r/905306

Umherirrender mentioned this in rEPLLe30f4341196d: build: Updating npm dependencies.Apr 3 2023, 8:24 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 3 2023, 8:30 PM
Umherirrender unsubscribed.May 1 2023, 12:15 PM
Umherirrender added a subscriber: taavi.Sun, Apr 21, 3:07 PM

Skin 2018 seems also affected

https://libup.wmcloud.org/r/mediawiki/skins/2018?branch=main

$ date
--- stdout ---
Wed Feb  7 14:35:46 UTC 2024
taavi added a comment.Sun, Apr 21, 3:28 PM

It's at least trying to queue such jobs:

root@libup-runner08:~# journalctl -u libup-run.service | grep 2018
Apr 20 00:02:31 libup-runner08 libup-run[1450895]: Queuing mediawiki/skins/2018 (main)
Apr 21 00:02:34 libup-runner08 libup-run[2819237]: Queuing mediawiki/skins/2018 (REL1_42)
Apr 21 00:02:34 libup-runner08 libup-run[2819237]: Queuing mediawiki/skins/2018 (main)

I'm not sure why this is not making it into the web interface (I'll have a look at that later), but for now if I run it manually it's failing with:

$ /usr/bin/composer install
--- stderr ---
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - composer/semver 1.4.2 requires php ^5.3.2 || ^7.0 -> your php version (8.2.7) does not satisfy that requirement.
    - mediawiki/mediawiki-codesniffer v21.0.0 requires composer/semver 1.4.2 -> satisfiable by composer/semver[1.4.2].
    - Root composer.json requires mediawiki/mediawiki-codesniffer 21.0.0 -> satisfiable by mediawiki/mediawiki-codesniffer[v21.0.0].
--- stdout ---

(That's the initial install before it gets to look at what needs updating)

Umherirrender added a comment.Sun, Apr 21, 9:36 PM

That issue is now fixed with fe14f46e4e2d488b91ad05e8c77b91c9e79c8a9c and https://libup.wmcloud.org/r/mediawiki/skins/2018 shows a fresh run. Very good.

What about GPGMail? Is there also a log message?

Do you need an extra task to look why this issue is not logged in the database and/or not visible in the web interface?

taavi added a comment.Sun, Apr 21, 9:50 PM

Turns out that's a bug with the output parsing if the run crashes early enough. Now fixed with https://gitlab.wikimedia.org/repos/ci-tools/libup/-/merge_requests/39.

And the GPGMail error is this:

Apr 19 23:45:06 libup-runner08 libup-celery[1416305]: $ /usr/bin/composer install
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]: --- stderr ---
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]: No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]: Loading composer repositories with package information
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]: Updating dependencies
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]: Lock file operations: 22 installs, 0 updates, 0 removals
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   - Locking composer/installers (v2.2.0)
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   - Locking composer/semver (3.3.2)
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   - Locking composer/spdx-licenses (1.5.8)
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   - Locking mediawiki/mediawiki-codesniffer (v41.0.0)
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   - Locking mediawiki/minus-x (1.1.1)
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   - Locking php-parallel-lint/php-console-color (v1.0.1)
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   - Locking php-parallel-lint/php-console-highlighter (v1.0.0)
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   - Locking php-parallel-lint/php-parallel-lint (v1.3.2)
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   - Locking psr/container (2.0.2)
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   - Locking psr/log (1.0.0)
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   - Locking squizlabs/php_codesniffer (3.7.2)
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   - Locking symfony/console (v5.4.36)
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   - Locking symfony/deprecation-contracts (v3.4.0)
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   - Locking symfony/polyfill-ctype (v1.29.0)
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   - Locking symfony/polyfill-intl-grapheme (v1.29.0)
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   - Locking symfony/polyfill-intl-normalizer (v1.29.0)
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   - Locking symfony/polyfill-mbstring (v1.29.0)
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   - Locking symfony/polyfill-php73 (v1.29.0)
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   - Locking symfony/polyfill-php80 (v1.29.0)
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   - Locking symfony/service-contracts (v3.4.2)
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   - Locking symfony/string (v6.4.4)
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   - Locking wikimedia/gpglib (0.2.1)
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]: Writing lock file
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]: Installing dependencies from lock file (including require-dev)
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]: Package operations: 22 installs, 0 updates, 0 removals
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   - Downloading wikimedia/gpglib (0.2.1)
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:  0/1 [>---------------------------]   0%    Failed to download wikimedia/gpglib from dist: The "https://api.github.com/repos/wikimedia/php-gpglib/zipball/567bea37bb767fb334deaf48>
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]: {"message":"Not Found","documentation_url":"https://docs.github.com/rest/repos/contents#download-a-repository-archive-zip"}
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:     Now trying to download from source
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   - Syncing wikimedia/gpglib (0.2.1) into cache
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:  1/1 [============================] 100%
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]: In Git.php line 471:
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:                                                                                
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   Failed to clone https://github.com/wikimedia/php-gpglib.git via https, ssh
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   protocols, aborting.
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:                                                                                
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   - https://github.com/wikimedia/php-gpglib.git
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:     Cloning into bare repository '/cache/composer/vcs/https---github.com-wiki
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   media-php-gpglib.git'...
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:     remote: Support for password authentication was removed on August 13, 202
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   1.
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:     remote: Please see https://docs.github.com/get-started/getting-started-wi
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   th-git/about-remote-repositories#cloning-with-https-urls for information on
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:    currently recommended modes of authentication.
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:     fatal: Authentication failed for 'https://github.com/wikimedia/php-gpglib
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   .git/'
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:                                                                                
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   - git@github.com:wikimedia/php-gpglib.git
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:     Cloning into bare repository '/cache/composer/vcs/https---github.com-wiki
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:   media-php-gpglib.git'...
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:     Host key verification failed.
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:     fatal: Could not read from remote repository.
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:                                                                                
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:     Please make sure you have the correct access rights
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:     and the repository exists.
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]:                                                                                
Apr 19 23:45:07 libup-runner08 libup-celery[1416305]: install [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--dry-run] [--download-only] [--dev] [--no-suggest] [--no-dev] [--no-autoloader] [--no-progress] [--n>
taavi closed this task as Resolved.Sun, Apr 21, 10:13 PM
taavi claimed this task.

This should be fixed on the next run.

CodeReviewBot added a project: Patch-For-Review.Tue, Apr 23, 2:02 AM

taavi opened https://gitlab.wikimedia.org/repos/ci-tools/libup/-/merge_requests/39

tasks: Handle runs that crash before audits complete

CodeReviewBot added a comment.Tue, Apr 23, 2:03 AM

taavi merged https://gitlab.wikimedia.org/repos/ci-tools/libup/-/merge_requests/39

tasks: Handle runs that crash before audits complete

Maintenance_bot removed a project: Patch-For-Review.Tue, Apr 23, 2:31 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL