Page MenuHomePhabricator

poolcounter-exporter upgrade
Closed, ResolvedPublic

Description

While investigating T309182: Evaluate 'pint' for Prometheus alerts pint flagged a problem with poolcounter alerts:

pint_problem{filename="/srv/alerts/ops/team-sre_poolcounter.yaml", instance="localhost:9123", job="pint", kind="alerting", name="PoolcounterFullQueues", problem="rate() should only be used with counters but "poolcounter_full_queues" is a gauge according to metrics metadata from prometheus "ops" at http://127.0.0.1:9900/ops", prometheus="ops", reporter="promql/rate", severity="bug", site="codfw"}

And indeed poolcounter_full_queues in our deployment is a gauge now, it was turned into a counter here: https://github.com/Wikia/poolcounter-prometheus-exporter/commit/f7bc8a2e13dff8e94bb6531cd523d92e9c0621d2

Updating our version of poolcounter-prometheus-exporter will fix the problem, cc @akosiaris what do you think ?

Event Timeline

Kappakayala triaged this task as Unbreak Now! priority.May 17 2023, 1:25 PM
Kappakayala lowered the priority of this task from Unbreak Now! to Needs Triage.

As part of T321808: Port all Icinga checks to Prometheus/Alertmanager I have imported 0.1.2 in gerrit and revamped the debian bits, next week I'll be uploading the debian package and upgrade \o/

Mentioned in SAL (#wikimedia-operations) [2025-02-04T13:09:39Z] <godog> upgrade poolcounter-prometheus-exporter to 0.1.2 - T333947

This is done, poolcounter-exporter upgraded and the related lint alert is gone too.