Page MenuHomePhabricator
Create Task
Maniphest T334307

Flickering during docker build output
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Update to >= Docker version 4.18.0
  • Make sure you clear pixel's build cache (e.g. ./pixel.js clean; docker system prune -a;)
  • Run npm i; ./pixel.js reference

What happens?:
Lots of flickering when docker tries to build pixel's images.

What should have happened instead?:
No flickering when docker tries to build pixel's images.

230244747-495f5800-1740-469c-ad24-27590cbaca25.mp43 MBDownload

Developer notes

This may be related to a bug in Docker (v. 4.18.0) as I first noticed this issue after updating my Docker version. Prior to updating, I didn't have this issue.

Event Timeline

• nray created this task.Apr 7 2023, 8:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 7 2023, 8:53 PM
Mhurd claimed this task.Apr 4 2024, 3:28 AM
Mhurd moved this task from Backlog to Doing on the Web Team Visual Regression Framework board.
Mhurd added a comment.EditedApr 4 2024, 3:34 AM

Using the new-ish --progress=plain flag in docker compose and docker build solved this:

https://github.com/wikimedia/pixel/pull/254/files#diff-57b743d11d7cdb3d271b8005cd049abab184eb5e7d651023101c459612af2d39R289

https://github.com/wikimedia/pixel/pull/255/files#diff-57b743d11d7cdb3d271b8005cd049abab184eb5e7d651023101c459612af2d39R18

Had to update the Docker on server to get the progress flag:

apt-get upgrade docker-ce docker-ce-cli docker-compose-plugin docker-buildx-plugin

After running those updates the progress flag was then confirmed to be present like this:

docker build --help | grep progress
docker compose --help | grep progress
Mhurd closed this task as Resolved.Apr 4 2024, 3:36 AM
Mhurd moved this task from Doing to Code Review on the Web Team Visual Regression Framework board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL