Page MenuHomePhabricator
Create Task
Maniphest T334308

Monthly Convert Popup with Other amount error UI not working
Closed, ResolvedPublic
Actions

Description

When test monthly convert, find logic for other amount should less than init payment, and it blocking the monthly convert, while not show the style at frontend, feel wired, should fix it
the code is in ext.donationInterface.monthlyConvert.js

Details

SubjectRepoBranchLines +/-
Add css for other amount and the larger amount class updatetmediawiki/extensions/DonationInterfacemaster+7 -1
Customize query in gerrit

Event Timeline

AnnWF created this task.Apr 7 2023, 9:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 7 2023, 9:02 PM
XenoRyet moved this task from Triage to DRI Backlog on the Fundraising-Backlog board.Apr 11 2023, 8:09 PM
AnnWF claimed this task.Apr 11 2023, 11:39 PM
AnnWF added a project: Fundraising Tech - Chaos Crew.
AnnWF moved this task from Backlog to In Progress on the Fundraising Tech - Chaos Crew board.
gerritbot added a comment.Apr 13 2023, 11:34 PM

Change 908662 had a related patch set uploaded (by Wfan; author: Wfan):

[mediawiki/extensions/DonationInterface@master] Add css for other amount and the larger amount class updatet

https://gerrit.wikimedia.org/r/908662

gerritbot added a project: Patch-For-Review.Apr 13 2023, 11:34 PM
AnnWF moved this task from In Progress to Ready for Review on the Fundraising Tech - Chaos Crew board.Apr 13 2023, 11:34 PM
gerritbot added a comment.Apr 25 2023, 11:56 PM

Change 908662 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] Add css for other amount and the larger amount class updatet

https://gerrit.wikimedia.org/r/908662

AnnWF moved this task from Ready for Review to Pending Deployment on the Fundraising Tech - Chaos Crew board.Apr 26 2023, 12:05 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 26 2023, 12:10 AM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Tech - Chaos Crew board.May 3 2023, 12:59 AM
XenoRyet closed this task as Resolved.May 9 2023, 7:14 PM
XenoRyet set Final Story Points to 1.
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 15 2023, 9:02 PM
Dwisehaupt moved this task from Done to Completed 20230426 - 20230522 on the Fundraising Tech - Chaos Crew board.May 22 2023, 7:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL