Page MenuHomePhabricator

Archive the Favorites extension
Closed, DeclinedPublicRequest

Description

Reason
https://www.mediawiki.org/wiki/Topic:Wp58ovh6lmcf91c4

To-do list

  • This task
    • Add maintainers of that extension as subscribers to this task (if they have no apparent Phabricator account, notify them on-wiki or via email if possible and note it here).
    • Add Phabricator project <#ProjectX> as a tag for this task, and remove MediaWiki-extensions-Other as appropriate.
  • On-wiki documentation
    • Archive documentation on mediawiki.org (https://www.mediawiki.org/wiki/Extension:Favorites): replace page contents with {{Archived extension|last revision id before archiving|task=T######}} (for extensions); replace T###### with this task's number.
    • If documentation page was translatable, remove <translate>, visit Special:PageTranslation, and click "remove from translation" (if you don't have the translation administrator right, ask a user who does).
    • Update Wikidata item (https://www.wikidata.org/wiki/Q21676669) associated with documentation page
      • add statement Abandonware (Q281039) to instance of (P31) together with qualifier start time (P580) = the YYYY-MM-DD date that you decided to archive extension (generally per edit history)
      • add qualifier end time (P582) = the YYYY-MM-DD (same date as above) to instance of (P31) = MediaWiki extension (Q6805426)
  • Phabricator
    • Mark all Phabricator tasks for the extension either Declined or Invalid. Add a comment pointing to this task when doing so for reference.
    • Archive Phabricator project <#ProjectX> for the extension.
    • Edit Phabricator project <#ProjectX> description for the extension with a link to this ticket.
  • Translatewiki.net/translations
  • Configuration/tests/integrations/etc.
  • Repositories

Event Timeline

Kizule moved this task from Untriaged to Archive extensions on the Projects-Cleanup board.
Kizule moved this task from Backlog to delete on the Wikimedia-GitHub board.
Kizule moved this task from Backlog to Projects to remove on the translatewiki.net board.

Is there no way to update it? also uses a deprecated hook

Uvas_magicas changed the task status from Open to Stalled.May 10 2023, 1:46 AM
Aklapper changed the task status from Stalled to Open.May 10 2023, 8:18 AM

@Uvas_magicas: Feel free to contribute patches to fix issues. Please do not change the task status for no reason. Thanks.

Kizule updated the task description. (Show Details)
Kizule added a project: User-Kizule.

Archiving the extension is a solution, but I feel it's the lazy one for when the issue is "there's a bit of bitrot and some things don't work quite right on the latest supported version(s) of MediaWiki".

The discussion linked does highlight some (but not all) issues with the extension. While the code isn't the prettiest I've ever seen, it's not the worst either, and fixing things like ApiBase::dieUsage/dieUsageMsg use or deprecated hook usages took me surprisingly little time. I'd hope the same is true for anyone who's been around for a while (and knows how to use things like codesearch, git log or even GitHub's web UI).

Give me a bit of time and I should have a patch uploaded to gerrit which oughta make the extension functional again, address the deprecation issues, improve code quality and hopefully render this task obsolete.

Change 969298 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):

[mediawiki/extensions/Favorites@master] A whole bunch of fixes

https://gerrit.wikimedia.org/r/969298