ReplaceText background job stores random IPs in recent changes table
Closed, DeclinedPublicBUG REPORT
Actions

Assigned To

None

Authored By

	Prod
	Apr 8 2023, 9:13 PM

Description

Steps to replicate the issue (include links if applicable):

have $wgJobRunRate > 0
Execute a replace text on a number of pages that triggers a background job to be scheduled for the execution

What happens?:
rc_ip in recentchanges table is filled in with random ip addresses of visitors to the site who triggered the individual jobs.

What should have happened instead?:
rc_ip in recentchanges table should be filled in with ip address of user who executed the original ReplaceText

Software version (skip for WMF-hosted wikis like Wikipedia):
MediaWiki 1.39.3
Extension:CheckUser 2.5
Extension:Replace Text 1.7

Event Timeline

Prod created this task.Apr 8 2023, 9:13 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 8 2023, 9:13 PM

Based on the task description, I don't think this is to do with CheckUser extension as said extension never modifies the rc_ip column (only reads from it when running update.php for the first time after installation of CheckUser).

If you mean the tables added by the CheckUser extension, then there are hooks provided by CheckUser since 1.40 that would allow the IP in cu_changes to be stored correctly.

As such I'm untagging CheckUser. If it is related please feel free to re-tag with some detail about what needs to be be done in the CheckUser extension. Alternatively another ticket could be filed regarding integrating with CheckUser as the fix for CheckUser would be different to the fix for recent changes.

Didn't mean to close. Mobile phabricator didn't tell me it was going to close it.

Prod added a project: MediaWiki-Recent-changes.Apr 8 2023, 11:28 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptApr 8 2023, 11:28 PM

Tgr moved this task from Inbox to Triaged on the Growth-Team board.Apr 13 2023, 10:04 PM

I'm declining this bug - as strange as this behavior is, it does seem to be the standard outcome when edits are made via jobs: the IP recorded is of the user who triggered the job to run, not the user who created the job in the first place. I looked through the code, and there doesn't seem to be a way to set the "rc_ip" value to anything other than the IP address of the user currently in the session. Which means that this storage appears to be the desired behavior.

ReplaceText background job stores random IPs in recent changes tableClosed, DeclinedPublicBUG REPORTActions

Description

Event Timeline

ReplaceText background job stores random IPs in recent changes table
Closed, DeclinedPublicBUG REPORT
Actions