| BrandonXLF | |
| Apr 11 2023, 5:30 AM |
| F36948364: Screenshot 2023-04-12 at 8.17.50 AM.png | |
| Apr 12 2023, 3:18 PM |
| F36948362: Screenshot 2023-04-12 at 8.17.38 AM.png | |
| Apr 12 2023, 3:18 PM |
| F36946699: image.png | |
| Apr 11 2023, 5:30 AM |
Right now, the print footer is shown in the direction of the article's language, since it's included in mw-body-content.
But since it's an interface language, it can appear in the wrong direction if the interface language is not the same as the article language.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Use user language for printSource wrapper | mediawiki/core | master | +2 -2 |
Makes sense and nice catch. Patch very much welcome.
The associated code is https://gerrit.wikimedia.org/g/mediawiki/core/+/0856164ba6322ea00ada33c287ec897125007ad8/includes/skins/SkinMustache.php#81 - so this impacts all skins.
Change 907966 had a related patch set uploaded (by BrandonXLF; author: BrandonXLF):
[mediawiki/core@master] Use user language for printSource wrapper
@Jdlrobson I noticed that lang, dir, and mw-content-dir are used quite a few times throughout MediaWiki and extensions. Would it be beneficial to add a helper function like Html::languageWrap that creates a div with the required attributes?
Not sure if it makes sense to have a generic helper function at this point, but for Skins you can make use of the existing Skin::getUserLanguageAttributes method. Thanks for the patch!
Change 907966 merged by jenkins-bot:
[mediawiki/core@master] Use user language for printSource wrapper
