Right now maintain_kubeusers checks $home/crontab.disabled before disabling k8s, and after disabling indicates success by touching $home/k8s.disabled.
As part of T332514, maintain_kubeusers that needs to change -- it should instead check the s51051__disable_tool.toolstate for the 'crontab_disabled' flag and then set 'kubernetes_disabled' when finished.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | bd808 | T133777 Tools that should get archived/deleted (tracking) | |||
| Resolved | Andrew | T170355 Figure out process for deleting an unused tool | |||
| In Progress | Andrew | T332514 Store state information for the disable tool process outside NFS | |||
| Resolved | dcaro | T342563 [harbor] Stabilize the current installation | |||
| Resolved | Raymond_Ndibe | T337386 [builds-api.start] Create the harbor project beforehand if it does not exist | |||
| Open | None | T334629 Update maintain_kubeusers to use the toolstate database | |||
| Resolved | dcaro | T334585 [cookbooks.wmcs.toolforge.component.deploy] Add secrets support when deploying | |||
| Resolved | dcaro | T304532 buildservice: migrate to helmfile from of kustomize |
The only tricky part of this is getting the database credentials for the admin tool injected into maintain_kubeusers. I don't immediately know how to do that... @taavi are you interested in taking on this subtask? The creds will look something like https://gerrit.wikimedia.org/r/c/operations/puppet/+/907983
Indeed. A quick and hacky solution would be to create a Secret for that manually, and a proper solution is T334585: [cookbooks.wmcs.toolforge.component.deploy] Add secrets support when deploying.. do you have any preferences which approach to take for now?
The first few steps for having a decent development environment to work on this has been made:
I guess the next logical step would be to have some kind of fake toolsdb that can be used in the same development setup.
The times for esoteric (or nonexistent) maintain-kubeusers development setup should end.
note: this is mostly about duplicating the logic from here https://gerrit.wikimedia.org/r/plugins/gitiles/cloud/toolforge/disable-tool/+/refs/heads/master/disable_tool.py#554 into maintain_kubeusers