Page MenuHomePhabricator
Create Task
Maniphest T335076

Manually run database housekeeper cleanup task
Open, LowPublic
Actions

Description

Background
See https://phabricator.wikimedia.org/T334759#8794589

To improve app launch times, we could perform a one-time database housekeeper cleanup task call upon app launch.

Task
I suggest we show the migration "loading" animation in case it takes a while. We should take care that it can continue cleaning up where it left off in case the user backgrounds or terminates during this.

We should also maybe perform this cleanup task when the user taps "Clear cache" in app Settings

LOE
Estimated time: 1 week

Design Review Instructions

Possible Risks

Test Plan
Provide a way for QA to populate local database with a huge amount of explore feed data and articles. Use exported user libraries for data population ideas. Then have QA update with build and confirm they see updating animation with progress bar.

Related Objects

Event Timeline

Tsevener created this task.Apr 19 2023, 9:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 19 2023, 9:41 PM
Tsevener mentioned this in T334759: [SPIKE] Investigate performance issues in app.Apr 19 2023, 9:52 PM
JTannerWMF triaged this task as Low priority.Apr 25 2023, 8:55 PM
JTannerWMF moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.
JTannerWMF subscribed.

We will see how the other tasks related to this one resolves the performance issues, and depending on the outcome we will raise the priority and bring it into the release board.

Tsevener added a comment.May 16 2023, 6:45 PM

@JTannerWMF this was one of the tickets I proposed for performance next steps. I'll make the other one before our 1-on-1.

JTannerWMF updated the task description. (Show Details)May 16 2023, 9:17 PM
Tsevener updated the task description. (Show Details)May 16 2023, 9:19 PM
JTannerWMF raised the priority of this task from Low to Medium.May 16 2023, 9:21 PM
JTannerWMF added a project: iOS Release FY2023-24 (Archive).
JTannerWMF moved this task from Tasks from Product Backlog to Doing on the iOS Release FY2023-24 (Archive) board.
Tsevener claimed this task.May 17 2023, 6:30 PM
Tsevener added a comment.May 19 2023, 11:14 PM

Just a heads up - so far in my testing with big data dumps, a giant database of Explore feed data is not causing perceivable additional load time (now that we've maxed out the Explore feed cards at 30 days). So I don't think this ticket is worth doing right now. I'm going to do a little bit more testing to be sure, then lower the priority and move back to the backlog. I have found more likely causes of our recent performance issues (see T337073).

Tsevener removed Tsevener as the assignee of this task.May 20 2023, 12:25 AM
Tsevener lowered the priority of this task from Medium to Low.
Tsevener removed a project: iOS Release FY2023-24 (Archive).May 23 2023, 9:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL