Page MenuHomePhabricator
Create Task
Maniphest T335420

Create TCL image for Toolforge based on a supported Debian release
Closed, ResolvedPublic
Actions

Description

Per https://k8s-status.toolforge.org/images/docker-registry.tools.wmflabs.org/toolforge-tcl86-sssd-web:latest/ there are two tools (giftbot & linksearch) actively using the TCL image that is using a deprecated Debian stretch base image. Debian has dropped stretch from their mirror servers making rebuilding this image problematic at best.

We should make a replacement TCL image based on a supported Debian release and let the https://toolsadmin.wikimedia.org/tools/id/giftbot and https://toolsadmin.wikimedia.org/tools/id/linksearch maintainers know about it.

Details

SubjectRepoBranchLines +/-
tcl86: switch base image to bullseyeoperations/docker-images/toollabs-imagesmaster+3 -3
Customize query in gerrit

Related Objects

Event Timeline

bd808 created this task.Apr 26 2023, 3:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 26 2023, 3:25 PM
bd808 added subscribers: doctaxon, Giftpflanze.Apr 26 2023, 3:58 PM

Buster has TCL 8.6.9 and bullseye has TCL 8.6.11. The legacy stretch container has TCL 8.6.6. I think we can just reuse the existing tcl86/tcl8.6 labels and bump the base image to bullseye without anything scary happening.

@Giftpflanze and @doctaxon does that sound reasonable to the two of you?

doctaxon added a comment.Apr 26 2023, 4:37 PM

Why 8.6? There's already tcl/tk 8.7 out.

bd808 added a comment.Apr 26 2023, 5:13 PM
In T335420#8808356, @doctaxon wrote:

Why 8.6? There's already tcl/tk 8.7 out.

We generally install system packages produced by the Debian project. Today the most recent version of Debian that we are supporting in Toolforge is Debian Bullseye. Per https://packages.debian.org/bullseye/tcl, 8.6.11 is the version that would be available. Debian Bookworm is the "testing" release that will become stable next and it will have 8.6.13.

gerritbot added a comment.Apr 26 2023, 5:34 PM

Change 912343 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[operations/docker-images/toollabs-images@master] tcl86: switch base image to bullseye

https://gerrit.wikimedia.org/r/912343

gerritbot added a project: Patch-For-Review.Apr 26 2023, 5:34 PM
doctaxon added a comment.Apr 26 2023, 5:41 PM

okay, feel free to update tcl/tk

gerritbot added a comment.Apr 27 2023, 8:26 PM

Change 912343 merged by jenkins-bot:

[operations/docker-images/toollabs-images@master] tcl86: switch base image to bullseye

https://gerrit.wikimedia.org/r/912343

Maintenance_bot removed a project: Patch-For-Review.Apr 27 2023, 8:30 PM
bd808 closed this task as Resolved.Apr 27 2023, 10:30 PM
bd808 claimed this task.
$ webservice tcl8.6 shell
shell-1682634486:~$ echo 'puts [info patchlevel];exit 0' | tclsh
8.6.11

The next time that the giftbot and linksearch services are restarted they should pick up the new container from the registry.

Restricted Application added a project: User-bd808. · View Herald TranscriptApr 27 2023, 10:30 PM
bd808 mentioned this in rODIT96b48b0473fa: tcl86: switch base image to bullseye.Apr 28 2023, 12:11 AM
doctaxon added a project: TaxonBot.Apr 28 2023, 3:33 AM
doctaxon moved this task from Backlog to Webservice/DB on the TaxonBot board.Apr 28 2023, 11:03 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL