Page MenuHomePhabricator
Create Task
Maniphest T335635

Solve expectedFailure for site_generators_tests
Closed, ResolvedPublicBUG REPORT
Actions

Description

TestSiteGeneratorsUsers.test_allusers_with_group() is marked as expectedFailure. previously the test was deactivated since
rPWBCf5998611 The reason is that with the path listed above the generator was changed from site.allusers(prefix="D", group="sysop", total=5) site.allusers(prefix='D', group='bot', total=5). The group request was changed from sysop to bot but the test was not changed accordingly and died not found any sysop in the given group.

Details

SubjectRepoBranchLines +/-
[test] Fix test_allusers_with_group tests/site_generators_tests.pypywikibot/coremaster+1 -2
Customize query in gerrit

Related Objects

Event Timeline

Xqt created this task.Apr 30 2023, 9:15 AM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptApr 30 2023, 9:15 AM
Xqt changed the task status from Open to In Progress.Apr 30 2023, 9:15 AM
Xqt claimed this task.
Xqt triaged this task as High priority.
gerritbot added a comment.Apr 30 2023, 9:18 AM

Change 913654 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [test] Fix test_allusers_with_group tests/site_generators_tests.py

https://gerrit.wikimedia.org/r/913654

gerritbot added a project: Patch-For-Review.Apr 30 2023, 9:18 AM
Xqt added a parent task: T129368: Usages of unittest.expectedFailure or unittest.skip should be solved (goal).Apr 30 2023, 9:18 AM
gerritbot added a comment.Apr 30 2023, 9:53 AM

Change 913654 merged by Xqt:

[pywikibot/core@master] [test] Fix test_allusers_with_group tests/site_generators_tests.py

https://gerrit.wikimedia.org/r/913654

Xqt closed this task as Resolved.Apr 30 2023, 9:53 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 30 2023, 10:10 AM
Xqt removed a parent task: T129368: Usages of unittest.expectedFailure or unittest.skip should be solved (goal).Mon, Jul 1, 11:20 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits