Page MenuHomePhabricator
Create Task
Maniphest T129368

Usages of unittest.expectedFailure or unittest.skip should be solved (goal)
Open, LowPublicGoal
Actions

Description

There are a lot of unittest.expectedFailure decorators. There should be a good reason to keep it. Otherwise the problem should be solved.

I found some inside

  • aspects.py
  • api-tests.py
  • cosmetic_changes_tests.py
  • file_tests
  • imagecopy_tests.py (archived)
  • interwiki_link_tests
  • isbn_tests.py (archived)
  • page_tests.py
  • pagegenerators_tests.py
  • pwb_tests.py
  • reflinks_tests.py
  • script_tests.py
  • site_detect_tests.py
  • site_generators_tests
  • site_tests.py
  • template_bot_tests.py
  • tests_tests.py <-- probably intentional as test
  • textlib_tests.py <-- some tests look wrong to me
  • time_tests.py
  • tools_ip_tests.py
  • tools_tests.py
  • upload_tests.py
  • utils.py
  • wikibase_tests.py

bold means bug tasks are created and marked as blocker

Find untagged issues:
https://codesearch.wmcloud.org/pywikibot/?q=%40.*expectedFailure%24&files=&excludeFiles=&repos=

Find all unsolves issues:
https://codesearch.wmcloud.org/pywikibot/?q=%40.*expectedFailure&files=&excludeFiles=&repos=

Find other issues added by tests config
https://codesearch.wmcloud.org/pywikibot/?q=%3D+.*expectedFailure&files=&excludeFiles=&repos=

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
tests: add pbab tasks hints to expectedFailure decoratorsXqtpywikibot/coremaster+13 -13
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenGoalNoneT129368 Usages of unittest.expectedFailure or unittest.skip should be solved (goal)
 OpenNoneT130918 TestLiveCosmeticChanges.test_cleanUpLinks erroneously doesn't fail unittest
 OpenNoneT133276 textlib.does_text_contain_section fails for encoded section title
 OpenNoneT145325 PropertyGenerator fails for two or many continuation limited
 OpenNoneT194138 generate_family_file test fails if lang is different from code
 OpenXqtT356009 page_tests.TestPageObject.testLinks sometimes fails due to missing namespace
 OpenBUG REPORTNoneT356013 wrong url redirection for wikimediafoundation.org api
 OpenNoneT362384 pagegenerators_tests fails on wowwiki:uk
 StalledBUG REPORTNoneT325860 Unable to submit any pywikibot.WbTime with hour/minute/second even if precision is day or lower
 OpenNoneT57755 Allow time values more precise than day on Wikidata
 OpenNoneT367260 Write test CI github action has ~ 22 failing tests or errors
 ResolvedXqtT367259 TestProtectionBot.test_summary() of protectbot_tests fails with AssertionError
 ResolvedBUG REPORTXqtT367257 PatrolTestCase.test_patrol() fails with AttributeError in token_tests.py
 ResolvedBUG REPORTXqtT367258 TestPageDelete.test_delete() of page_tests_tests fails with AttributeError
 ResolvedXqtT367166 Pywikibot does not raise TitleblacklistError in edit_failure_tests
 ResolvedXqtT367176 pywikibot.exceptions.APIError: toofewexpiries: occures in TestProtectionBot.test_protect
 ResolvedXqtT367185 TestSiteSysopWrite.test_protect_exception fails with protect-invalidaction APIError
 ResolvedXqtT367037 TestDeletionBotWrite.test_delete() of deletionbot_tests fails with TypeError
 ResolvedXqtT367296 TestSiteSysopWrite.test_protect_exception() of site_tests fails with Error
 ResolvedXqtT367299 TestDeletionBotUser.test_delete_mark() of deletionbot_tests fails with invalid token
 ResolvedXqtT367300 TestSiteMergeHistory.test_merge_history() of edit_tests fails with overlap error
 OpenNoneT367309 TestSiteSysopWrite.test_revdel_file() of site_tests fails with AssertionError
 ResolvedXqtT367311 TestThankRevision.test_thank_revision() of thanks_tests fails with invalid revision ID
 OpenNoneT367314 TestUpload.test_continue_filekey_once() of upload_tests fails with AssertionError
 OpenNoneT367316 TestUpload.test_offset_missmatch() of upload_tests fails woth AssertionError
 OpenNoneT367317 TestUpload.test_offset_oversize() of upload_tests fails with AssertionError
 OpenNoneT367319 TestUpload.test_png() of upload_tests fails with invalid path or duplicate file error
 OpenNoneT367320 TestUpload.test_png_chunked() of upload_tests fails with duplicate error
 OpenNoneT367321 TestUpload.test_sha1_missmatch() of upload_tests fails with AssertionError
 OpenNoneT367324 TestWikibaseWriteGeneral.test_edit_entity_propogation() of wikibase_edit_tests fails with AssertionError
 OpenNoneT367326 TestWikibaseMakeClaim.test_Coordinate_edit() of wikibase_edit_tests fails with missing required field "precision"
 OpenNoneT367327 TestWikibaseMakeClaim.test_WbTabularData_edit() of wikibase_edit_tests fails with ValueError
 OpenNoneT133288 Fix test for TestUpload and remove expectedFailure decorator
 OpenNoneT112543 Allow continuing the partially-complete upload in stashed mode after warning
 OpenBUG REPORTNoneT396714 Fix expectedFailure in cosmetic_changes.TestCosmeticChanges.test_cleanUpLinks
 ResolvedBUG REPORTXqtT391761 Some tests of file_tests.TestFilePageLatestFileInfo are failing recently
 DeclinedBUG REPORTNoneT391762 API: Imageinfo with iiurlwidth gives wrong results for thumbnail files
 ResolvedLadsgroupT360589 De-fragment thumbnail sizes in mediawiki
 OpenNoneT388792 Audit Growth maintained features: ensure compliance with standard thumbnail image sizes
 OpenFeatureNoneT420740 Extend API to be more transparent about thumbnail sizes
 OpenBUG REPORTNoneT396719 Fix expectedFailure in textlib_tests.TestReplaceLinks.test_label_diff_namespace
 OpenNoneT104805 textlib.replace_links() does not work as expected
 OpenBUG REPORTNoneT396721 Fix expectedFailure in textlib_tests.TestReplaceExcept.test_replace_tag_file_failure
 OpenBUG REPORTMahveotmT396723 Fix expectedFailure in time_tests.TestTimestamp.test_iso_format_with_sep
 OpenBUG REPORTXqtT145971 ItemPage.exists() throws pywikibot.exceptions.IsRedirectPage
 OpenBUG REPORTNoneT429874 TestSiteGeneratorsUsers.test_allusers test of site_generators_tests fails on wowwiki
 ResolvedGoalXqtT429880 Usages of unittest.expectedFailure or unittest.skip should be solved (solved)
 ResolvedXqtT368879 A lot of wikidata tests fails due to removal of P7829
 ResolvedBUG REPORTXqtT368908 PyWikibot Breaks on Q668 because of P7829
 ResolvedBUG REPORTXqtT396715 Fix expectedFailure in cosmetic_changes.TestLiveCosmeticChanges.test_translateMagicWords_fail
 ResolvedBUG REPORTXqtT396728 Fix unittest.skip in pagegenerators_tests
 ResolvedXqtT403292 CI tests fails on translatewiki with TimeoutError in _http_request when userinfo is retrieved
 ResolvedBUG REPORT• KgraessleT408667 recentchanges API result contains wrong entries with redirect: False
 ResolvedXqtT412605 test_https_cert_error method of http_tests.HttpsCertificateTestCase fails with threadfree Python
 OpenBUG REPORTNoneT431173 site_tests.TestProductionAndTestSite fails with TimeoutError
 OpenBUG REPORTNoneT420833 Beta cluster is being crawled to death by bot traffic coming from residential proxies
 ResolvedBUG REPORTXqtT331223 site_detect_tests fails on proofwiki

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Xqt renamed this task from Usages of unittest.expectedFailure should be solved (goal) to Usages of unittest.expectedFailure or unittest.skip should be solved (goal).Mar 8 2024, 12:30 PM
Xqt updated the task description. (Show Details)
Xqt changed the status of subtask T359427: site_generators_tests -v TestSiteGenerators.test_all_links fails on several wikis from Open to Stalled.Apr 21 2024, 10:40 AM
Xqt removed a subtask: T359427: site_generators_tests -v TestSiteGenerators.test_all_links fails on several wikis.Apr 21 2024, 2:52 PM
Xqt added a subtask: T362384: pagegenerators_tests fails on wowwiki:uk.Apr 22 2024, 7:49 AM
Xqt added a subtask: T363101: TestWikibaseMakeClaim.test_musical_notation_edit fails.Apr 22 2024, 2:57 PM
Xqt closed subtask T363101: TestWikibaseMakeClaim.test_musical_notation_edit fails as Resolved.Apr 22 2024, 4:09 PM
Xqt added a subtask: T325860: Unable to submit any pywikibot.WbTime with hour/minute/second even if precision is day or lower.Apr 23 2024, 11:11 AM
Xqt added a subtask: T367260: Write test CI github action has ~ 22 failing tests or errors.Jun 12 2024, 3:39 PM
Xqt added a subtask: T367303: TestFlowHide.test_hide() of flow_edit_tests fails with timeout.Jun 15 2024, 12:12 PM
Xqt removed a subtask: T130917: TestLiveCosmeticChanges.test_cleanUpLinks_pipes_fail erroneously doesn't fail unittest.Jul 1 2024, 11:09 AM
Xqt removed a subtask: T130919: page_tests.TestPageRepr.test_ASCII_compatible erroneously doesn't fail unittest.
Xqt removed a subtask: T130921: Enable page_tests.TestPageProtect.test_protect.
Xqt removed a subtask: T78522: pywikibot: Site.page_restrictions() is cached but not updated/cleared after calling Site.protect().
Xqt removed a subtask: T130925: remove unittest.expectedFailure from HtmlEntity.test_recursive_entities.
Xqt removed a subtask: T130928: Throw an error for incorrect logtypes for pagegenerators.handleArgs().
Xqt removed a subtask: T130985: Solve usage of expectedFailure for tools_tests.py.
Xqt removed a subtask: T132663: Improve tests for an expected failure in reflinks_tests.
Xqt removed a subtask: T134676: template_bot_tests fails for unknown reason.Jul 1 2024, 11:12 AM
Xqt removed a subtask: T110640: weblib.getWebCitationURL broken, causes testWebCiteOlder to fail.
Xqt removed a subtask: T135594: pytest doesnt respect __test__ = False on script_tests metaclass created methods.
Xqt removed a subtask: T145319: Re-enable test_allpages_langlinks_enabled without allowed_failure decorator.
Xqt removed a subtask: T174870: isbn.py may fail in treat_page_and_item() with missing attribute claims for an ItemPage.Jul 1 2024, 11:14 AM
Xqt removed a subtask: T181697: test_page_gen_redlink is failing with APIMWException.
Xqt removed a subtask: T196876: tests.site_tests.TestPagePreloading.test_preload_langlinks_count is marked as allowed_failure and should be fixed.
Xqt removed a subtask: T223030: Remove allowed_failure and allowed_failure_if from tests/utils.py.
Xqt removed a subtask: T209798: Enable unexpected successes?.
Xqt removed a subtask: T233484: Unexpected success with TestGenerateFamilyFiles.test_attributes_after_run .
Xqt removed a subtask: T251057: site_detect_tests.APIHiddenTestCase.test_ecoreality unexpectedly passes test.Jul 1 2024, 11:19 AM
Xqt removed a subtask: T272234: TestAlldeletedrevisionsAsUser tests for mysite.alldeletedrevisions are failing.
Xqt removed a subtask: T276038: cirrussearch-backend-error at beta cluster.
Xqt removed a subtask: T282962: ui_tests are failing on Travis.
Xqt removed a subtask: T254435: using pwb.py wrapper with global args before the script adds the script name to the scripts args list.
Xqt removed a subtask: T309442: test_other_wiki_prefix of link_tests.TestForeignInterwikiLinks fails.
Xqt removed a subtask: T335635: Solve expectedFailure for site_generators_tests.
Xqt removed a subtask: T352482: APIError: Petscan: No result for source categories.
Xqt removed a subtask: T355927: file_tests.TestMediaInfoReadonlyEditing: fails on NoUsernameError.
Xqt added a subtask: T368879: A lot of wikidata tests fails due to removal of P7829.
Xqt removed a subtask: T358986: AutoFamily cannot be created for infogalactic.com wiki due to outdated certificate.Jul 1 2024, 11:22 AM
Xqt removed a subtask: T359069: test_deprecated_function_docstring test of tools_deprecate_tests.DeprecatorTestCase fails with Python 3.13.
Xqt removed a subtask: T363101: TestWikibaseMakeClaim.test_musical_notation_edit fails.
Xqt closed subtask T368879: A lot of wikidata tests fails due to removal of P7829 as Resolved.Jul 1 2024, 1:36 PM
Xqt closed subtask T367303: TestFlowHide.test_hide() of flow_edit_tests fails with timeout as Declined.Jul 27 2024, 3:31 PM
Xqt added a subtask: T396714: Fix expectedFailure in cosmetic_changes.TestCosmeticChanges.test_cleanUpLinks.Jun 12 2025, 8:13 AM
Xqt added a subtask: T396715: Fix expectedFailure in cosmetic_changes.TestLiveCosmeticChanges.test_translateMagicWords_fail.Jun 12 2025, 8:27 AM
Xqt added a subtask: T391761: Some tests of file_tests.TestFilePageLatestFileInfo are failing recently.Jun 12 2025, 8:32 AM
Xqt added a subtask: T396719: Fix expectedFailure in textlib_tests.TestReplaceLinks.test_label_diff_namespace.Jun 12 2025, 8:45 AM
Xqt updated the task description. (Show Details)Jun 12 2025, 8:48 AM
Xqt added a subtask: T396721: Fix expectedFailure in textlib_tests.TestReplaceExcept.test_replace_tag_file_failure.Jun 12 2025, 8:54 AM
Xqt added a subtask: T396723: Fix expectedFailure in time_tests.TestTimestamp.test_iso_format_with_sep.Jun 12 2025, 9:05 AM
Xqt added a subtask: T145971: ItemPage.exists() throws pywikibot.exceptions.IsRedirectPage.Jun 12 2025, 9:07 AM
Xqt updated the task description. (Show Details)Jun 12 2025, 9:15 AM
Xqt added a subtask: T396728: Fix unittest.skip in pagegenerators_tests.Jun 12 2025, 9:19 AM
Xqt updated the task description. (Show Details)
gerritbot added a comment.Jun 12 2025, 9:34 AM

Change #1156282 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] tests: add pbab tasks hints to expectedFailure decorators

https://gerrit.wikimedia.org/r/1156282

gerritbot added a project: Patch-For-Review.Jun 12 2025, 9:34 AM
gerritbot added a comment.Jun 12 2025, 9:48 AM

Change #1156282 merged by jenkins-bot:

[pywikibot/core@master] tests: add pbab tasks hints to expectedFailure decorators

https://gerrit.wikimedia.org/r/1156282

Maintenance_bot removed a project: Patch-For-Review.Jun 12 2025, 10:31 AM
Xqt changed the status of subtask T396728: Fix unittest.skip in pagegenerators_tests from Open to In Progress.Jun 12 2025, 12:14 PM
Xqt closed subtask T396728: Fix unittest.skip in pagegenerators_tests as Resolved.Jun 12 2025, 12:21 PM
Xqt updated the task description. (Show Details)
Xqt added a subtask: T403292: CI tests fails on translatewiki with TimeoutError in _http_request when userinfo is retrieved.Aug 29 2025, 5:36 PM
Xqt updated the task description. (Show Details)
Xqt removed a subtask: T403292: CI tests fails on translatewiki with TimeoutError in _http_request when userinfo is retrieved.Aug 30 2025, 10:18 AM
Xqt updated the task description. (Show Details)
Xqt added a subtask: T403292: CI tests fails on translatewiki with TimeoutError in _http_request when userinfo is retrieved.Aug 30 2025, 3:19 PM
Xqt updated the task description. (Show Details)
Xqt updated the task description. (Show Details)Aug 30 2025, 3:23 PM
Xqt closed subtask T403292: CI tests fails on translatewiki with TimeoutError in _http_request when userinfo is retrieved as Resolved.Oct 11 2025, 11:02 AM
Xqt updated the task description. (Show Details)
Xqt changed the status of subtask T396715: Fix expectedFailure in cosmetic_changes.TestLiveCosmeticChanges.test_translateMagicWords_fail from Open to In Progress.Oct 14 2025, 3:32 PM
Xqt removed a parent task: T152961: Improve tests suite.Oct 18 2025, 7:14 AM
Xqt closed subtask T396715: Fix expectedFailure in cosmetic_changes.TestLiveCosmeticChanges.test_translateMagicWords_fail as Resolved.Oct 26 2025, 7:07 PM
Xqt updated the task description. (Show Details)Oct 29 2025, 9:28 AM
Xqt added a subtask: T408667: recentchanges API result contains wrong entries with redirect: False.
Xqt updated the task description. (Show Details)Oct 30 2025, 12:36 AM
Dillon closed subtask T408667: recentchanges API result contains wrong entries with redirect: False as Resolved.Oct 30 2025, 5:07 PM
Xqt closed subtask T391761: Some tests of file_tests.TestFilePageLatestFileInfo are failing recently as Resolved.Nov 3 2025, 2:49 PM
Xqt updated the task description. (Show Details)
Xqt added a subtask: T412605: test_https_cert_error method of http_tests.HttpsCertificateTestCase fails with threadfree Python.Dec 13 2025, 5:48 PM
Xqt closed subtask T412605: test_https_cert_error method of http_tests.HttpsCertificateTestCase fails with threadfree Python as Resolved.May 27 2026, 7:00 AM
Xqt removed a subtask: T367303: TestFlowHide.test_hide() of flow_edit_tests fails with timeout.Jun 23 2026, 8:50 AM
Xqt updated the task description. (Show Details)
Xqt updated the task description. (Show Details)Jun 23 2026, 8:52 AM
Xqt mentioned this in T429880: Usages of unittest.expectedFailure or unittest.skip should be solved (solved).Jun 23 2026, 8:58 AM
Xqt removed a subtask: T368879: A lot of wikidata tests fails due to removal of P7829.Jun 23 2026, 9:01 AM
Xqt removed a subtask: T396715: Fix expectedFailure in cosmetic_changes.TestLiveCosmeticChanges.test_translateMagicWords_fail.
Xqt removed subtasks: T412605: test_https_cert_error method of http_tests.HttpsCertificateTestCase fails with threadfree Python, T408667: recentchanges API result contains wrong entries with redirect: False, T403292: CI tests fails on translatewiki with TimeoutError in _http_request when userinfo is retrieved, T396728: Fix unittest.skip in pagegenerators_tests.Jun 23 2026, 9:04 AM
Xqt added subtasks: T429874: TestSiteGeneratorsUsers.test_allusers test of site_generators_tests fails on wowwiki, T429880: Usages of unittest.expectedFailure or unittest.skip should be solved (solved).Jun 23 2026, 9:07 AM
Xqt updated the task description. (Show Details)
Xqt closed subtask T429880: Usages of unittest.expectedFailure or unittest.skip should be solved (solved) as Resolved.
Xqt changed the subtype of this task from "Task" to "Goal".Jun 23 2026, 9:12 AM
Xqt added a subtask: T431173: site_tests.TestProductionAndTestSite fails with TimeoutError.Jul 4 2026, 10:28 AM
Xqt updated the task description. (Show Details)Jul 4 2026, 11:10 AM
Xqt added a subtask: T331223: site_detect_tests fails on proofwiki.Jul 5 2026, 6:23 PM
Xqt updated the task description. (Show Details)
Xqt closed subtask T331223: site_detect_tests fails on proofwiki as Resolved.Jul 18 2026, 1:20 PM
Xqt updated the task description. (Show Details)Jul 18 2026, 1:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits