Page MenuHomePhabricator
Create Task
Maniphest T254435

using pwb.py wrapper with global args before the script adds the script name to the scripts args list
Closed, ResolvedPublicBUG REPORT
Actions

Description

e.g. py -3 pwb.py -lang -family -simulate basics -foo -bar -baz gives ['basics', '-foo', '-bar', '-baz'] as arguments for basic.py whereas
py -3 pwb.py basics -foo -bar -baz gives ['-foo', '-bar', '-baz'] as expected.

Details

SubjectRepoBranchLines +/-
[bugfix] Use the scripts args executing a script with pwb.pypywikibot/coremaster+20 -18
[tests] Test whether pywikibot.argvu is not contaminated by global argspywikibot/coremaster+33 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Xqt created this task.Jun 4 2020, 8:22 AM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptJun 4 2020, 8:22 AM
Xqt triaged this task as Medium priority.Jun 4 2020, 8:22 AM
gerritbot added a comment.Jun 4 2020, 9:11 AM

Change 602298 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] Use the scripts args executing the script

https://gerrit.wikimedia.org/r/602298

gerritbot added a project: Patch-For-Review.Jun 4 2020, 9:11 AM
Xqt claimed this task.Jun 4 2020, 9:11 AM
Xqt changed the subtype of this task from "Task" to "Bug Report".Jun 4 2020, 9:24 AM
Xqt mentioned this in T242081: Pywikibot fails to access Wikidata due to high maxlag lately.Jun 23 2020, 7:43 AM
Xqt added a subscriber: Bugreporter.Jun 23 2020, 7:50 AM
Xqt raised the priority of this task from Medium to High.Nov 27 2021, 2:39 PM
Xqt added a project: Pywikibot-tests.

This also leads tests to fail if a global argument is passed to pwb wrapper
https://ci.appveyor.com/project/Ladsgroup/pywikibot-g4xqx/builds/41684969/job/tjwde82anclo8n7v

gerritbot added a comment.Nov 27 2021, 4:53 PM

Change 742216 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [tests] Test whether pywikibot.argvu is not contaminated by global args

https://gerrit.wikimedia.org/r/742216

Xqt added a parent task: T129368: Usages of unittest.expectedFailure or unittest.skip should be solved (goal).Nov 27 2021, 5:04 PM
gerritbot added a comment.Nov 27 2021, 5:15 PM

Change 742216 merged by jenkins-bot:

[pywikibot/core@master] [tests] Test whether pywikibot.argvu is not contaminated by global args

https://gerrit.wikimedia.org/r/742216

Xqt added a parent task: T296204: All script_tests fails at appveyor.Nov 27 2021, 6:45 PM
Xqt closed this task as Resolved.Nov 28 2021, 11:27 AM
gerritbot added a comment.Nov 28 2021, 11:39 AM

Change 602298 merged by jenkins-bot:

[pywikibot/core@master] [bugfix] Use the scripts args executing a script with pwb.py

https://gerrit.wikimedia.org/r/602298

Maintenance_bot removed a project: Patch-For-Review.Nov 28 2021, 12:10 PM
Xqt removed a parent task: T129368: Usages of unittest.expectedFailure or unittest.skip should be solved (goal).Jul 1 2024, 11:20 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits