All script_tests fails at appveyor
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Xqt
	Nov 22 2021, 5:16 PM

Description

List of steps to reproduce:

Running script_test on appveyor, all tests fail and commonscat test halts (or runs infinitely)

What happens?:

Running the test locally works as expected:

pwb.py script_tests -v TestScriptHelp.test_commonscat

C:\pwb\GIT\core>pwb.py script_tests -v TestScriptHelp.test_commonscat
tests: max_retries reduced from 15 to 1
commons_information depends on mwparserfromhell, which isn't available
patrol depends on mwparserfromhell, which isn't available
weblinkchecker depends on memento_client, which isn't available
test_commonscat (__main__.TestScriptHelp)
Test running commonscat -help. ... ok

----------------------------------------------------------------------
Ran 1 test in 0.804s

OK

C:\pwb\GIT\core>

Running tests on Appveyor fails and several scripts like commonscat -help test and interwikidata -help test never stops

https://ci.appveyor.com/project/Ladsgroup/pywikibot-g4xqx/builds/41621236/job/a9qghdg7itht37kf
https://ci.appveyor.com/project/Ladsgroup/pywikibot-g4xqx/builds/41625871/job/7bti97vhphhc45rs

What should have happened instead?:
The test should pass

Software version:
Pywikibot 7.0.0.dev0 after adding pwb script entry point in
rPWBC4f0ee4d

Details

Subject	Repo	Branch	Lines +/-
[bugfix] Only search user_script_paths inside config.base_dir	pywikibot/core	master	+28 -14
[tests] Only find one alternative script with script_tests.py	pywikibot/core	master	+8 -19
[tests] Only find one alternative script with script_tests.py	pywikibot/core	master	+28 -17
[tests] Temporary restrict runnable script_list in script_tests.py	pywikibot/core	master	+4 -3
[tests] Temporary add commonscat to unrunnable_script_set	pywikibot/core	master	+12 -12

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	BUG REPORT	Xqt	T296204 All script_tests fails at appveyor
		Resolved	BUG REPORT	Xqt	T254435 using pwb.py wrapper with global args before the script adds the script name to the scripts args list

Event Timeline

Xqt created this task.Nov 22 2021, 5:16 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptNov 22 2021, 5:16 PM

Xqt triaged this task as High priority.Nov 22 2021, 5:16 PM

Change 740644 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [tests] Temporary add commonscat to unrunnable_script_set

https://gerrit.wikimedia.org/r/740644

gerritbot added a project: Patch-For-Review.Nov 22 2021, 5:27 PM

Change 740644 merged by Xqt:

[pywikibot/core@master] [tests] Temporary add commonscat to unrunnable_script_set

https://gerrit.wikimedia.org/r/740644

Maintenance_bot removed a project: Patch-For-Review.Nov 22 2021, 6:10 PM

Change 740657 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [tests] Temporary restrict runnable script_list in script_tests.py

https://gerrit.wikimedia.org/r/740657

gerritbot added a project: Patch-For-Review.Nov 22 2021, 7:06 PM

Xqt updated the task description. (Show Details)Nov 22 2021, 7:07 PM

Change 740657 merged by Xqt:

[pywikibot/core@master] [tests] Temporary restrict runnable script_list in script_tests.py

https://gerrit.wikimedia.org/r/740657

Seems scripts aren't found anymore in this environment:

======================================================================
FAIL: test__login (tests.script_tests.TestScriptHelp)
Test running login -help.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\projects\pywikibot-g4xqx\tests\script_tests.py", line 242, in testScript
    stderr_other)
AssertionError: 'Use -help for further information.' not found in ['ERROR: login.py not found! Misspelling?', 'NOTE: Starting the most similar script login.py ***', '      in 5.0 seconds; type CTRL-C to stop.']
======================================================================
FAIL: test_add_text (tests.script_tests.TestScriptHelp)
Test running add_text -help.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\projects\pywikibot-g4xqx\tests\script_tests.py", line 242, in testScript
    stderr_other)
AssertionError: 'Use -help for further information.' not found in ['ERROR: add_text.py not found! Misspelling?', 'NOTE: Starting the most similar script add_text.py ***', '      in 5.0 seconds; type CTRL-C to stop.']
======================================================================
FAIL: test_archivebot (tests.script_tests.TestScriptHelp)
Test running archivebot -help.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\projects\pywikibot-g4xqx\tests\script_tests.py", line 242, in testScript
    stderr_other)
AssertionError: 'Use -help for further information.' not found in ['ERROR: archivebot.py not found! Misspelling?', 'NOTE: Starting the most similar script archivebot.py ***', '      in 5.0 seconds; type CTRL-C to stop.']
======================================================================
FAIL: test_basic (tests.script_tests.TestScriptHelp)
Test running basic -help.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\projects\pywikibot-g4xqx\tests\script_tests.py", line 242, in testScript
    stderr_other)
AssertionError: 'Use -help for further information.' not found in ['ERROR: basic.py not found! Misspelling?', 'NOTE: Starting the most similar script basic.py ***', '      in 5.0 seconds; type CTRL-C to stop.']
======================================================================
FAIL: test_blockpageschecker (tests.script_tests.TestScriptHelp)
Test running blockpageschecker -help.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\projects\pywikibot-g4xqx\tests\script_tests.py", line 242, in testScript
    stderr_other)
AssertionError: 'Use -help for further information.' not found in ['ERROR: blockpageschecker.py not found! Misspelling?', 'NOTE: Starting the most similar script blockpageschecker.py ***', '      in 5.0 seconds; type CTRL-C to stop.']
----------------------------------------------------------------------

The reason might be this change:

old:
testpath = os.path.join(_pwb_dir, *paths)

new:
testpath = os.path.join(config.base_dir, *paths)

Maintenance_bot removed a project: Patch-For-Review.Nov 22 2021, 8:11 PM

Xqt claimed this task.Nov 23 2021, 5:56 AM

Change 740899 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [tests] Only find one alternative script with script_tests.py

https://gerrit.wikimedia.org/r/740899

gerritbot added a project: Patch-For-Review.Nov 23 2021, 5:18 PM

Change 740899 merged by jenkins-bot:

[pywikibot/core@master] [tests] Only find one alternative script with script_tests.py

https://gerrit.wikimedia.org/r/740899