Unexpected success with TestGenerateFamilyFiles.test_attributes_after_run
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Xqt
	Sep 21 2019, 2:18 PM

Description

=================================== FAILURES ===================================
______________ TestGenerateFamilyFiles.test_attributes_after_run _______________
Unexpected success

Details

	Subject	Repo	Branch	Lines +/-
	[tests] Use allowed_failure with Python 2 behaviour	pywikibot/core	master	+17 -15
	[tests] use subTest to detect failing tests more specific	pywikibot/core	master	+3 -2

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Goal	Xqt	T225591 Make Travis and Appveyor pass again
Resolved		Xqt	T233484 Unexpected success with TestGenerateFamilyFiles.test_attributes_after_run
Open		None	T194138 generate_family_file test fails if lang is different from code

Event Timeline

Xqt created this task.Sep 21 2019, 2:18 PM

Restricted Application added a project: Pywikibot. · View Herald TranscriptSep 21 2019, 2:18 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald Transcript

Xqt triaged this task as High priority.Sep 21 2019, 2:18 PM

Xqt added a parent task: T194138: generate_family_file test fails if lang is different from code.

Change 538383 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [tests] use subTest to detect failing tests more specific

https://gerrit.wikimedia.org/r/538383

gerritbot added a project: Patch-For-Review.Sep 21 2019, 4:04 PM

Removing the expectedFailure decorator and enabling subTest we can find two sorts of failures:

Assertion Error reported in T194138
SiteDefinitionError reported in T233487

Xqt added a parent task: T129368: Usages of unittest.expectedFailure or unittest.skip should be solved (goal).Sep 21 2019, 4:54 PM

Xqt removed a parent task: T194138: generate_family_file test fails if lang is different from code.

Xqt added subtasks: T233487: creating a site from url raises SiteDefinitionError for closed wikis, T194138: generate_family_file test fails if lang is different from code.

Change 538383 merged by jenkins-bot:
[pywikibot/core@master] [tests] use subTest to detect failing tests more specific

https://gerrit.wikimedia.org/r/538383

Xqt mentioned this in rPWBC30f038bb68a8: [tests] use subTest to detect failing tests more specific.Sep 21 2019, 10:20 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 21 2019, 11:10 PM

Xqt closed subtask T233487: creating a site from url raises SiteDefinitionError for closed wikis as Resolved.Oct 1 2019, 3:10 AM

Change 548768 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [tests] Use allowed_failure with Python 2 behaviour

https://gerrit.wikimedia.org/r/548768

gerritbot added a project: Patch-For-Review.Nov 5 2019, 3:39 PM

Change 548768 merged by jenkins-bot:
[pywikibot/core@master] [tests] Use allowed_failure with Python 2 behaviour

https://gerrit.wikimedia.org/r/548768

Xqt mentioned this in rPWBC4a8cd1e9dd83: [tests] Use allowed_failure with Python 2 behaviour.Nov 22 2019, 1:40 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 22 2019, 2:10 PM

Currently throws an error in some Travis environments:

ERROR: test_attributes_after_run (tests.generate_family_files_tests.TestGenerateFamilyFiles)

Test FamilyFileGenerator attributes after run().

----------------------------------------------------------------------

Traceback (most recent call last):

  File "/home/travis/build/wikimedia/pywikibot/tests/utils.py", line 93, in wrapper

    func(*args, **kwargs)

  File "/home/travis/build/wikimedia/pywikibot/tests/generate_family_files_tests.py", line 65, in test_attributes_after_run

    site = Site(url=lang['url'])

  File "/home/travis/build/wikimedia/pywikibot/pywikibot/__init__.py", line 1229, in Site

    code, fam = _code_fam_from_url(url)

  File "/home/travis/build/wikimedia/pywikibot/pywikibot/__init__.py", line 1186, in _code_fam_from_url

    raise SiteDefinitionError("Unknown URL '{0}'.".format(url))

pywikibot.exceptions.SiteDefinitionError: Unknown URL 'https://gd.wikisource.org/wiki/$1'.

Dvorapa added a parent task: T225591: Make Travis and Appveyor pass again.Dec 7 2019, 12:11 AM

And sometimes there is an unexpected success in some AppVeyor environments.

In T233484#5719847, @Dvorapa wrote:

Currently throws an error in some Travis environments:

I think all of these SiteDefinitionError come from wikisource interwikimap. There are a lot of urls which does not exist but redirects to https://wikisource.org/wiki/Main_Page

I created a new task T241413 for this issue

So we can close this?

Xqt closed this task as Resolved.Mar 4 2020, 4:12 PM

Xqt closed subtask T194138: generate_family_file test fails if lang is different from code as Resolved.Apr 18 2023, 11:51 PM

Xqt reopened subtask T194138: generate_family_file test fails if lang is different from code as Open.Aug 18 2023, 11:14 AM

Xqt removed a parent task: T129368: Usages of unittest.expectedFailure or unittest.skip should be solved (goal).Jul 1 2024, 11:15 AM

Xqt removed a subtask: T233487: creating a site from url raises SiteDefinitionError for closed wikis.