Page MenuHomePhabricator

textlib.does_text_contain_section fails for encoded section title
Open, MediumPublic

Description

An encoded section title like Talk_.28discussion.29_pages is not found by this method and textlib_tests.TestSectionFunctions.testNonAlphabeticalCharactersInSection fails.
Therefore that test is marked as expectedFailure but the method should be improved thus the decorator can be removed then.

Event Timeline

Xqt triaged this task as Medium priority.Apr 21 2016, 12:26 PM
Xqt updated the task description. (Show Details)
Xqt added a subscriber: jayvdb.

Change 284684 had a related patch set uploaded (by Xqt):
Separate test until T133276 is solved

https://gerrit.wikimedia.org/r/284684

Change 286296 had a related patch set uploaded (by Dalba):
textlib: does_text_contain_section should accept anchorencoded values

https://gerrit.wikimedia.org/r/286296

Dalba removed Dalba as the assignee of this task.May 9 2016, 4:02 PM

Note that with T152540: Migrate to HTML5 section ids being resolved for MW 1.30, the algorithm for section title encoding has changed on Wikimedia projects. Although, according Manual:$wgFragmentMode the legacy method is still the default for new MediaWiki installations.

Related:

Dalba removed Dalba as the assignee of this task.EditedFeb 9 2019, 12:57 PM
Dalba removed a project: Patch-For-Review.

I do not have any plans to work on this feature in the near future.