Maniphest T335947

🏷️🐼 Validate the patched labels
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• WMDE_Norman
	May 4 2023, 11:55 AM

Tags

Referenced Files

None

Subscribers

• WMDE_Norman

Description

Handles all cases where the patched JSON structure cannot be deserialized into a valid label TermList (empty label, label too long, label containing invalid characters, language code)

Details

	Subject	Repo	Branch	Lines +/-
	REST: Handle empty patched label	mediawiki/extensions/Wikibase	master	+60 -2
	REST: Validate label text after patching	mediawiki/extensions/Wikibase	master	+290 -11
	REST: Extract label text validation	mediawiki/extensions/Wikibase	master	+178 -109

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T344228 Functionality for REST API v1
		Resolved		WMDE-leszek	T332739 🏷️🐼 Modify data of labels of an item
		Resolved		Jakob_WMDE	T335947 🏷️🐼 Validate the patched labels

Event Timeline

• WMDE_Norman created this task.May 4 2023, 11:55 AM

• WMDE_Norman updated the task description. (Show Details)

Jakob_WMDE claimed this task.May 10 2023, 9:12 AM

Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform (v1) (Sprint 28) board.

Change 918498 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Extract label text validation

https://gerrit.wikimedia.org/r/918498

gerritbot added a project: Patch-For-Review.May 10 2023, 2:30 PM

Change 918520 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Validate each label text after patching

https://gerrit.wikimedia.org/r/918520

Change 919152 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Handle empty patched label

https://gerrit.wikimedia.org/r/919152

Change 918498 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Extract label text validation

https://gerrit.wikimedia.org/r/918498

Change 918520 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Validate label text after patching

https://gerrit.wikimedia.org/r/918520

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform (v1) (Sprint 28) board.May 15 2023, 8:34 AM

Change 919152 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Handle empty patched label

https://gerrit.wikimedia.org/r/919152

Silvan_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform (v1) (Sprint 28) board.May 15 2023, 9:03 AM

Maintenance_bot removed a project: Patch-For-Review.May 15 2023, 9:10 AM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 16 2023, 8:01 PM

WMDE-leszek closed this task as Resolved.May 29 2023, 8:34 PM