Page MenuHomePhabricator
Create Task
Maniphest T336339

Upgrade Gerrit from 3.5.5 to 3.5.6
Closed, ResolvedPublic
Actions

Description

Gerrit 3.5.6 has been released https://www.gerritcodereview.com/3.5.html#356

Security Fix

Issue 16890 CVE-2019-12402: Fix DoS for Gerrit servers exposing Gitiles with the ability to download source archive
Bump common:compress version to 1.22 for protecting against an infinite loop triggered by downloading a source archive of files with a Unicode filename.

For bug fixes,

Change 362914 Fix internal server error caused by double flush in BaseCommand.TaskThunk

That might solves SshChannelClosedException T263293#8708846

Download-commands plugin fixes

Issue 15944: Update download-commands to latest master

Workarounds Gerrit/jgit not supporting OpenSSH 9 sftp subsystem which is T330740

Details

SubjectRepoBranchLines +/-
Update Gerrit to v3.5.6 and rebuild pluginsoperations/software/gerritdeploy/wmf/stable-3.5+31 -31
Merge tag 'v3.5.6' into wmf/stable-3.5operations/software/gerritwmf/stable-3.5+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.May 10 2023, 7:14 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 10 2023, 7:14 AM
hashar added a parent task: T263293: Can't `git pull` mediawiki/core from Gerrit: "fatal: the remote end hung up unexpectedly" SSH_MSG_CHANNEL_WINDOW_ADJUST.May 10 2023, 7:15 AM
hashar added a parent task: T330740: OpenSSH 9 scp does not work with Gerrit due to lack of sftp subsystem.
gerritbot added a comment.May 10 2023, 7:26 AM

Change 918352 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/software/gerrit@wmf/stable-3.5] Merge tag 'v3.5.6' into wmf/stable-3.5

https://gerrit.wikimedia.org/r/918352

gerritbot added a project: Patch-For-Review.May 10 2023, 7:26 AM
gerritbot added a comment.May 10 2023, 8:07 AM

Change 918361 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/software/gerrit@deploy/wmf/stable-3.5] Update Gerrit to v3.5.6

https://gerrit.wikimedia.org/r/918361

gerritbot added a comment.May 10 2023, 8:21 AM

Change 918352 merged by jenkins-bot:

[operations/software/gerrit@wmf/stable-3.5] Merge tag 'v3.5.6' into wmf/stable-3.5

https://gerrit.wikimedia.org/r/918352

gerritbot added a comment.May 10 2023, 8:21 AM

Change 918361 merged by jenkins-bot:

[operations/software/gerrit@deploy/wmf/stable-3.5] Update Gerrit to v3.5.6 and rebuild plugins

https://gerrit.wikimedia.org/r/918361

Maintenance_bot removed a project: Patch-For-Review.May 10 2023, 8:30 AM
Stashbot added a comment.May 10 2023, 8:48 AM

Mentioned in SAL (#wikimedia-operations) [2023-05-10T08:48:34Z] <hashar> deploy1002: git reset /srv/deployment/gerrit/gerrit which had bunch of locally modified files for some reason # T336339

Stashbot added a comment.May 10 2023, 8:49 AM

Mentioned in SAL (#wikimedia-operations) [2023-05-10T08:49:49Z] <hashar@deploy1002> Started deploy [gerrit/gerrit@67ba7ab]: Gerrit to 3.5.6 on gerrit2002 | T336339

Stashbot added a comment.May 10 2023, 8:49 AM

Mentioned in SAL (#wikimedia-operations) [2023-05-10T08:49:56Z] <hashar@deploy1002> Finished deploy [gerrit/gerrit@67ba7ab]: Gerrit to 3.5.6 on gerrit2002 | T336339 (duration: 00m 07s)

Stashbot added a comment.May 10 2023, 8:55 AM

Mentioned in SAL (#wikimedia-operations) [2023-05-10T08:55:52Z] <hashar> Stopping Gerrit for 3.5.5 > 3.5.6 upgrade T336339

Stashbot added a comment.May 10 2023, 8:56 AM

Mentioned in SAL (#wikimedia-operations) [2023-05-10T08:56:21Z] <hashar@deploy1002> Started deploy [gerrit/gerrit@67ba7ab]: Gerrit to 3.5.6 on gerrit1001 | T336339

Stashbot added a comment.May 10 2023, 8:56 AM

Mentioned in SAL (#wikimedia-operations) [2023-05-10T08:56:30Z] <hashar@deploy1002> Finished deploy [gerrit/gerrit@67ba7ab]: Gerrit to 3.5.6 on gerrit1001 | T336339 (duration: 00m 09s)

Stashbot added a comment.May 10 2023, 8:57 AM

Mentioned in SAL (#wikimedia-operations) [2023-05-10T08:57:16Z] <hashar@deploy1002> Started deploy [gerrit/gerrit@67ba7ab]: Gerrit to 3.5.6 on gerrit1001 | T336339

Stashbot added a comment.May 10 2023, 8:57 AM

Mentioned in SAL (#wikimedia-operations) [2023-05-10T08:57:21Z] <hashar@deploy1002> Finished deploy [gerrit/gerrit@67ba7ab]: Gerrit to 3.5.6 on gerrit1001 | T336339 (duration: 00m 05s)

Stashbot added a comment.May 10 2023, 9:01 AM

Mentioned in SAL (#wikimedia-operations) [2023-05-10T09:01:31Z] <hashar> Gerrit restarted at version 3.5.6 | T336339

hashar closed this task as Resolved.May 10 2023, 9:02 AM

Should be all good now. I have also resumed monitoring in Icinga.

hashar mentioned this in T326368: gerrit1003 service implementation task.May 10 2023, 4:20 PM
Stashbot added a comment.May 10 2023, 8:33 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-10T20:33:37Z] <hashar@deploy1002> Started deploy [gerrit/gerrit@e815301]: Gerrit to 3.5.6 on gerrit1003 | T336339

Stashbot added a comment.May 10 2023, 8:33 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-10T20:33:43Z] <hashar@deploy1002> Finished deploy [gerrit/gerrit@e815301]: Gerrit to 3.5.6 on gerrit1003 | T336339 (duration: 00m 06s)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits