Page MenuHomePhabricator

SX: Applying edited template translation to restored draft translation, appends it to the wrong position
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  1. Go to SX application
  2. Select a section with a template that can be adapted to the target language (e.g. a lead section with an infobox that exists in the target language, too) and translate a few sentences (not the template)
  3. Wait 3 seconds for the draft translation to be saved
  4. Go back to the dashboard and select the just created draft translation from the in-progress dashboard list, to continue the translation
  5. Click on the template and click to edit its proposed translation
  6. Once inside SX Editor, click on the "next" icon to apply the translation

What happens?:
The adapted template translation doesn't replace the source template inside the section contents (inside "Pick a sentence" step), but it rather replaces the next translation segment (sentence or template).

What should have happened instead?:
The adapted template translation should have replaced the source template inside the section contents, after being applied.

Other information (browser name/version, screenshots, etc.):

Screencast from greek (el) production wiki:

Event Timeline

ngkountas triaged this task as Medium priority.
ngkountas updated the task description. (Show Details)

Change 917838 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX: Wait for edited translation to be applied before closing editor

https://gerrit.wikimedia.org/r/917838

Change 917838 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Wait for edited translation to be applied before closing editor

https://gerrit.wikimedia.org/r/917838

Change 929037 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20230612

https://gerrit.wikimedia.org/r/929037

Change 929037 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20230612

https://gerrit.wikimedia.org/r/929037

This issue is now fixed in production. The edited template is positioned correctly.

Screencast from greek (el) production wiki:
part 1

part 2