Page MenuHomePhabricator

Make PHPUnit dataProvider on UstringLibraryTest and LuaEngineUnitTestBase static
Open, Needs TriagePublic

Description

The @dataProvider annotation should be a static function, make

  • UstringLibraryTest::provideUstringLibraryNormalizationTests
  • abstract LuaEngineTestBase::provideLuaData
  • abstract LuaEngineUnitTestBase::provideLuaData

static and adjust the usages (More infos at T332865).

Needs some compatibility code as some other extensions sub class the abstract class.

Initial work was done in 16189b5866e19b7cd6e2ec00b4171c9c1d0ec9a7