Page MenuHomePhabricator

Make PHPUnit dataProvider static in IPInfo tests
Closed, ResolvedPublic

Description

The @dataProvider annotation should be a static function, check and make data provider in the extension, at least:

  • BlockInfoRetrieverTest with provideRetrieveFromIP

static and adjust the usages (More infos at T332865).

Initial work was done in f5bcd03f759c5ac0f32269b4ab5f0a4f9b32b0fc

Event Timeline

Change #1140296 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/IPInfo@master] tests: Make PHPUnit data provider static

https://gerrit.wikimedia.org/r/1140296

Change #1140296 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] tests: Make PHPUnit data provider static

https://gerrit.wikimedia.org/r/1140296

Change #1149837 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/IPInfo@master] tests: Make PHPUnit data provider static

https://gerrit.wikimedia.org/r/1149837

Change #1149837 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] tests: Make PHPUnit data provider static

https://gerrit.wikimedia.org/r/1149837