Page MenuHomePhabricator
Create Task
Maniphest T337813

FunctionCall component: When selecting the same function, it adds repeated arguments
Closed, ResolvedPublicBUG REPORT
Actions

Description

Description

Steps to reproduce:

  1. select a function call
  2. select function And: first and second arguments will be added
  3. select function And again

Observed behavior:

  • second argument is repeated

Expected behavior (Acceptance criteria):

  • nothing should change

Completion checklist

Details

SubjectRepoBranchLines +/-
Fix setZFunctionCallArguments to not add duplicated argsmediawiki/extensions/WikiLambdamaster+36 -9
Customize query in gerrit

Event Timeline

gengh claimed this task.May 31 2023, 7:01 AM
gengh created this task.
gerritbot added a comment.May 31 2023, 7:02 AM

Change 924873 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Fix setZFunctionCallArguments to not added duplicated arg

https://gerrit.wikimedia.org/r/924873

gerritbot added a project: Patch-For-Review.May 31 2023, 7:02 AM
gerritbot added a comment.Jun 1 2023, 7:00 PM

Change 924873 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Fix setZFunctionCallArguments to not add duplicated args

https://gerrit.wikimedia.org/r/924873

Maintenance_bot removed a project: Patch-For-Review.Jun 1 2023, 7:10 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.12; 2023-06-06).Jun 1 2023, 8:00 PM
Jdforrester-WMF closed this task as Resolved.Jun 21 2023, 3:28 PM
Jdforrester-WMF updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL