Page MenuHomePhabricator
Create Task
Maniphest T337831

Remove specific nrpe::monitor_systemd_unit_state
Closed, ResolvedPublic
Actions

Description

The check is specific per-unit, although we have catch-all alerts nowadays, thus the alert is redundant

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

fgiunchedi created this task.May 31 2023, 9:43 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2023, 9:43 AM
gerritbot added a comment.May 31 2023, 9:48 AM

Change 924901 had a related patch set uploaded (by Filippo Giunchedi; author: Filippo Giunchedi):

[operations/puppet@production] Deprecate nrpe::monitor_systemd_unit_state

https://gerrit.wikimedia.org/r/924901

gerritbot added a project: Patch-For-Review.May 31 2023, 9:48 AM
lmata edited projects, added SRE Observability (FY2023/2024-Q1); removed SRE Observability (FY2022/2023-Q4).Jul 18 2023, 4:57 PM
SLyngshede-WMF subscribed.Aug 29 2023, 2:01 PM
lmata edited projects, added SRE Observability (FY2023/2024-Q2); removed SRE Observability (FY2023/2024-Q1).Oct 9 2023, 4:26 PM
fgiunchedi removed a project: SRE Observability (FY2023/2024-Q2).Jan 15 2024, 11:14 AM
gerritbot added a comment.Feb 6 2024, 8:07 AM

Change 924901 abandoned by Filippo Giunchedi:

[operations/puppet@production] Deprecate nrpe::monitor_systemd_unit_state

Reason:

Not useful as-is

https://gerrit.wikimedia.org/r/924901

gerritbot added a comment.Feb 6 2024, 11:45 AM

Change 997806 had a related patch set uploaded (by Filippo Giunchedi; author: Filippo Giunchedi):

[operations/puppet@production] graphite: remove nrpe::monitor_systemd_unit_state

https://gerrit.wikimedia.org/r/997806

gerritbot added a comment.Feb 6 2024, 11:45 AM

Change 997807 had a related patch set uploaded (by Filippo Giunchedi; author: Filippo Giunchedi):

[operations/puppet@production] cache: remove nrpe::monitor_systemd_unit_state

https://gerrit.wikimedia.org/r/997807

gerritbot added a comment.Feb 6 2024, 1:09 PM

Change 997807 merged by Filippo Giunchedi:

[operations/puppet@production] cache: remove nrpe::monitor_systemd_unit_state

https://gerrit.wikimedia.org/r/997807

gerritbot added a comment.Feb 6 2024, 1:11 PM

Change 997814 had a related patch set uploaded (by Filippo Giunchedi; author: Filippo Giunchedi):

[operations/puppet@production] cassandra: remove nrpe::monitor_systemd_unit_state

https://gerrit.wikimedia.org/r/997814

gerritbot added a comment.Feb 6 2024, 1:11 PM

Change 997815 had a related patch set uploaded (by Filippo Giunchedi; author: Filippo Giunchedi):

[operations/puppet@production] confd: remove nrpe::monitor_systemd_unit_state

https://gerrit.wikimedia.org/r/997815

gerritbot added a comment.Feb 6 2024, 1:11 PM

Change 997816 had a related patch set uploaded (by Filippo Giunchedi; author: Filippo Giunchedi):

[operations/puppet@production] chartmuseum: remove nrpe::monitor_systemd_unit_state

https://gerrit.wikimedia.org/r/997816

gerritbot added a comment.Feb 6 2024, 1:11 PM

Change 997817 had a related patch set uploaded (by Filippo Giunchedi; author: Filippo Giunchedi):

[operations/puppet@production] docker_registry: remove nrpe::monitor_systemd_unit_state

https://gerrit.wikimedia.org/r/997817

gerritbot added a comment.Feb 6 2024, 1:11 PM

Change 997818 had a related patch set uploaded (by Filippo Giunchedi; author: Filippo Giunchedi):

[operations/puppet@production] envoy: remove nrpe::monitor_systemd_unit_state

https://gerrit.wikimedia.org/r/997818

gerritbot added a comment.Feb 6 2024, 1:11 PM

Change 997819 had a related patch set uploaded (by Filippo Giunchedi; author: Filippo Giunchedi):

[operations/puppet@production] mediawiki: remove nrpe::monitor_systemd_unit_state

https://gerrit.wikimedia.org/r/997819

gerritbot added a comment.Feb 6 2024, 1:11 PM

Change 997820 had a related patch set uploaded (by Filippo Giunchedi; author: Filippo Giunchedi):

[operations/puppet@production] etcd: remove nrpe::monitor_systemd_unit_state

https://gerrit.wikimedia.org/r/997820

gerritbot added a comment.Feb 6 2024, 1:11 PM

Change 997821 had a related patch set uploaded (by Filippo Giunchedi; author: Filippo Giunchedi):

[operations/puppet@production] mariadb: remove nrpe::monitor_systemd_unit_state

https://gerrit.wikimedia.org/r/997821

gerritbot added a comment.Feb 6 2024, 3:02 PM

Change 997814 merged by Filippo Giunchedi:

[operations/puppet@production] cassandra: remove nrpe::monitor_systemd_unit_state

https://gerrit.wikimedia.org/r/997814

JMeybohm mentioned this in T356787: The label named state on node_systemd_service_restart_total metrics was changed to name.Feb 6 2024, 4:31 PM
gerritbot added a comment.Feb 7 2024, 8:58 AM

Change 997818 merged by Filippo Giunchedi:

[operations/puppet@production] envoy: remove nrpe::monitor_systemd_unit_state

https://gerrit.wikimedia.org/r/997818

gerritbot added a comment.Feb 7 2024, 9:00 AM

Change 997806 merged by Filippo Giunchedi:

[operations/puppet@production] graphite: remove nrpe::monitor_systemd_unit_state

https://gerrit.wikimedia.org/r/997806

gerritbot added a comment.Feb 7 2024, 10:54 AM

Change 997821 merged by Marostegui:

[operations/puppet@production] mariadb: remove nrpe::monitor_systemd_unit_state

https://gerrit.wikimedia.org/r/997821

gerritbot added a comment.Feb 7 2024, 1:15 PM

Change 997815 merged by Filippo Giunchedi:

[operations/puppet@production] confd: remove nrpe::monitor_systemd_unit_state

https://gerrit.wikimedia.org/r/997815

gerritbot added a comment.Feb 7 2024, 1:15 PM

Change 997816 merged by Filippo Giunchedi:

[operations/puppet@production] chartmuseum: remove nrpe::monitor_systemd_unit_state

https://gerrit.wikimedia.org/r/997816

gerritbot added a comment.Feb 7 2024, 1:15 PM

Change 997817 merged by Filippo Giunchedi:

[operations/puppet@production] docker_registry: remove nrpe::monitor_systemd_unit_state

https://gerrit.wikimedia.org/r/997817

gerritbot added a comment.Feb 7 2024, 1:15 PM

Change 997819 merged by Filippo Giunchedi:

[operations/puppet@production] mediawiki: remove nrpe::monitor_systemd_unit_state

https://gerrit.wikimedia.org/r/997819

gerritbot added a comment.Feb 7 2024, 1:16 PM

Change 997820 merged by Filippo Giunchedi:

[operations/puppet@production] etcd: remove nrpe::monitor_systemd_unit_state

https://gerrit.wikimedia.org/r/997820

fgiunchedi added a comment.Feb 7 2024, 1:21 PM

We have made significant progress here, with only one instance left in modules/icinga/manifests/monitor/etcd_mw_config.pp

nrpe::monitor_systemd_unit_state { 'update-etcd-mw-config-lastindex':
    expected_state => 'periodic',
    lastrun        => '60',
}

Note checing for mw config lastindex might go away as a whole, depending on T322523: Check confd last index in a mw-on-k8s world

Maintenance_bot removed a project: Patch-For-Review.Feb 7 2024, 1:30 PM
gerritbot added a comment.Feb 7 2024, 2:24 PM

Change 998417 had a related patch set uploaded (by Filippo Giunchedi; author: Filippo Giunchedi):

[operations/puppet@production] icinga: use systemd::timer::job for 'update-etcd-mw-config-lastindex'

https://gerrit.wikimedia.org/r/998417

gerritbot added a project: Patch-For-Review.Feb 7 2024, 2:24 PM
gerritbot added a comment.Feb 7 2024, 2:48 PM

Change 998424 had a related patch set uploaded (by Filippo Giunchedi; author: Filippo Giunchedi):

[operations/puppet@production] nrpe: remove monitor_systemd_unit_state

https://gerrit.wikimedia.org/r/998424

gerritbot added a comment.Feb 8 2024, 11:09 AM

Change 998417 merged by Filippo Giunchedi:

[operations/puppet@production] icinga: use systemd::timer::job for 'update-etcd-mw-config-lastindex'

https://gerrit.wikimedia.org/r/998417

gerritbot added a comment.Feb 8 2024, 11:23 AM

Change 998424 merged by Filippo Giunchedi:

[operations/puppet@production] nrpe: remove monitor_systemd_unit_state

https://gerrit.wikimedia.org/r/998424

gerritbot added a comment.Feb 8 2024, 11:29 AM

Change 998822 had a related patch set uploaded (by Filippo Giunchedi; author: Filippo Giunchedi):

[operations/puppet@production] nrpe: absent systemd_scripts

https://gerrit.wikimedia.org/r/998822

gerritbot added a comment.Feb 8 2024, 11:29 AM

Change 998823 had a related patch set uploaded (by Filippo Giunchedi; author: Filippo Giunchedi):

[operations/puppet@production] nrpe: cleanup check_systemd_unit_state

https://gerrit.wikimedia.org/r/998823

gerritbot added a comment.Feb 8 2024, 1:02 PM

Change 998822 merged by Filippo Giunchedi:

[operations/puppet@production] nrpe: absent systemd_scripts

https://gerrit.wikimedia.org/r/998822

gerritbot added a comment.Feb 8 2024, 1:42 PM

Change 998823 merged by Filippo Giunchedi:

[operations/puppet@production] nrpe: cleanup check_systemd_unit_state

https://gerrit.wikimedia.org/r/998823

fgiunchedi closed this task as Resolved.Feb 8 2024, 1:43 PM
fgiunchedi claimed this task.

This is completed!

Maintenance_bot removed a project: Patch-For-Review.Feb 8 2024, 2:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL