Page MenuHomePhabricator
Create Task
Maniphest T338177

ToggleSwitch: Enable and demonstrate groups of ToggleSwitches
Closed, ResolvedPublic
Actions

Description

The Figma spec includes groups of ToggleSwitches where all the switches are aligned to the end of the container. We should make this possible in Codex and demonstrate it on the ToggleSwitch demo page.

image.png (242×476 px, 17 KB)

  • Make it easy to achieve this layout
  • Demonstrate it (since it's just like a group of checkboxes)

Details

SubjectRepoBranchLines +/-
Update Codex from v0.11.0 to v0.12.0mediawiki/coremaster+1 K -1 K
ToggleSwitch: Enable and demonstrate switch groupsdesign/codexmain+202 -62
Customize query in gerrit

Event Timeline

AnneT created this task.Jun 5 2023, 6:47 PM
Restricted Application added a project: Design-System-Team. · View Herald TranscriptJun 5 2023, 6:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
AnneT edited projects, added Design-System-Team (Design-System-Sprint); removed Design-System-Team.Jun 5 2023, 6:48 PM
Restricted Application triaged this task as High priority. · View Herald TranscriptJun 5 2023, 6:48 PM
AnneT changed the task status from Open to In Progress.Jun 5 2023, 6:48 PM
AnneT moved this task from Committed to In Development on the Design-System-Team (Design-System-Sprint) board.
gerritbot added a comment.Jun 5 2023, 7:44 PM

Change 927254 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[design/codex@main] ToggleSwitch: Enable and demonstrate switch groups

https://gerrit.wikimedia.org/r/927254

gerritbot added a project: Patch-For-Review.Jun 5 2023, 7:44 PM
AnneT moved this task from In Development to Code Review on the Design-System-Team (Design-System-Sprint) board.Jun 5 2023, 9:02 PM
gerritbot added a comment.Jun 6 2023, 3:39 PM

Change 927254 merged by jenkins-bot:

[design/codex@main] ToggleSwitch: Enable and demonstrate switch groups

https://gerrit.wikimedia.org/r/927254

AnneT moved this task from Code Review to Pending Release on the Design-System-Team (Design-System-Sprint) board.Jun 6 2023, 3:46 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 6 2023, 4:11 PM
gerritbot added a comment.Jun 6 2023, 8:47 PM

Change 927786 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/core@master] Update Codex from v0.11.0 to v0.12.0

https://gerrit.wikimedia.org/r/927786

gerritbot added a project: Patch-For-Review.Jun 6 2023, 8:47 PM
PatchDemoBot added a comment.Jun 6 2023, 8:57 PM

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/8ca78d2715/w

gerritbot added a comment.Jun 6 2023, 10:14 PM

Change 927786 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.11.0 to v0.12.0

https://gerrit.wikimedia.org/r/927786

egardner closed this task as Resolved.Jun 6 2023, 10:27 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 6 2023, 10:30 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.13; 2023-06-13).Jun 6 2023, 11:00 PM
PatchDemoBot added a comment.Jun 8 2023, 5:29 PM

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/8ca78d2715/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL