Page MenuHomePhabricator
Create Task
Maniphest T338312

Set a JS config var to force VisualEditor to edit the current version
Closed, ResolvedPublicFeature
Actions

Description

Currently when ApprovedRevs is enabled and when editing page with no oldid specified, VE opens the approved version of the page, which may not be the current version (T334243). There should be a JS config var that allow ApprovedRevs and similar extensions to force VE to edit the current version.

Details

SubjectRepoBranchLines +/-
Set a JS config var to force VisualEditor to edit the current versionmediawiki/extensions/VisualEditormaster+3 -3
Rename wgFlaggedRevsEditLatestRevision to wgEditLatestRevisionmediawiki/extensions/FlaggedRevsmaster+1 -1
Set wgEditLatestRevision=true when no oldid specifiedmediawiki/extensions/ApprovedRevsmaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

Dringsim created this task.Jun 7 2023, 11:47 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 7 2023, 11:47 AM
Maintenance_bot added a project: VisualEditor.Jun 7 2023, 12:29 PM
gerritbot added a comment.Jun 7 2023, 12:59 PM

Change 928050 had a related patch set uploaded (by 沈澄心; author: 沈澄心):

[mediawiki/extensions/VisualEditor@master] Set a JS config var to force VisualEditor to edit the current version

https://gerrit.wikimedia.org/r/928050

gerritbot added a project: Patch-For-Review.Jun 7 2023, 12:59 PM
gerritbot added a comment.Jun 7 2023, 1:31 PM

Change 928054 had a related patch set uploaded (by 沈澄心; author: 沈澄心):

[mediawiki/extensions/ApprovedRevs@master] Set wgVisualEditorEditLatestRevision=true when no oldid specified

https://gerrit.wikimedia.org/r/928054

gerritbot added a comment.Jun 7 2023, 1:48 PM

Change 928057 had a related patch set uploaded (by 沈澄心; author: 沈澄心):

[mediawiki/extensions/FlaggedRevs@master] Rename wgFlaggedRevsEditLatestRevision to wgEditLatestRevision

https://gerrit.wikimedia.org/r/928057

Esanders updated the task description. (Show Details)Jun 7 2023, 4:55 PM
matmarex subscribed.Jun 14 2023, 1:38 AM
gerritbot added a comment.Jun 14 2023, 1:56 AM

Change 928050 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Set a JS config var to force VisualEditor to edit the current version

https://gerrit.wikimedia.org/r/928050

gerritbot added a comment.Jun 14 2023, 1:56 AM

Change 928054 merged by jenkins-bot:

[mediawiki/extensions/ApprovedRevs@master] Set wgEditLatestRevision=true when no oldid specified

https://gerrit.wikimedia.org/r/928054

gerritbot added a comment.Jun 14 2023, 1:56 AM

Change 928057 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Rename wgFlaggedRevsEditLatestRevision to wgEditLatestRevision

https://gerrit.wikimedia.org/r/928057

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 14 2023, 2:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 14 2023, 2:10 AM
matmarex added a project: Editing-team (Third-party).Jun 14 2023, 2:31 AM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.
matmarex closed this task as Resolved.Jun 14 2023, 2:37 AM
matmarex assigned this task to Dringsim.

Thank you for the patches!

Dringsim mentioned this in T334243: Edit links send the user to edit the approved revision instead of the current revision.Jun 14 2023, 3:54 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL