Page MenuHomePhabricator
Create Task
Maniphest T338613

[ES-M3] EntitySchemas shown by label in statements
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To
Michael
Authored By
Arian_Bozorg
Jun 9 2023, 1:54 PM
Tags
Referenced Files
F37099153: image.png
Jun 9 2023, 2:18 PM
F37099151: image.png
Jun 9 2023, 2:18 PM
F37099148: image.png
Jun 9 2023, 2:14 PM
F37099132: image.png
Jun 9 2023, 1:54 PM
F37099131: image.png
Jun 9 2023, 1:54 PM
Subscribers
Aklapper
Arian_Bozorg
Lucas_Werkmeister_WMDE
Michael

Description

As an editor, I want to easily identify what EntitySchema is being referred to in a statement.

Problem
Currently when statements are made using the new EntitySchema datatype the EntitySchema is only displayed by the ID, making it difficult for user to understand what the EntitySchema is for.

To make EntitySchemas more legible for users, we would like to display them by their label and replicate the format that is used for Items i.e. "Label"

Screenshot
How EntitySchemas are currently displayed in statements:

image.png (365×1 px, 42 KB)

How Items are displayed:

image.png (360×1 px, 27 KB)

BDD
GIVEN an EntitySchema
WHEN it is referred to in a statement
THEN it is shown as "Label"

Acceptance criteria:

  • the EntitySchema is shown with its label when referred to in statements
  • the language of the label follows the UI language

Notes

  • Language fallback will be done for this in T330491

Details

SubjectRepoBranchLines +/-
Show Labels for EntitySchema values in Statementsmediawiki/extensions/EntitySchemamaster+159 -20
Add LabelLookup servicemediawiki/extensions/EntitySchemamaster+272 -0
Customize query in gerrit

Related Objects

Event Timeline

Arian_Bozorg created this task.Jun 9 2023, 1:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 9 2023, 1:54 PM
Arian_Bozorg added projects: Wikidata, EntitySchema (M3: EntitySchemas shown as labels instead of ID).Jun 9 2023, 1:55 PM
Arian_Bozorg updated the task description. (Show Details)Jun 9 2023, 2:14 PM
Arian_Bozorg updated the task description. (Show Details)Jun 9 2023, 2:18 PM
Arian_Bozorg removed a subtask: T338615: [ES-M3] [EPIC] EntitySchema datatype accepts labels, aliases and IDs when making statements.Jun 20 2023, 1:30 PM
Arian_Bozorg updated the task description. (Show Details)Jun 21 2023, 8:53 AM
Michael updated the task description. (Show Details)Jun 21 2023, 8:54 AM
karapayneWMDE moved this task from Product Backlog to Unified DOT Backlog on the Wikidata Dev Team board.Jun 21 2023, 9:39 AM
Lucas_Werkmeister_WMDE subscribed.EditedJun 30 2023, 9:54 AM

Random tech notes from me:

  • The current formatting (link with ID as text) happens in EntitySchemaFormatter. We probably want to extend that class to add the label formatting (or potentially split the HTML and plain text cases into separate classes, but that might not be needed).
  • We can probably implement the label lookup the same way we implement the lookup in WikibaseLexeme: just load the whole EntitySchema data and get the label from there. We don’t need to use a more efficient term store until performance becomes too bad (which hasn’t even happened for lexemes yet – we’re still using this inefficient strategy there, as far as I’m aware).
    • But it should at least be in a separate service, not directly in the formatter.
    • [edit] This part also applies to T339921 / T339924 / T339925, I’d say – they should use that same service.
karapayneWMDE set the point value for this task to 8.Jul 11 2023, 10:09 AM
karapayneWMDE moved this task from Unified DOT Backlog to Sprint-∞ on the Wikidata Dev Team board.
karapayneWMDE edited projects, added Wikidata Dev Team (Sprint-∞); removed Wikidata Dev Team.
Michael claimed this task.Jul 11 2023, 2:37 PM
Michael moved this task from Parents/Waiting to Doing on the Wikidata Dev Team (Sprint-∞) board.
Michael subscribed.

I already have a PoC change doing basically exactly that. Might as well extend it to a proper change.

Restricted Application added a project: User-Michael. · View Herald TranscriptJul 11 2023, 2:37 PM
gerritbot added a comment.Jul 11 2023, 2:48 PM

Change 906643 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/EntitySchema@master] Show Labels for EntitySchema values with simple fallback

https://gerrit.wikimedia.org/r/906643

gerritbot added a project: Patch-For-Review.Jul 11 2023, 2:48 PM
gerritbot added a comment.Jul 12 2023, 1:20 PM

Change 937465 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/EntitySchema@master] Add LabelLookup service

https://gerrit.wikimedia.org/r/937465

gerritbot added a comment.Jul 18 2023, 10:13 AM

Change 937465 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Add LabelLookup service

https://gerrit.wikimedia.org/r/937465

gerritbot added a comment.Jul 18 2023, 10:13 AM

Change 906643 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Show Labels for EntitySchema values in Statements

https://gerrit.wikimedia.org/r/906643

Maintenance_bot removed a project: Patch-For-Review.Jul 18 2023, 10:29 AM
Michael moved this task from Doing to Product Verification on the Wikidata Dev Team (Sprint-∞) board.Jul 18 2023, 10:38 AM

This can now be verified on beta at https://wikidata.beta.wmflabs.org/wiki/Q535619

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.19; 2023-07-25).Jul 18 2023, 11:00 AM
Arian_Bozorg closed this task as Resolved.Jul 25 2023, 10:16 AM
Arian_Bozorg moved this task from Product Verification to Our work done on the Wikidata Dev Team (Sprint-∞) board.

Amazing!

Looks great, thanks so much :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits