Page MenuHomePhabricator
Create Task
Maniphest T339373

PageTriage should use packageFiles
Closed, ResolvedPublic
Actions

Description

Using packageFiles gives IDE benefits and also avoids issues with load order.

Currently the entirety of mw.pageTriage is a public API so doing this work will also allow us to limit this to only the bits that are intended to be public (especifically the mw.pageTriage.actionQueue)

Details

SubjectRepoBranchLines +/-
PackageFiles: ext.pageTriage.util, rewrite qunit as jestmediawiki/extensions/PageTriagemaster+157 -152
Drop mw.pageTriage.action from public APImediawiki/extensions/PageTriagemaster+2 -2
PackageFiles: ext.pageTriage.views.listmediawiki/extensions/PageTriagemaster+33 -8
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Jun 16 2023, 4:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 16 2023, 4:47 PM
gerritbot added a comment.Jun 16 2023, 4:48 PM

Change 918508 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/PageTriage@master] PackageFiles: ext.pageTriage.util

https://gerrit.wikimedia.org/r/918508

gerritbot added a project: Patch-For-Review.Jun 16 2023, 4:48 PM

Change 930823 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/PageTriage@master] PackageFiles: ext.pageTriage.views.list

https://gerrit.wikimedia.org/r/930823

gerritbot added a comment.Jun 16 2023, 4:48 PM

Change 930824 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/PageTriage@master] Drop mw.pageTriage.action from public API

https://gerrit.wikimedia.org/r/930824

Jdlrobson moved this task from Backlog to Priority technical debt on the PageTriage board.Jun 16 2023, 4:48 PM
Jdlrobson added a subscriber: jsn.sherman.
gerritbot added a comment.Jun 16 2023, 7:30 PM

Change 930823 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] PackageFiles: ext.pageTriage.views.list

https://gerrit.wikimedia.org/r/930823

gerritbot added a comment.Jun 16 2023, 7:38 PM

Change 930824 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Drop mw.pageTriage.action from public API

https://gerrit.wikimedia.org/r/930824

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 16 2023, 8:00 PM
gerritbot added a comment.Jun 16 2023, 11:58 PM

Change 918508 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] PackageFiles: ext.pageTriage.util, rewrite qunit as jest

https://gerrit.wikimedia.org/r/918508

Jdlrobson closed this task as Resolved.Jun 17 2023, 12:01 AM
Jdlrobson claimed this task.
Maintenance_bot removed a project: Patch-For-Review.Jun 17 2023, 12:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL