Page MenuHomePhabricator

Grant ML Team members +2 rights to the recommendation-api repository
Closed, ResolvedPublic

Description

Hi!

In T293648, the ML Team was tasked to migrate the recommendation-api from wmflabs to LiftWing.
We have started working on patches and would like to have +2 rights to the repo. Please see details below:

ML Team gerrit usernames and emails:

  • elukey (ltoscano@wikimedia.org)
  • klausman (tklausmann@wikimedia.org)
  • aikochou (achou@wikimedia.org)
  • isaranto (isarantopoulos@wikimedia.org)
  • kevinbazira (kbazira@wikimedia.org)

Repository to which access is required: https://gerrit.wikimedia.org/g/research/recommendation-api

Thanks in advance!

Event Timeline

[offtopic] @kevinbazira: Hi, as this ticket seems to have been created in a WMF staff role, it would be helpful for faster verification of requests to link the "MediaWiki User" entry of your Phabricator account to your SUL staff account instead of a self-created SUL account. You can do so by first logging into Phabricator via LDAP, and then going to your settings and changing the linked "MediaWiki" account. (And if there are team onboarding docs to update, that would also be welcome.) Thanks!

thcipriani claimed this task.
thcipriani subscribed.

Added folks to the mediawiki-services-recommendation-api group in Gerrit (which was previously...empty?). Folks should have owner permissions for that repository now (including +2).

Please re-open if you feel like I missed anything.

[offtopic] @kevinbazira: Hi, as this ticket seems to have been created in a WMF staff role, it would be helpful for faster verification of requests to link the "MediaWiki User" entry of your Phabricator account to your SUL staff account instead of a self-created SUL account. You can do so by first logging into Phabricator via LDAP, and then going to your settings and changing the linked "MediaWiki" account. (And if there are team onboarding docs to update, that would also be welcome.) Thanks!

@Aklapper, thank you for the ping. I have linked my SUL staff account and it's now visible on my Phabricator profile.

Added folks to the mediawiki-services-recommendation-api group in Gerrit (which was previously...empty?). Folks should have owner permissions for that repository now (including +2).

Please re-open if you feel like I missed anything.

@thcipriani thank you for helping with this. It looks like we were added to the recommendation-api NodeJS repo instead of the Python repo that we had requested for.

We now have +2 rights to the NodeJS repo

+2 rights exist on recommendation-api NodeJS repo - Screenshot from 2023-06-29 11-05-03.png (741×1 px, 182 KB)

But don't have +2 rights to the Python repo

+2 rights missing on recommendation-api Python repo - Screenshot from 2023-06-29 10-58-41.png (741×1 px, 151 KB)

Please grant us rights to this repo: https://gerrit.wikimedia.org/g/research/recommendation-api

Thanks!

@kevinbazira bah, sorry about that! Should be fixed now. Removed from mediawiki-services-recommendation-api added to research-recommendation-api now.