Hash collision on ExtDist, occurs 404 Not Found on Extension Distributor
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	MPThLee
	Jun 30 2023, 6:41 PM

Description

Steps to replicate the issue (include links if applicable):

Go to https://www.mediawiki.org/wiki/Special:ExtensionDistributor?extdistname=Math&extdistversion=REL1_39

What happens?:

It redirects to 404 Not Found

What should have happened instead?:
Should be downloaded normally.

Software version (skip for WMF-hosted wikis like Wikipedia): REL1_39

Other information (browser name/version, screenshots, etc.):
Seems like there's a bug? mistake? on the extdist. REL1_39 of Math has 8-chracter-length of commit sha. unlike others (which only has 7)
Thankfully, Extdist has autoindex so I figured out easily.

So, Filename should be Math-REL1_39-0484bb2.tar.gz for Extension Distributor

Details

	Subject	Repo	Branch	Lines +/-
	Increase hash length to 9 characters	labs/tools/extdist	master	+10 -2
	ExtDistProvider: Increase length of short hash	mediawiki/extensions/ExtensionDistributor	master	+3 -3

Customize query in gerrit

Related Objects

Mentioned In: T365416: 404 of FlaggedRevs-REL1_41-447bfbc.tar.gz

Event Timeline

MPThLee created this task.Jun 30 2023, 6:41 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 30 2023, 6:42 PM

MPThLee renamed this task from Extension Distributor has an issue with Math Extension REL1_39 to Extension Distributor has an issue with Math Extension REL1_39 - Wrong filename.Jun 30 2023, 6:46 PM

I just made a script for autoindex page that extract non-standard(?) format items.
console.log([...document.querySelectorAll("pre > a")].slice(1).map(t => t.getAttribute("href")).filter(str => !/\w+-(?:REL1_[0-9]{2}|master)-[a-z0-9]{7}.tar.gz/.test(str)).join("\n"))
And Math-REL1_39-0484bb21.tar.gz is the one and only.

MPThLee updated the task description. (Show Details)Jun 30 2023, 7:07 PM

$ git show 0484bb
error: short object ID 0484bb is ambiguous
hint: The candidates are:
hint:   0484bb21 commit 2023-06-20 - Localisation updates from https://translatewiki.net.
hint:   0484bb20 blob

Reedy added a project: VPS-project-Extdist.Jun 30 2023, 7:12 PM

Reedy added a subscriber: Legoktm.

Issue was solved by new commit triggered by Translate Wiki. But there's a small chance of this issue happens again.

Change 937473 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/ExtensionDistributor@master] ExtDistProvider: Increase length of short hash

https://gerrit.wikimedia.org/r/937473

gerritbot added a project: Patch-For-Review.Jul 12 2023, 4:35 PM

Change 937474 had a related patch set uploaded (by Reedy; author: Reedy):

[labs/tools/extdist@master] Increase hash length to 10 characters

https://gerrit.wikimedia.org/r/937474

MPThLee renamed this task from Extension Distributor has an issue with Math Extension REL1_39 - Wrong filename to Hash collision on ExtDist, occurs 404 Not Found on Extension Distributor.Jul 23 2023, 6:27 AM

I just changed title to make it clearer.

Bawolff mentioned this in T365416: 404 of FlaggedRevs-REL1_41-447bfbc.tar.gz.May 21 2024, 5:29 AM

Lens0021 subscribed.May 21 2024, 7:23 AM

An alternate fix was merged (Still 7 chars, but use 7 even if ambiguous)

Hash collision on ExtDist, occurs 404 Not Found on Extension DistributorClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

Hash collision on ExtDist, occurs 404 Not Found on Extension Distributor
Closed, ResolvedPublicBUG REPORT
Actions