Page MenuHomePhabricator
Create Task
Maniphest T341075

Fake section header "top" visible in Special:RegisterForEvent when form submission fails
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Find an event that has already ended
  • Go to Special:RegisterForEvent/XXX where XXX is the ID of that event
  • Submit the form

What happens?:
⧼top⧽ appears between a validation error and the first form field.

What should have happened instead?:
⧼top⧽ should not be shown.

Software version (skip for WMF-hosted wikis like Wikipedia):
master

Other information (browser name/version, screenshots, etc.):
Can be reproduced here: https://meta.wikimedia.beta.wmflabs.org/wiki/Special:RegisterForEvent/206

Details

SubjectRepoBranchLines +/-
Fix hiding of top section in Special:RegisterForEventmediawiki/extensions/CampaignEventsmaster+8 -2
Customize query in gerrit

Event Timeline

Daimona created this task.Jul 4 2023, 2:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 4 2023, 2:46 PM
gerritbot added a comment.Jul 4 2023, 3:12 PM

Change 935458 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Fix hiding of top section in Special:RegisterForEvent

https://gerrit.wikimedia.org/r/935458

Daimona claimed this task.Jul 4 2023, 3:12 PM
Daimona moved this task from Needs Input / Design in progress to Code Review on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.
gerritbot added a comment.Jul 5 2023, 9:23 AM

Change 935458 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Fix hiding of top section in Special:RegisterForEvent

https://gerrit.wikimedia.org/r/935458

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.17; 2023-07-11).Jul 5 2023, 10:00 AM
Daimona moved this task from Code Review to QA 🐛 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Jul 5 2023, 11:42 AM
vaughnwalters moved this task from QA 🐛 to Product Sign-Off on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Jul 5 2023, 5:46 PM
vaughnwalters subscribed.

✅ ⧼top⧽ is not shown between the validation error and the first form field, for private or public registration

Screenshot 2023-07-05 at 12.43.29 PM.png (1×2 px, 297 KB)

Screenshot 2023-07-05 at 12.44.58 PM.png (1×2 px, 295 KB)

vaughnwalters closed this task as Resolved.Jul 14 2023, 5:17 PM
vaughnwalters moved this task from Product Sign-Off to Done 🏁 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.

AC is met, moving this to resolved / done.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL