Page MenuHomePhabricator

vaughnwalters (Vaughn Walters)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 8 2022, 3:41 PM (24 w, 2 d)
Availability
Available
LDAP User
Vaughn Walters
MediaWiki User
VWalters-WMF [ Global Accounts ]

Recent Activity

Wed, Sep 21

vaughnwalters moved T317581: Add an abstraction for the ce_address table from QA πŸ› to Product sign-off 🀘 on the Campaign-Tools (Campaign-Tools-Sprint-20) board.
Wed, Sep 21, 10:19 PM Β· MW-1.40-notes (1.40.0-wmf.3; 2022-09-26), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters added a comment to T317581: Add an abstraction for the ce_address table.

βœ… This is functioning correctly. Sending to product sign off.

Wed, Sep 21, 10:18 PM Β· MW-1.40-notes (1.40.0-wmf.3; 2022-09-26), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters moved T313077: checkboxShift.js is incompatible with OOUI checkboxes from QA πŸ› to Product sign-off 🀘 on the Campaign-Tools (Campaign-Tools-Sprint-20) board.

@Daimona In testing here, this now functions correctly on the first 20 users, but shift click doesn't work to select multiple users after additional users are loaded in to the infinite scroll. See example here:

Ah yes, I knew that... The core code which makes the shift+click work only runs with the server-generated checkboxes, but not with the ones added dynamically. I guess there might be ways to fix it, but I'd leave that for another task.

Wed, Sep 21, 5:53 PM Β· MW-1.40-notes (1.40.0-wmf.2; 2022-09-19), Performance-Team, Campaign-Tools (Campaign-Tools-Sprint-20), JavaScript, OOUI, MediaWiki-Interface
vaughnwalters created T318261: Shift click does not select multiple users with dynamically added checkboxes.
Wed, Sep 21, 5:46 PM Β· CampaignEvents, Campaign-Tools
vaughnwalters added a comment to T309334: Display policy acknowledgement on Special:RegisterForEvent.

T309332 will cover this ticket @ifried

Wed, Sep 21, 4:15 PM Β· Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters added a comment to T309333: Create popup with policy acknowledgement for when users register on the event page.

T309332 should cover this @ifried

Wed, Sep 21, 4:15 PM Β· Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters moved T309332: Make it possible to specify a policy message to use when someone registers for an event from QA πŸ› to Product sign-off 🀘 on the Campaign-Tools (Campaign-Tools-Sprint-20) board.

example of testing Event:EventName on https://meta.wikimedia.beta.wmflabs.org/wiki/Event:Furnitureeditathon

Wed, Sep 21, 4:13 PM Β· MW-1.40-notes (1.40.0-wmf.3; 2022-09-26), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration

Tue, Sep 20

vaughnwalters added a comment to T313077: checkboxShift.js is incompatible with OOUI checkboxes.

@Daimona In testing here, this now functions correctly on the first 20 users, but shift click doesn't work after additional users are loaded in to the infinite scroll. See example here:

Tue, Sep 20, 4:55 PM Β· MW-1.40-notes (1.40.0-wmf.2; 2022-09-19), Performance-Team, Campaign-Tools (Campaign-Tools-Sprint-20), JavaScript, OOUI, MediaWiki-Interface
vaughnwalters closed T316128: Implement high-level database schema to store addresses, a subtask of T316126: [EPIC] Attach programmatic geolocation to campaign events , as Resolved.
Tue, Sep 20, 2:57 PM Β· Epic, Campaign-Registration, Campaign-Tools
vaughnwalters closed T316128: Implement high-level database schema to store addresses as Resolved.

DESCRIBE ce_address; on betacluster

Screen Shot 2022-09-19 at 11.41.25 PM.png (312Γ—1 px, 60 KB)

Tue, Sep 20, 2:57 PM Β· MW-1.40-notes (1.40.0-wmf.2; 2022-09-19), CampaignEvents, Campaign-Tools (Campaign-Tools-Sprint-20), Campaign-Registration

Mon, Sep 19

vaughnwalters added a comment to T318124: Show suppressed organizers' names to privileged users.

Along with showing the username should we also display something that lets the steward know the status of the organizer (globally suppressed / globally deleted)?

Mon, Sep 19, 11:03 PM Β· CampaignEvents, Campaign-Registration, Campaign-Tools
vaughnwalters moved T316294: Address Organized by: text in case of organizer being suppressed or deleted by Special:CentralAuth from Code Review/Tech Input πŸ’¬ to Design Sign-Off πŸ–ŒοΈ on the Campaign-Tools (Campaign-Tools-Sprint-20) board.

Yes, I meant deleting the global account with Special:CentralAuth. Since you created that follow up ticket, I will move this to design sign off. Also, good idea on showing deleted/suppressed names to stewards πŸ‘ .

Mon, Sep 19, 10:52 PM Β· MW-1.40-notes (1.40.0-wmf.2; 2022-09-19), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters added a comment to T318125: Handle deleted user accounts in "Organized by" text on event pages.

For an example, see Event:V-suppress-test-4 where user V-suppress-test-4 enabled the registration and then that account was deleted by a steward:

Mon, Sep 19, 10:49 PM Β· Patch-For-Review, Campaign-Tools (Campaign-Tools-Sprint-20), Campaign-Registration, CampaignEvents
vaughnwalters moved T316294: Address Organized by: text in case of organizer being suppressed or deleted by Special:CentralAuth from QA πŸ› to Code Review/Tech Input πŸ’¬ on the Campaign-Tools (Campaign-Tools-Sprint-20) board.

Suppress-test event is now displaying the suppressed name correctly:

Screen Shot 2022-09-19 at 4.07.33 PM.png (1Γ—3 px, 363 KB)

Mon, Sep 19, 10:19 PM Β· MW-1.40-notes (1.40.0-wmf.2; 2022-09-19), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters moved T308574: Implement search for participant list on EventDetails (JS experience) from QA πŸ› to Design Sign-Off πŸ–ŒοΈ on the Campaign-Tools (Campaign-Tools-Sprint-20) board.

functioning correctly for a long list of participants

Screen Recording 2022-09-19 at 3.24.11 PM.gif (1Γ—1 px, 3 MB)

Mon, Sep 19, 8:35 PM Β· MW-1.40-notes (1.40.0-wmf.2; 2022-09-19), MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration

Sat, Sep 10

vaughnwalters closed T311126: Implement strategy to account for DST variations as Resolved.

AC:
βœ… Change the code as needed to display the right information for the user

Yeah, this should be tested. In general, you should make sure that anything time-related still works correctly; behaviour should be the same as before. The following things come to mind (potentially incomplete list):

  • Enable/edit registration (time inputs)
    • Cannot enable registration with start date in the past
    • End date must be after start date
  • View event time on event page and Special:EventDetails
  • View start times on Special:MyEvents, make sure that sorting is correct
  • Cannot register for an event after it has finished
  • "Get details of an event" returns correct info

Note that since we're still using UTC everywhere, I don't expect any bug or surprising behaviour, so a quick round of testing should suffice. The same tests should be repeated, but much more thoroughly, when we will add the ability to specify the event timezone (T315691).

Sat, Sep 10, 1:18 AM Β· MW-1.40-notes (1.40.0-wmf.1; 2022-09-12), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters closed T311126: Implement strategy to account for DST variations, a subtask of T316133: [EPIC] Handle daylight saving for events, as Resolved.
Sat, Sep 10, 1:18 AM Β· Epic, Campaign-Registration, Campaign-Tools
vaughnwalters moved T311126: Implement strategy to account for DST variations from Code Review/Tech Input πŸ’¬ to QA πŸ› on the Campaign-Tools (Campaign-Tools-Sprint-20) board.
Sat, Sep 10, 12:58 AM Β· MW-1.40-notes (1.40.0-wmf.1; 2022-09-12), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration

Fri, Sep 9

vaughnwalters moved T311126: Implement strategy to account for DST variations from QA πŸ› to Code Review/Tech Input πŸ’¬ on the Campaign-Tools (Campaign-Tools-Sprint-20) board.

AC:
βœ… Create the new columns on campaign_events table:

  • event_start_local
  • event_start_utc
  • event_end_local
  • event_end_utc
  • event_timezone
Fri, Sep 9, 10:28 PM Β· MW-1.40-notes (1.40.0-wmf.1; 2022-09-12), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters moved T313326: Make usernames in EventDetails be clickable link to user page from QA πŸ› to Code Review/Tech Input πŸ’¬ on the Campaign-Tools (Campaign-Tools-Sprint-20) board.

βœ… Make usernames in EventDetails be clickable link to user page

Fri, Sep 9, 8:15 PM Β· MW-1.40-notes (1.40.0-wmf.1; 2022-09-12), Campaign-Tools (Campaign-Tools-Sprint-20), Patch-For-Review, CampaignEvents, Campaign-Registration
vaughnwalters closed T316409: Re-implement tracking tools schema as Resolved.

Betacluster tables have been ALTERed correctly according to SQL statements in the ticket description

Fri, Sep 9, 7:17 PM Β· MW-1.40-notes (1.40.0-wmf.1; 2022-09-12), Campaign-Tools (Campaign-Tools-Sprint-20), Campaign-Registration, CampaignEvents
vaughnwalters closed T316409: Re-implement tracking tools schema, a subtask of T302584: [EPIC] Integrate Event Center with Programs & Events Dashboard, as Resolved.
Fri, Sep 9, 7:17 PM Β· Epic, Campaign-Registration, Campaign-Tools
vaughnwalters closed T308738: Ensure that all tables have all the necessary indexes as Resolved.
Fri, Sep 9, 6:47 PM Β· MW-1.39-notes (1.39.0-wmf.28; 2022-09-05), Campaign-Tools (Campaign-Tools-Sprint-20), Data-Persistence (Consultation), Campaign-Registration, CampaignEvents
vaughnwalters moved T308738: Ensure that all tables have all the necessary indexes from QA πŸ› to Done 🏁 on the Campaign-Tools (Campaign-Tools-Sprint-20) board.

AC passes as index recommendations match what are currently in the tables on betacluster. One note though, campaign_events table also has the event_timezone_id index with columns event_timezone and event_id which are not mentioned in the index recommendations AC. @Daimona is this acceptable and correct? Wanted to check on this before marking this ticket as done.

Yes, I just added that index for T311126.

Fri, Sep 9, 6:47 PM Β· MW-1.39-notes (1.39.0-wmf.28; 2022-09-05), Campaign-Tools (Campaign-Tools-Sprint-20), Data-Persistence (Consultation), Campaign-Registration, CampaignEvents
vaughnwalters added a comment to T308738: Ensure that all tables have all the necessary indexes.

Index recommendations:

Fri, Sep 9, 6:29 PM Β· MW-1.39-notes (1.39.0-wmf.28; 2022-09-05), Campaign-Tools (Campaign-Tools-Sprint-20), Data-Persistence (Consultation), Campaign-Registration, CampaignEvents
vaughnwalters closed T312870: Add timestamps to ce_organizers table [V1] as Resolved.
Fri, Sep 9, 5:30 PM Β· MW-1.39-notes (1.39.0-wmf.28; 2022-09-05), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters moved T312870: Add timestamps to ce_organizers table [V1] from QA πŸ› to Done 🏁 on the Campaign-Tools (Campaign-Tools-Sprint-20) board.

SHOW INDEX FROM ce_organizers;

Screen Shot 2022-09-09 at 11.57.49 AM.png (392Γ—2 px, 334 KB)

Fri, Sep 9, 5:30 PM Β· MW-1.39-notes (1.39.0-wmf.28; 2022-09-05), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration

Thu, Sep 8

vaughnwalters added a comment to T316820: Add information for organizer on what participant information is collected .

@vaughnwalters do I move this back to in progress?

Thu, Sep 8, 2:02 PM Β· MW-1.40-notes (1.40.0-wmf.2; 2022-09-19), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration

Tue, Sep 6

vaughnwalters moved T316820: Add information for organizer on what participant information is collected from QA πŸ› to Design Sign-Off πŸ–ŒοΈ on the Campaign-Tools (Campaign-Tools-Sprint-20) board.
  • Add the following text: "Only usernames will be collected from participants during registration. Learn more."
  • The "Learn more" link should link to documentation for the tool on Mediawiki.org
Tue, Sep 6, 3:50 PM Β· MW-1.40-notes (1.40.0-wmf.2; 2022-09-19), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters added a comment to T316820: Add information for organizer on what participant information is collected .
Tue, Sep 6, 3:38 PM Β· MW-1.40-notes (1.40.0-wmf.2; 2022-09-19), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration

Fri, Sep 2

vaughnwalters added a comment to T312945: Display 'Registration Closed' button after registration closed.

@vaughnwalters What if the event is still open and registration ongoing what does the blocked unregistered user see?

Fri, Sep 2, 4:52 PM Β· Campaign-Registration, MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents
vaughnwalters created T316943: Request access to deployment-prep.
Fri, Sep 2, 3:45 PM Β· Beta-Cluster-Infrastructure, Release-Engineering-Team

Thu, Sep 1

vaughnwalters moved T313133: Unattached users are not handled correctly from QA πŸ› to Product sign-off 🀘 on the Campaign-Tools (Campaign-Tools-Sprint-20) board.
Thu, Sep 1, 8:54 PM Β· Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters moved T312910: Fix format of timestamps on the participants list on event details page from QA πŸ› to Product sign-off 🀘 on the Campaign-Tools (Campaign-Tools-Sprint-20) board.
  • The date and time shown on the participants list on event details page should be consistently formatted according to user preference. currently, only the first 20 have the correct format:
Thu, Sep 1, 8:53 PM Β· MW-1.39-notes (1.39.0-wmf.28; 2022-09-05), Campaign-Tools (Campaign-Tools-Sprint-20), Campaign-Registration, CampaignEvents
vaughnwalters added a comment to T312945: Display 'Registration Closed' button after registration closed.

@gonyeahialam
Event is closed and unregistered user is blocked locally through Special:Block

Screen Shot 2022-09-01 at 2.24.22 PM.png (1Γ—3 px, 297 KB)

Thu, Sep 1, 7:45 PM Β· Campaign-Registration, MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents
vaughnwalters moved T316875: First selenium test for Campaigns (EnableEventRegistration) from Backlog to In Progress on the User-vaughnwalters board.
Thu, Sep 1, 6:16 PM Β· User-zeljkofilipin, User-vaughnwalters, Campaign-Tools (Campaign-Tools-Sprint-20), Patch-For-Review, CampaignEvents
vaughnwalters added a project to T314080: Set up selenium / webdriver.io for regression test automation: User-vaughnwalters.
Thu, Sep 1, 6:14 PM Β· User-vaughnwalters, MW-1.39-notes (1.39.0-wmf.28; 2022-09-05), User-zeljkofilipin, Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents
vaughnwalters added projects to T316875: First selenium test for Campaigns (EnableEventRegistration): User-vaughnwalters, User-zeljkofilipin.
Thu, Sep 1, 6:13 PM Β· User-zeljkofilipin, User-vaughnwalters, Campaign-Tools (Campaign-Tools-Sprint-20), Patch-For-Review, CampaignEvents
vaughnwalters moved T316875: First selenium test for Campaigns (EnableEventRegistration) from Needs Input to QA πŸ› on the Campaign-Tools (Campaign-Tools-Sprint-20) board.
Thu, Sep 1, 4:57 PM Β· User-zeljkofilipin, User-vaughnwalters, Campaign-Tools (Campaign-Tools-Sprint-20), Patch-For-Review, CampaignEvents
vaughnwalters added a project to T316875: First selenium test for Campaigns (EnableEventRegistration): Campaign-Tools (Campaign-Tools-Sprint-20).
Thu, Sep 1, 4:57 PM Β· User-zeljkofilipin, User-vaughnwalters, Campaign-Tools (Campaign-Tools-Sprint-20), Patch-For-Review, CampaignEvents
vaughnwalters moved T316875: First selenium test for Campaigns (EnableEventRegistration) from Pre-deployment to Backlog on the CampaignEvents board.
Thu, Sep 1, 4:56 PM Β· User-zeljkofilipin, User-vaughnwalters, Campaign-Tools (Campaign-Tools-Sprint-20), Patch-For-Review, CampaignEvents
vaughnwalters moved T316875: First selenium test for Campaigns (EnableEventRegistration) from Backlog to Pre-deployment on the CampaignEvents board.
Thu, Sep 1, 4:52 PM Β· User-zeljkofilipin, User-vaughnwalters, Campaign-Tools (Campaign-Tools-Sprint-20), Patch-For-Review, CampaignEvents
vaughnwalters changed the status of T316875: First selenium test for Campaigns (EnableEventRegistration) from Open to In Progress.
Thu, Sep 1, 4:25 PM Β· User-zeljkofilipin, User-vaughnwalters, Campaign-Tools (Campaign-Tools-Sprint-20), Patch-For-Review, CampaignEvents
vaughnwalters created T316875: First selenium test for Campaigns (EnableEventRegistration).
Thu, Sep 1, 3:18 PM Β· User-zeljkofilipin, User-vaughnwalters, Campaign-Tools (Campaign-Tools-Sprint-20), Patch-For-Review, CampaignEvents
vaughnwalters closed T314080: Set up selenium / webdriver.io for regression test automation as Resolved.
Thu, Sep 1, 3:18 PM Β· User-vaughnwalters, MW-1.39-notes (1.39.0-wmf.28; 2022-09-05), User-zeljkofilipin, Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents
vaughnwalters committed rUCAMa82c36b94a97: selenium: Setup and first test (authored by vaughnwalters).
selenium: Setup and first test
Thu, Sep 1, 2:47 PM

Wed, Aug 31

vaughnwalters added a comment to T316693: Investigation: next steps for suppressed users and local blocks.

One more thing to think about here, if we do want to create ability to block/suppress a user locally on one wiki only: Because event IDs are global, if the user has the event ID, even if they are blocked on one wiki, they may still be able to go to Special:RegisterForEvent/{id} on a wiki that they are not blocked/suppressed on, and successfully register for the event. For example, right now users can register for events on wikis where they are not users. You can see an example on this ticket: T313133#8204360

Wed, Aug 31, 10:00 PM Β· CampaignEvents, Campaign-Tools, Campaign-Registration
vaughnwalters attached a referenced file: F35502431: Screen Shot 2022-08-31 at 4.27.06 PM.png.
Wed, Aug 31, 9:32 PM Β· Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters added a comment to T313133: Unattached users are not handled correctly.

Ah yes, @Daimona this is helpful.

Wed, Aug 31, 9:20 PM Β· Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters moved T311627: Add chat group links in event details pop-up from QA πŸ› to Design Sign-Off πŸ–ŒοΈ on the Campaign-Tools (Campaign-Tools-Sprint-20) board.

@Daimona this structure is slightly different.

Thanks for pointing this out. I mostly implemented what was in the prototype, so if that's different from what we have in Special:EventDetails, I'm guessing that the AC is wrong.

Wed, Aug 31, 8:18 PM Β· MW-1.39-notes (1.39.0-wmf.28; 2022-09-05), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters added a comment to T311627: Add chat group links in event details pop-up.
  • Display link to chat group to users (if they have registered as participants or if they are organizers) below 'Location' information in 'more details' pop-up

Participant:

Screen Shot 2022-08-31 at 11.25.32 AM.png (1Γ—1 px, 652 KB)

Organizer (same view as participant):
Screen Shot 2022-08-31 at 1.47.48 PM.png (1Γ—1 px, 646 KB)

Wed, Aug 31, 7:19 PM Β· MW-1.39-notes (1.39.0-wmf.28; 2022-09-05), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters attached a referenced file: F35501756: Screen Recording 2022-08-31 at 1.05.19 PM.mov-A3C55872-0FFE-4F67-8929-8C4167C01270.gif.
Wed, Aug 31, 6:32 PM Β· Campaign-Tools (Campaign-Tools-Sprint-20), Campaign-Registration, CampaignEvents
vaughnwalters added a comment to T316726: Can't close Registration popup on arabic wikipedia.

OK, I see, the bug only happens when using VE. I'll look into it.

Okay, you were able to reproduce it?

Yeah... I still don't know if this should be fixed on our side or in VE, though. At any rate, it's not just the responsiveness of the popup, it's also the double notification.

Wed, Aug 31, 6:15 PM Β· Campaign-Tools (Campaign-Tools-Sprint-20), Campaign-Registration, CampaignEvents
vaughnwalters updated the task description for T316726: Can't close Registration popup on arabic wikipedia.
Wed, Aug 31, 6:14 PM Β· Campaign-Tools (Campaign-Tools-Sprint-20), Campaign-Registration, CampaignEvents
vaughnwalters added a comment to T316726: Can't close Registration popup on arabic wikipedia.

OK, I see, the bug only happens when using VE. I'll look into it.

Wed, Aug 31, 6:12 PM Β· Campaign-Tools (Campaign-Tools-Sprint-20), Campaign-Registration, CampaignEvents
vaughnwalters added a comment to T316726: Can't close Registration popup on arabic wikipedia.

@Daimona Yes I am consistently getting that behavior. Create a new event, create registration and then that popup that appears is the one that I am talking about. see gif below from my test today.

Uhhh that's weird... Are you also getting it on the test page that I used? Does it still happen if you add the "safemode=1" parameter to the URL? Unfortunately, since I can't be of much help because I cannot reproduce it and you have no JS errors in the console. Maybe you could try taking a look at https://www.mediawiki.org/wiki/Manual:How_to_debug#Client_side_debugging_(JavaScript)?

Wed, Aug 31, 6:11 PM Β· Campaign-Tools (Campaign-Tools-Sprint-20), Campaign-Registration, CampaignEvents
vaughnwalters updated the task description for T316726: Can't close Registration popup on arabic wikipedia.
Wed, Aug 31, 5:59 PM Β· Campaign-Tools (Campaign-Tools-Sprint-20), Campaign-Registration, CampaignEvents
vaughnwalters added a comment to T316726: Can't close Registration popup on arabic wikipedia.

@Daimona Yes I am consistently getting that behavior. Create a new event, create registration and then that popup that appears is the one that I am talking about. see gif below from my test today.

Wed, Aug 31, 5:55 PM Β· Campaign-Tools (Campaign-Tools-Sprint-20), Campaign-Registration, CampaignEvents
vaughnwalters closed T313142: Improve performance of EventsPager::getEventPageFromRow as Resolved.
Wed, Aug 31, 4:06 PM Β· MW-1.39-notes (1.39.0-wmf.28; 2022-09-05), Campaign-Tools (Campaign-Tools-Sprint-20), Campaign-Registration, CampaignEvents
vaughnwalters moved T313142: Improve performance of EventsPager::getEventPageFromRow from QA πŸ› to Done 🏁 on the Campaign-Tools (Campaign-Tools-Sprint-20) board.
Wed, Aug 31, 4:06 PM Β· MW-1.39-notes (1.39.0-wmf.28; 2022-09-05), Campaign-Tools (Campaign-Tools-Sprint-20), Campaign-Registration, CampaignEvents
vaughnwalters added a comment to T313142: Improve performance of EventsPager::getEventPageFromRow.

Testing locally and am seeing this query in the debugging toolbar on Special:MyEvents. I believe this is correct but is this what you would be expecting to see @Daimona?

unknown: SELECT page_id,page_namespace,page_title,page_is_redirect,page_is_new,page_latest,page_touched,page_len,page_content_model,page_namespace,page_title FROM page WHERE (page_namespace = 1728 AND page_title IN (β€˜9’,β€˜35’,β€˜36’,β€˜37’,β€˜38’,β€˜39’,β€˜40’,β€˜41’,β€˜42’,β€˜43’,β€˜44’,β€˜45’,β€˜46’,β€˜47’,β€˜48’,β€˜49’,β€˜50’,β€˜51’,β€˜20’,β€˜25’,β€˜15’,β€˜22’,β€˜23’,β€˜24’,β€˜26’,β€˜30’,β€˜31’,β€˜57’,β€˜59’,β€˜V16’,β€˜V14’,β€˜52’,β€˜60’,β€˜55’,β€˜61’,β€˜71’,β€˜54’,β€˜63’,β€˜V18’,β€˜62’,β€˜TEST1’,β€˜21’,β€˜27’,β€˜56’,β€˜V20’,β€˜34’,β€˜V15’,β€˜14’,β€˜6’,β€˜7’,β€˜28’) )
Wed, Aug 31, 3:52 PM Β· MW-1.39-notes (1.39.0-wmf.28; 2022-09-05), Campaign-Tools (Campaign-Tools-Sprint-20), Campaign-Registration, CampaignEvents

Tue, Aug 30

vaughnwalters created T316726: Can't close Registration popup on arabic wikipedia.
Tue, Aug 30, 10:53 PM Β· Campaign-Tools (Campaign-Tools-Sprint-20), Campaign-Registration, CampaignEvents
vaughnwalters added a comment to T313133: Unattached users are not handled correctly.

πŸ‘ Using account on the left to check through Special:CentralAuth that user Vdubs82 does not exist in https://ar.wikipedia.beta.wmflabs.org/, but when logged out in the view on the right, the use is still correctly displaying for the event https://ar.wikipedia.beta.wmflabs.org/wiki/%D8%AE%D8%A7%D8%B5:EventDetails/120 which the user joined as a participant on https://en.wikipedia.beta.wmflabs.org/wiki/Special:EventDetails/120

Tue, Aug 30, 8:13 PM Β· Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters added a comment to T316294: Address Organized by: text in case of organizer being suppressed or deleted by Special:CentralAuth.

@Daimona @ifried What does it mean for a user to be suppressed? What actions lead to it and what are the consequences of being suppressed as a user on wiki and as an event organizer?

See https://www.mediawiki.org/wiki/Help:Blocking_users, search "Hide username from edits and lists"; and https://meta.wikimedia.org/wiki/Oversight_policy for Wikimedia-specific policies. I'm not sure if there are other, more specific help pages.

Tue, Aug 30, 3:45 PM Β· MW-1.40-notes (1.40.0-wmf.2; 2022-09-19), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters added a comment to T316227: Ability to specify organizer group via configuration.

Good question. Here are my thoughts:

Officewiki is only usable by WMF staff and therefore I think it's fine if everyone is considered an organizer. The process to be able to join officewiki at all is the vetting process, and we should allow any staff members to organize events internally.

I don't know very much about test2wiki, but I assume it is a test wiki that functions similar to the beta cluster? In that case, it may make sense to have the tool work similarly to how it works on the beta cluster and therefore be usable/testable by all registered users. Do folks think that makes sense?

Yes, I agree. Same with testwiki.

Tue, Aug 30, 2:14 PM Β· Campaign-Tools, CampaignEvents, Campaign-Registration
vaughnwalters added a comment to T308574: Implement search for participant list on EventDetails (JS experience).

And about the 'x' button not being keyboard tabbable, this seems to be the default behavior of the SearchInputWidget component on OOUI, so this should be a change on the OOUI, I was not able to find any task on phab about this bug/improvement, but I found this one which it is not the same thing but it is similar.

@cmelo I created T316599 to address the x in the input field not being tabbable.

Tue, Aug 30, 2:03 AM Β· MW-1.40-notes (1.40.0-wmf.2; 2022-09-19), MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters added a comment to T316599: OOUI element to clear input field not tabbable.

Thanks, @matmarex. Closing this ticket.

Tue, Aug 30, 2:00 AM Β· OOUI
vaughnwalters closed T316599: OOUI element to clear input field not tabbable as Invalid.
Tue, Aug 30, 1:59 AM Β· OOUI

Mon, Aug 29

vaughnwalters moved T308574: Implement search for participant list on EventDetails (JS experience) from QA πŸ› to Design Sign-Off πŸ–ŒοΈ on the Campaign-Tools (Campaign-Tools-Sprint-20) board.

Search is functioning correctly, including for users that have not yet been pulled in by the infinite scroll. πŸ‘

A couple of notes @cmelo

  1. the x button in the search bar is not keyboard tabbable, so it needs a tab index on to improve accessibility.
  2. The docs at https://www.mediawiki.org/wiki/Extension:CampaignEvents/Api#List_the_participants_of_an_event should should mention the new parameter for the username filter and related error

see the below gif for search functioning correctly (including searching for users outside of the initial 20 pulled in by the api), and also note the x not being tabbable

search user.mov-8862940E-718A-4C41-8352-6BC72E19139D.gif (955Γ—720 px, 1 MB)

Hi @vaughnwalters, thanks, I added the new parameter to the API doc.

Mon, Aug 29, 8:50 PM Β· MW-1.40-notes (1.40.0-wmf.2; 2022-09-19), MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters created T316599: OOUI element to clear input field not tabbable.
Mon, Aug 29, 8:48 PM Β· OOUI

Aug 26 2022

vaughnwalters moved T315185: Registration stops displaying in 'MyEvents' if all participants removed from QA πŸ› to Product sign-off 🀘 on the Campaign-Tools (Campaign-Tools-Sprint-20) board.
Aug 26 2022, 10:53 PM Β· MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Campaign-Tools (Campaign-Tools-Sprint-20), Campaign-Registration, CampaignEvents
vaughnwalters added a comment to T315185: Registration stops displaying in 'MyEvents' if all participants removed.

This is working correctly now, moving to product sign off

Aug 26 2022, 10:53 PM Β· MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Campaign-Tools (Campaign-Tools-Sprint-20), Campaign-Registration, CampaignEvents
vaughnwalters moved T312910: Fix format of timestamps on the participants list on event details page from QA πŸ› to Code Review/Tech Input πŸ’¬ on the Campaign-Tools (Campaign-Tools-Sprint-20) board.

this isn't in master yet so moving it back to review/feedback until it is merged

Aug 26 2022, 10:21 PM Β· MW-1.39-notes (1.39.0-wmf.28; 2022-09-05), Campaign-Tools (Campaign-Tools-Sprint-20), Campaign-Registration, CampaignEvents
vaughnwalters added a comment to T315493: UX Improvements: EventDetails for mobile web.

One thing I forgot saying about:

Clicking on View event page should take you to the mobile event page (not desktop)

This will possibly only work when the event page is on the same wiki. There's no way to get a URL to the mobile version of another wiki. I'm not sure if we also use cookies or sth like that to remember whether to open the mobile version, so it may still work, but it's not guaranteed.

Aug 26 2022, 8:24 PM Β· MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters added a comment to T308576: Implement infinite scrolling on participant list in EventDetails.

@gonyeahialam here's a good visual I just came across where a loading state would be useful - same event but on my phone when i load it through arabic wikipedia on betacluster.
https://ar.wikipedia.beta.wmflabs.org/wiki/Special:EventDetails/118

Aug 26 2022, 8:06 PM Β· MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters moved T315493: UX Improvements: EventDetails for mobile web from QA πŸ› to Design Sign-Off πŸ–ŒοΈ on the Campaign-Tools (Campaign-Tools-Sprint-20) board.

βœ… Event details page content should be responsive and fit the mobile screen size.

Screenshot 2022-08-26 at 1.34.22 PM.png (1Γ—750 px, 127 KB)

IMG_2375.gif (480Γ—272 px, 1 MB)

Aug 26 2022, 8:01 PM Β· MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters moved T315544: UX Improvements: More details dialog for mobile web from QA πŸ› to Design Sign-Off πŸ–ŒοΈ on the Campaign-Tools (Campaign-Tools-Sprint-20) board.

βœ… The modal should have a single column (it currently does, except for between 591px-699px, see explanation below)
βœ…The content should be arranged in the following order: Title, organizers, Date and time, location and participants.
βœ… In-person and Online events headings look like normal text. It should look like the header text as on desktop.
βœ…The meeting URL should have the link icon before it.

Screenshot 2022-08-26 at 1.11.23 PM.png (1Γ—750 px, 117 KB)

Aug 26 2022, 6:21 PM Β· MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters moved T315496: UX Improvements: Enable registration form from QA πŸ› to Design Sign-Off πŸ–ŒοΈ on the Campaign-Tools (Campaign-Tools-Sprint-20) board.
Aug 26 2022, 4:41 PM Β· MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents
vaughnwalters added a comment to T315496: UX Improvements: Enable registration form.

βœ… Display the location radio buttons in a vertical order on 1 line (as shown in the 2nd image)

Aug 26 2022, 4:41 PM Β· MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents
vaughnwalters moved T315495: UX Improvements: Event page without registration from QA πŸ› to Design Sign-Off πŸ–ŒοΈ on the Campaign-Tools (Campaign-Tools-Sprint-20) board.

βœ… Enable registration widget text and calendar icon should be aligned at the top, not center
βœ… Enable Registration button should fill up the widget

Aug 26 2022, 4:06 PM Β· MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration

Aug 25 2022

vaughnwalters moved T312772: Properly handle suppressed users from QA πŸ› to Product sign-off 🀘 on the Campaign-Tools (Campaign-Tools-Sprint-20) board.

@Daimona should we address the Organized by: and then no user displaying in this ticket, or should that be a separate ticket? There is already a ton going on in this ticket.

I believe it should be a separate task, because we may need input from Gregory and Ilana.

Aug 25 2022, 9:36 PM Β· MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Patch-For-Review, Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters created T316294: Address Organized by: text in case of organizer being suppressed or deleted by Special:CentralAuth.
Aug 25 2022, 9:32 PM Β· MW-1.40-notes (1.40.0-wmf.2; 2022-09-19), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters moved T312772: Properly handle suppressed users from Product sign-off 🀘 to QA πŸ› on the Campaign-Tools (Campaign-Tools-Sprint-20) board.
Aug 25 2022, 9:13 PM Β· MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Patch-For-Review, Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters added a comment to T312772: Properly handle suppressed users.

@Daimona should we address the Organized by: and then no user displaying in this ticket, or should that be a separate ticket? There is already a ton going on in this ticket.

Aug 25 2022, 9:12 PM Β· MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Patch-For-Review, Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters moved T312772: Properly handle suppressed users from QA πŸ› to Product sign-off 🀘 on the Campaign-Tools (Campaign-Tools-Sprint-20) board.

in the API for the endpoint to check participants for the event, https://en.wikipedia.beta.wmflabs.org/w/rest.php/campaignevents/v0/event_registration/10/participants, a 500 error is thrown:

I'll fix this.

Aug 25 2022, 8:47 PM Β· MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Patch-For-Review, Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters moved T315492: UX improvements: MyEvents for mobile web from QA πŸ› to Design Sign-Off πŸ–ŒοΈ on the Campaign-Tools (Campaign-Tools-Sprint-20) board.
Aug 25 2022, 6:48 PM Β· MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters added a comment to T315492: UX improvements: MyEvents for mobile web.

ar betacluster:

ar.MP4-E39507C9-A2AE-4CE4-A84D-91E96A02234A.gif (1Γ—720 px, 1 MB)

Aug 25 2022, 6:48 PM Β· MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters moved T316153: Empty state is shown above list of participants on EventDetails from QA πŸ› to Product sign-off 🀘 on the Campaign-Tools (Campaign-Tools-Sprint-20) board.
Aug 25 2022, 6:16 PM Β· MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Campaign-Registration, CampaignEvents, Campaign-Tools (Campaign-Tools-Sprint-20)
vaughnwalters added a comment to T316153: Empty state is shown above list of participants on EventDetails.

bug is fixed πŸ‘

Aug 25 2022, 6:16 PM Β· MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Campaign-Registration, CampaignEvents, Campaign-Tools (Campaign-Tools-Sprint-20)
vaughnwalters added a comment to T308576: Implement infinite scrolling on participant list in EventDetails.

Seems to be working well. I will be moving this to product sign-off.

It would be good to have some sort of a spinner or progress bar at the bottom of the scroll that displays while more participants are actively being loaded in, to show the user that more participants are being loaded into the list. @gonyeahialam do you have thoughts on this?

@vaughnwalters wrt the above, I can create a separate task for it. I would like a visual of how it currently looks when it's loading more users, I didn't notice any loading time/delay from my end, it seemed instantaneous.

Aug 25 2022, 6:09 PM Β· MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters added a comment to T314080: Set up selenium / webdriver.io for regression test automation.

@zeljkofilipin here's the docker setup for this extension https://gitlab.wikimedia.org/mhurd/mediawiki-campaignevents-docker

Aug 25 2022, 4:38 PM Β· User-vaughnwalters, MW-1.39-notes (1.39.0-wmf.28; 2022-09-05), User-zeljkofilipin, Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents
vaughnwalters updated subscribers of T314080: Set up selenium / webdriver.io for regression test automation.
Aug 25 2022, 2:10 PM Β· User-vaughnwalters, MW-1.39-notes (1.39.0-wmf.28; 2022-09-05), User-zeljkofilipin, Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents
vaughnwalters moved T308576: Implement infinite scrolling on participant list in EventDetails from Code Review/Tech Input πŸ’¬ to Design Sign-Off πŸ–ŒοΈ on the Campaign-Tools (Campaign-Tools-Sprint-20) board.

One bug though @cmelo see that the Usernames of participants will appear here when they register text and the graphic are still showing even after multiple users have registered. This exists on local as well

Yup, I've seen that and pushed a fix already: T316153.

Great πŸ‘

Aug 25 2022, 12:04 AM Β· MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration

Aug 24 2022

vaughnwalters moved T308576: Implement infinite scrolling on participant list in EventDetails from QA πŸ› to Code Review/Tech Input πŸ’¬ on the Campaign-Tools (Campaign-Tools-Sprint-20) board.
Aug 24 2022, 10:09 PM Β· MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters added a comment to T308576: Implement infinite scrolling on participant list in EventDetails.

Infinite scroll is functioning correctly as seen in gif and network tab.

Aug 24 2022, 10:06 PM Β· MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters moved T312945: Display 'Registration Closed' button after registration closed from QA πŸ› to Design Sign-Off πŸ–ŒοΈ on the Campaign-Tools (Campaign-Tools-Sprint-20) board.
Aug 24 2022, 9:12 PM Β· Campaign-Registration, MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents
vaughnwalters moved T311632: Fix display in registration header on event page from QA πŸ› to Design Sign-Off πŸ–ŒοΈ on the Campaign-Tools (Campaign-Tools-Sprint-20) board.
Aug 24 2022, 7:28 PM Β· MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration
vaughnwalters added a comment to T312945: Display 'Registration Closed' button after registration closed.

Event Ended:

Screen Shot 2022-08-23 at 2.04.35 PM.png (1Γ—2 px, 187 KB)

Aug 24 2022, 5:41 AM Β· Campaign-Registration, MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents

Aug 23 2022

vaughnwalters added a comment to T315544: UX Improvements: More details dialog for mobile web.

@Daimona for this AC:

Aug 23 2022, 4:25 PM Β· MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration

Aug 22 2022

vaughnwalters added a comment to T311632: Fix display in registration header on event page.

Including screen shots from various breakpoints.
βœ… Fix alignment of icons in header
βœ… Fix how text is displayed so it doesn't wrap but displays one item per line if reduced
βœ… Note: "Event" should not be capitalized, as it is in the wireframes

Aug 22 2022, 11:57 PM Β· MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), Campaign-Tools (Campaign-Tools-Sprint-20), CampaignEvents, Campaign-Registration