Page MenuHomePhabricator
Create Task
Maniphest T361249

Confirmation dialog with long titles with no spaces should wrap
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

WHEN I visit this page or any event with a long title with no spaces in it
AND register or the the event
THEN the confirmation dialog is overflowing and should instead wrap

Acceptance criteria:
Event name should wrap in confirmation dialog

Software version (skip for WMF-hosted wikis like Wikipedia):
betacluster, 1.42.0-wmf.24

Other information (browser name/version, screenshots, etc.):
Chrome

Screenshot 2024-03-27 at 4.11.20 PM.png (284×716 px, 33 KB)

Note that an event with the same title but with spaces in it will wrap correctly in both instances

Details

SubjectRepoBranchLines +/-
Fix Confirmation dialogs with long titlesmediawiki/extensions/CampaignEventsmaster+4 -0
Customize query in gerrit

Event Timeline

ifried created this task.Mar 28 2024, 3:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 28 2024, 3:43 PM
ifried added a project: Campaign-Registration.Mar 28 2024, 3:52 PM
ifried moved this task from Needs Input / Design in progress to Ready for development on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.
cmelo changed the task status from Open to In Progress.Fri, Apr 12, 9:17 AM
cmelo claimed this task.
cmelo moved this task from Ready for development to In Progress 💻 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.
gerritbot added a comment.Fri, Apr 12, 9:18 AM

Change #1019245 had a related patch set uploaded (by Cmelo; author: Cmelo):

[mediawiki/extensions/CampaignEvents@master] Fix Confirmation dialogs with long titles

https://gerrit.wikimedia.org/r/1019245

gerritbot added a project: Patch-For-Review.Fri, Apr 12, 9:18 AM
cmelo moved this task from In Progress 💻 to Code Review on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Fri, Apr 12, 10:14 AM
gerritbot added a comment.Tue, Apr 23, 2:17 PM

Change #1019245 abandoned by Cmelo:

[mediawiki/extensions/CampaignEvents@master] Fix Confirmation dialogs with long titles

Reason:

this will be done on core

https://gerrit.wikimedia.org/r/1019245

cmelo moved this task from Code Review to QA 🐛 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Tue, Apr 23, 6:14 PM
cmelo removed a project: Patch-For-Review.
vaughnwalters closed this task as Resolved.Wed, Apr 24, 2:36 AM
vaughnwalters moved this task from QA 🐛 to Done 🏁 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.
vaughnwalters subscribed.

✅ Event name should wrap in confirmation dialog

Screenshot 2024-04-23 at 9.31.34 PM.png (1×1 px, 354 KB)

This is working correctly now. Marking as done / resolved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL