Set organizers endpoint: Check if the event belongs to the current wiki
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Daimona
	Mar 6 2024, 11:05 PM

Description

Acceptance criteria

Given a user tries to change the organizers using the "Update the list of organizers" API endpoint
- And the event does not belong to the current wiki
- Then they should receive a 4xx response with an error message similar to that used in T358781
- And this new error should be documented on mediawiki.org

Details

	Subject	Repo	Branch	Lines +/-
	SetOrganizersHandler: fail if the event is not local	mediawiki/extensions/CampaignEvents	master	+61 -4

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		ifried	T323228 [EPIC] Support global implementation for CampaignEvents extension
		Resolved		MHorsey-WMF	T359493 Set organizers endpoint: Check if the event belongs to the current wiki

Event Timeline

Daimona created this task.Mar 6 2024, 11:05 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 6 2024, 11:05 PM

Daimona added a parent task: T323228: [EPIC] Support global implementation for CampaignEvents extension.Mar 6 2024, 11:06 PM

Daimona moved this task from Upcoming / refining 💡 to Ready for development on the Campaigns-Product-Team (Campaign-Tools-Current-Sprint) board.Mar 6 2024, 11:12 PM

ifried set the point value for this task to 2.Mar 7 2024, 3:19 PM

MHorsey-WMF changed the task status from Open to In Progress.Mar 18 2024, 11:54 AM

MHorsey-WMF moved this task from Ready for development to Development In Progress 💻 on the Campaigns-Product-Team (Campaign-Tools-Current-Sprint) board.

MHorsey-WMF claimed this task.Mar 18 2024, 11:57 AM

MHorsey-WMF moved this task from Development In Progress 💻 to Code Review 💬 on the Campaigns-Product-Team (Campaign-Tools-Current-Sprint) board.Mar 18 2024, 4:00 PM

Blocked on T312568.

Moved to in review after team discussion on how we will unblock this work, which is: Remove open/close in all cases (whether on the local or foreign wiki) from the kebab menu, and redirect users to special delete page if on a foreign wiki

Daimona changed the task status from Stalled to Open.Apr 4 2024, 2:31 PM

Change #1012400 had a related patch set uploaded (by Cmelo; author: Mhorsey):

[mediawiki/extensions/CampaignEvents@master] SetOrganizersHandler: fail if the event is not local

https://gerrit.wikimedia.org/r/1012400

gerritbot added a project: Patch-For-Review.Apr 9 2024, 3:45 AM

Change #1012400 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] SetOrganizersHandler: fail if the event is not local

https://gerrit.wikimedia.org/r/1012400

cmelo moved this task from Code Review 💬 to QA 🐛 on the Campaigns-Product-Team (Campaign-Tools-Current-Sprint) board.Apr 10 2024, 1:50 PM

cmelo removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.1; 2024-04-16).Apr 10 2024, 2:00 PM

Given a user tries to change the organizers using the "Update the list of organizers" API endpoint
And the event does not belong to the current wiki
✅ Then they should receive a 4xx response with an error message similar to that used in T358781

❌ And this new error should be documented on mediawiki.org
@MHorsey-WMF Please set organizers on XXX, the wiki where the event was created. needs added to Update the list of organizers endpoint on mediawiki.org

vaughnwalters moved this task from QA 🐛 to Code Review 💬 on the Campaigns-Product-Team (Campaign-Tools-Current-Sprint) board.Apr 10 2024, 9:31 PM

MHorsey-WMF moved this task from Code Review 💬 to QA 🐛 on the Campaigns-Product-Team (Campaign-Tools-Current-Sprint) board.Apr 11 2024, 9:28 AM

In T359493#9705384, @vaughnwalters wrote:

Given a user tries to change the organizers using the "Update the list of organizers" API endpoint
And the event does not belong to the current wiki
✅ Then they should receive a 4xx response with an error message similar to that used in T358781

❌ And this new error should be documented on mediawiki.org
@MHorsey-WMF Please set organizers on XXX, the wiki where the event was created. needs added to Update the list of organizers endpoint on mediawiki.org

✅ Error message is now documented on mediawiki.org

Sending to product sign off

The global implementation work is complete and we have released to another wiki (Igbo Wikipedia), so I'm marking this work as Done.

	F45698721: T359493.png
	Apr 10 2024, 9:03 PM

Set organizers endpoint: Check if the event belongs to the current wikiClosed, ResolvedPublic2 Estimated Story PointsActions