Page MenuHomePhabricator
Create Task
Maniphest T341689

"Message Participants" buttons should not appear on Special:EventDetails if feature flag is disabled
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • set $wgCampaignEventsEnableEmail = false in local settings
  • Log in as an event organiser
  • Navigate to one of your events

What happens?: "Message Participants" button appears but does not work.

What should have happened instead?: "Message Participants" button should not appear

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Other Assignee
MHorsey-WMF
SubjectRepoBranchLines +/-
Hide "message participant button" when email is not enabledmediawiki/extensions/CampaignEventsmaster+34 -11
Customize query in gerrit

Event Timeline

MHorsey-WMF created this task.Jul 12 2023, 12:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 12 2023, 12:58 PM
MHorsey-WMF updated the task description. (Show Details)Jul 12 2023, 12:59 PM
MHorsey-WMF changed the task status from Open to In Progress.Jul 13 2023, 11:32 AM
MHorsey-WMF moved this task from Needs Input / Design in progress to In Progress 💻 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.
MHorsey-WMF updated Other Assignee, added: MHorsey-WMF.
gerritbot added a comment.Jul 13 2023, 11:35 AM

Change 937935 had a related patch set uploaded (by Mhorsey; author: Mhorsey):

[mediawiki/extensions/CampaignEvents@master] Hide "message participant button" when email is not enabled

https://gerrit.wikimedia.org/r/937935

gerritbot added a project: Patch-For-Review.Jul 13 2023, 11:35 AM
MHorsey-WMF moved this task from In Progress 💻 to Code Review on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Jul 13 2023, 11:41 AM
Daimona assigned this task to MHorsey-WMF.Jul 14 2023, 8:26 PM
Daimona moved this task from Code Review to QA 🐛 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Jul 17 2023, 2:16 PM
Daimona edited projects, added Campaign-Registration; removed Patch-For-Review.
gerritbot added a comment.Jul 17 2023, 2:36 PM

Change 937935 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Hide "message participant button" when email is not enabled

https://gerrit.wikimedia.org/r/937935

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.18; 2023-07-18).Jul 17 2023, 3:00 PM
vaughnwalters closed this task as Resolved.Jul 18 2023, 3:40 PM
vaughnwalters moved this task from QA 🐛 to Done 🏁 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.
vaughnwalters subscribed.

✅ "Message Participants" button should not appear.

Screenshot 2023-07-18 at 10.39.18 AM.png (1×1 px, 172 KB)

Marking as done / resolved

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL