Page MenuHomePhabricator

LanguageConverterFactory::getLanguageConverter() should not require a Language object
Open, Needs TriagePublic

Description

The only two use cases of the obtained Language object are for Language::getNsText( NS_MEDIAWIKI ) and Language::ucfirst()

For the first one, this functionality should go to NamespaceInfo and use dependency injection.

For the ucfirst, it's guarded in a feature flag $this->mUcfirst defaults to false, and no subclasses use this feature. I suggest we can remove this.

		if ( $this->mUcfirst ) {
			foreach ( $ret as $k => $v ) {
				$ret[$this->mLangObj->ucfirst( $k )] = $this->mLangObj->ucfirst( $v );
			}
		}

Event Timeline

Change 940480 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] language: Remove unused LanguageConverter::$mUcfirst

https://gerrit.wikimedia.org/r/940480

Change 940480 merged by jenkins-bot:

[mediawiki/core@master] language: Remove unused LanguageConverter::$mUcfirst

https://gerrit.wikimedia.org/r/940480