Page MenuHomePhabricator

Maintenance tag module is missing many redirect tags
Closed, ResolvedPublicBUG REPORT

Description

Reported by @Illusion_Flame on Discord

Steps to replicate the issue (include links if applicable):

  • Find an unpatrolled redirect. Visit the page.
  • Make sure Page Curation toolbar pops up
  • Open maintenance tags menu
  • Click "Redirect tags" submenu

What happens?:

  • 2 redirect tags are shown

image.png (840×1 px, 123 KB)

What should have happened instead?:

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Change 938294 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/PageTriage@master] Fix missing external tags

https://gerrit.wikimedia.org/r/938294

It looks like I introduced this with my hasty followup to that patch:
rEPTRdb754209fc733c4be507e02213d90078c5f5576d

My code fixed the import error, but also eliminated some mutation that the external tags depend upon.

I've now copied:
https://en.wikipedia.org/wiki/MediaWiki:PageTriageExternalTagsOptions.js#L-1268
to my local:
http://localhost:8080/wiki/MediaWiki:PageTriageExternalTagsOptions.js

and verified that my patch broke the external loading, and that this new patch resolves it.

Change 938294 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Fix missing external tags

https://gerrit.wikimedia.org/r/938294

MPGuy2824 moved this task from Waiting for enwiki deploy to Done on the PageTriage board.