Page MenuHomePhabricator

Replace $.client.test() user-agent sniffing with feature detection in WikiEditor
Closed, InvalidPublic

Description

User-agent sniffing tends to break on future browser versions or browsers you don't know about; should use feature detection instead.

Agent sniffing can be sometimes appropriate to blacklist particular things we know are bad, but should be much more limited and explicit.


Version: unspecified
Severity: normal

Details

Reference
bz32185
TitleReferenceAuthorSource BranchDest Branch
Include docroot/noc in the image we buildrepos/releng/release!38oblivianadd_noc_to_imagesmain
Customize query in GitLab

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 21 2014, 11:59 PM
bzimport added a project: WikiEditor.
bzimport set Reference to bz32185.
bzimport added a subscriber: Unknown Object (MLST).

(This seems to be mostly used in checking whether we need to save/restore the
scroll & selection state. Since an IE-specific interface is being used there,
it may make more sense to base the check on that.)

This is being used for a variety of things, which can not be feature detected, including CSS layout issues.

Yes, feature detection is superior, but it's not always possible.