Following standard OOUI behaviour popups should close when the keyboard focus is moving to the next element. Currently this is not happening when a revision is selected in revision slider (see screenshot). We will test this with both mouse as well as pure keyboard navigation.
Requirements
- the popup opens on focus (same as before) - https://gerrit.wikimedia.org/r/c/952460
- the popup closes when you tab out of it - https://gerrit.wikimedia.org/r/c/952882
- reverse tabbing is also closing the popup - https://gerrit.wikimedia.org/r/952119
- clicking enter closes the popup - https://gerrit.wikimedia.org/r/c/952859
Findings
The popup is bound to the yellow and blue buttons. Since these have many extra interactions (like dragging and hover), the popup is not a PopupButtonWidget but onyl a PopupWidget. Some of the interactions that are standard in OOUI for the button widget are written / need to be written extra for the buttons here.