Page MenuHomePhabricator

code_aliases required: yue.wikipedia.org is redirected to zh-yue.wikipedia.org
Closed, ResolvedPublic

Description

A code_aliases is required for wikipedia_family: yue.wikipedia.org is redirected to zh-yue.wikipedia.org.

Unfortunately WikimediaFamily class has defined code_aliases already and the wikipedia_family.Family is immutable. There should be a way to modify such class attributes during allocation (or initializing which is marked as deprecated).

Event Timeline

Xqt triaged this task as Low priority.Jul 17 2023, 5:44 AM
Meno25 renamed this task from code_aliases required: yue.wikipedua.org is redirected to zh-wikipedia.org to code_aliases required: yue.wikipedia.org is redirected to zh-yue.wikipedia.org.Jul 17 2023, 7:38 AM
Meno25 updated the task description. (Show Details)

Change 938812 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [bugfix] Add 'yue' code_aliases to wikipedia_family.py

https://gerrit.wikimedia.org/r/938812

We have an inverse situation with wiktionary I guess:

12:32:26 ======================================================================
12:32:26 FAIL: test_each_family (tests.family_tests.TestFamilyUrlRegex) (url='https://zh-yue.wiktionary.org/w/index.php/$1')
12:32:26 Test each family builds a working regex.
12:32:26 ----------------------------------------------------------------------
12:32:26 Traceback (most recent call last):
12:32:26   File "/src/tests/family_tests.py", line 232, in test_each_family
12:32:26     self.assertEqual(family.from_url(url), code)
12:32:26 AssertionError: 'zh-yue' != 'yue'
12:32:26 - zh-yue
12:32:26 + yue

Change 938812 merged by jenkins-bot:

[pywikibot/core@master] [bugfix] Add 'yue' code_aliases to wikipedia_family.py

https://gerrit.wikimedia.org/r/938812