Page MenuHomePhabricator
Create Task
Maniphest T342001

Update default license message in Item, Property, Lexeme and EntitySchema creation and edit summaries
Closed, ResolvedPublic
Actions

Description

Update the default license message in the creation summaries for Wikibase items, properties, lexemes and entityschema.

Acceptance Criteria:

  • Remove ", and you irrevocably agree to release your contribution under the [ None yet set.]." and add a . after "terms of use".

Screenshot from 2022-07-07 09-37-10.png (896×1 px, 140 KB)

It looks like Wikidata does not override:

Approach:

Details

SubjectRepoBranchLines +/-
Show a shorter copyright message when dataRightsUrl is emptymediawiki/extensions/WikibaseREL1_39+10 -0
Show a shorter copyright message when dataRightsUrl is emptymediawiki/extensions/Wikibasemaster+19 -0
Add an optional reduced copyright messagemediawiki/extensions/Wikibasemaster+33 -1
Reuse Wikibase's copyright message buildermediawiki/extensions/EntitySchemaREL1_39+19 -12
Reuse Wikibase's copyright message buildermediawiki/extensions/EntitySchemamaster+18 -13
Customize query in gerrit

Related Objects

Event Timeline

Andrew-WMDE created this task.Jul 17 2023, 2:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 17 2023, 2:20 PM
Andrew-WMDE mentioned this in T312512: [8hrs] Investigate how to add default links in creation pages.Jul 18 2023, 8:53 AM
Andrew-WMDE claimed this task.Jul 18 2023, 10:55 AM
Andrew-WMDE moved this task from To do to Doing on the Wikibase Cloud (Kanban board Q3 2023) board.
Tarrow subscribed.Jul 18 2023, 4:45 PM

I stared at the investigation ticket a bit after looking at the breakdown and realised that we actually added in quite a different A/C change after the investigation moved into ready to pick up. T312512#8841047 added the changes to the license conditions in a ticket that was originally only about links to Wikidata.

I'm afraid I therefore didn't flag up that this half of the work might actually have some more moving parts if the desired outcome is improving the clarity of the license conditions for users of the wikis.

I wonder if we need to think a little more about this since this isn't the only place the license conditions are shown. There are other places that the CopyrightMessage builder is used and I wonder if we want to also look at them.

For example this should appear in the popup

image.png (395×395 px, 24 KB)

There is also action we might need to take in the RDF output e.g. see the cc triple here: https://coffeebase.wikibase.cloud/wiki/Special:EntityData/Q1.ttl

Perhaps these should also be undertaken in another ticket though.

Evelien_WMDE mentioned this in T342336: Remove license reference in statement edit pop-up.Jul 20 2023, 11:29 AM
gerritbot added a comment.Jul 21 2023, 10:57 AM

Change 940159 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/EntitySchema@master] Reuse Wikibase's copyright message builder

https://gerrit.wikimedia.org/r/940159

gerritbot added a project: Patch-For-Review.Jul 21 2023, 10:57 AM
gerritbot added a comment.Jul 24 2023, 1:49 PM

Change 940946 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/Wikibase@master] Add an optional reduced copyright message

https://gerrit.wikimedia.org/r/940946

Andrew-WMDE removed Andrew-WMDE as the assignee of this task.Jul 24 2023, 2:24 PM
Andrew-WMDE moved this task from Doing to In Review on the Wikibase Cloud (Kanban board Q3 2023) board.
Tarrow renamed this task from Update default license message in item, property, and lexeme creation summaries to Update default license message in Item, Property, Lexeme and EntitySchema creation summaries.Jul 26 2023, 9:03 AM
Tarrow updated the task description. (Show Details)
gerritbot added a comment.Jul 27 2023, 9:49 AM

Change 942378 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/Wikibase@master] Show a shorter copyright message when dataRightsUrl is empty

https://gerrit.wikimedia.org/r/942378

Tarrow renamed this task from Update default license message in Item, Property, Lexeme and EntitySchema creation summaries to Update default license message in Item, Property, Lexeme and EntitySchema creation and edit summaries.Jul 27 2023, 1:13 PM
Tarrow merged a task: T342336: Remove license reference in statement edit pop-up.
Tarrow added a subscriber: Evelien_WMDE.
gerritbot added a comment.Jul 27 2023, 2:23 PM

Change 940159 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Reuse Wikibase's copyright message builder

https://gerrit.wikimedia.org/r/940159

Andrew-WMDE claimed this task.Jul 27 2023, 2:33 PM
Andrew-WMDE updated the task description. (Show Details)
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Jul 27 2023, 3:00 PM
gerritbot added a comment.Jul 27 2023, 3:03 PM

Change 942447 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/EntitySchema@REL1_39] Reuse Wikibase's copyright message builder

https://gerrit.wikimedia.org/r/942447

Andrew-WMDE updated the task description. (Show Details)Jul 27 2023, 3:28 PM
gerritbot added a comment.Jul 31 2023, 10:17 AM

Change 940946 abandoned by Andrew-WMDE:

[mediawiki/extensions/Wikibase@master] Add an optional reduced copyright message

Reason:

Abandoned in favor of I07b30f5704729437c5915ea7dab7364fe822884b

https://gerrit.wikimedia.org/r/940946

gerritbot added a comment.Jul 31 2023, 10:45 AM

Change 942378 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Show a shorter copyright message when dataRightsUrl is empty

https://gerrit.wikimedia.org/r/942378

Andrew-WMDE updated the task description. (Show Details)Jul 31 2023, 10:51 AM
gerritbot added a comment.Jul 31 2023, 11:07 AM

Change 943530 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/Wikibase@REL1_39] Show a shorter copyright message when dataRightsUrl is empty

https://gerrit.wikimedia.org/r/943530

Andrew-WMDE updated the task description. (Show Details)Jul 31 2023, 11:37 AM
Andrew-WMDE removed Andrew-WMDE as the assignee of this task.Jul 31 2023, 1:55 PM
Andrew-WMDE updated the task description. (Show Details)
Andrew-WMDE moved this task from In Review to Waiting for Deploy to Staging on the Wikibase Cloud (Kanban board Q3 2023) board.
Andrew-WMDE moved this task from Waiting for Deploy to Staging to Waiting for Deploy to Production on the Wikibase Cloud (Kanban board Q3 2023) board.Aug 2 2023, 8:04 AM
Andrew-WMDE updated the task description. (Show Details)Aug 2 2023, 8:17 AM
Andrew-WMDE moved this task from Waiting for Deploy to Production to Done on the Wikibase Cloud (Kanban board Q3 2023) board.
Evelien_WMDE closed this task as Resolved.Aug 14 2023, 7:36 AM
Evelien_WMDE claimed this task.
Michael mentioned this in T214578: Make license for Schemas configurable.Sep 15 2023, 12:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL