Page MenuHomePhabricator
Create Task
Maniphest T342292

Participants table should not scroll on page
Closed, ResolvedPublicBUG REPORT
Actions

Description

Once all of the participants on the participants table have been scrolled through, the entire table scrolls as well. It should be anchored in place on the page.

Screen Recording 2023-07-19 at 1.13.23 PM.gif (1×2 px, 1 MB)

AC: Participants table does not scroll on the page.

Details

SubjectRepoBranchLines +/-
EventDetails: prevent invisible labels from overflowing the tablemediawiki/extensions/CampaignEventsmaster+7 -0
Customize query in gerrit

Related Objects

Event Timeline

vaughnwalters created this task.Jul 19 2023, 6:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 19 2023, 6:59 PM
Daimona subscribed.Jul 19 2023, 7:14 PM

I was a bit puzzled by this because I made sure to test the new table layout thoroughly. But git bisect revealed that this was actually caused by r938900 for T336311. I think it might be caused by the FieldLayout's that were added, but I'll look deeper into this.

Daimona claimed this task.Jul 19 2023, 7:15 PM
Daimona edited projects, added Campaigns-Product-Team (Campaign-Tools-Current-Sprint); removed Campaigns-Product-Team.
Daimona moved this task from Upcoming / refining 💡 to Development In Progress 💻 on the Campaigns-Product-Team (Campaign-Tools-Current-Sprint) board.
gerritbot added a comment.Jul 19 2023, 8:34 PM

Change 939765 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] EventDetails: prevent invisible labels from overflowing the table

https://gerrit.wikimedia.org/r/939765

gerritbot added a project: Patch-For-Review.Jul 19 2023, 8:34 PM
Daimona moved this task from Development In Progress 💻 to Code Review 💬 on the Campaigns-Product-Team (Campaign-Tools-Current-Sprint) board.Jul 19 2023, 8:35 PM
gerritbot added a comment.Jul 24 2023, 2:01 PM

Change 939765 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] EventDetails: prevent invisible labels from overflowing the table

https://gerrit.wikimedia.org/r/939765

Daimona moved this task from Code Review 💬 to QA 🐛 on the Campaigns-Product-Team (Campaign-Tools-Current-Sprint) board.Jul 24 2023, 2:04 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 24 2023, 2:10 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.19; 2023-07-25).Jul 24 2023, 3:00 PM
vaughnwalters closed this task as Resolved.Jul 24 2023, 5:59 PM
vaughnwalters moved this task from QA 🐛 to Done 🏁 on the Campaigns-Product-Team (Campaign-Tools-Current-Sprint) board.

✅ Participants table does not scroll on the page.

Screen Recording 2023-07-24 at 12.55.41 PM.gif (1×1 px, 3 MB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits