Page MenuHomePhabricator

Dependency inversion issue of Database
Open, Needs TriagePublic

Description

Database (and to some extent, LB/LBF) are being depended on by a large portion of our code base, so it shouldn't have that many dependencies. Still, itself has many many unrelated and not-really-needed dependencies. e.g. srvCache for a query that's fast (and it's responsibility of the caller to actually cache it).

Just try doing a var_dump() of a db object.

Event Timeline

Change 940975 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Drop srvCache from Database

https://gerrit.wikimedia.org/r/940975

Change 940985 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Replace deprecationLogger and errorLogger with logger

https://gerrit.wikimedia.org/r/940985

Change 940975 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Drop srvCache from Database

https://gerrit.wikimedia.org/r/940975

Change 943625 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Remove LB::getReplicaResumePos

https://gerrit.wikimedia.org/r/943625

Change 943625 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Remove LB::getReplicaResumePos

https://gerrit.wikimedia.org/r/943625

Change 956456 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Drop injecting srvCache to Database

https://gerrit.wikimedia.org/r/956456

Change 956456 abandoned by Ladsgroup:

[mediawiki/core@master] rdbms: Drop injecting srvCache to Database

Reason:

ugh it's needed in ReplicationReporter

https://gerrit.wikimedia.org/r/956456