Page MenuHomePhabricator
Create Task
Maniphest T342847

remove $wgPageTriageInfiniteScrolling setting and pagetriage-more message
Closed, ResolvedPublic
Actions

Description

Once the Special:NewPagesFeed rewritten in Vue replaces the old Special:NewPagesFeed, I think $wgPageTriageInfiniteScrolling and the pagetriage-more message are going to become dead code.

These did not get ported over to the new Vue Special:NewPagesFeed, and I am fine with that. Not porting these over simplifies the code, which decreases technical debt.

  • wait for Vue Special:NewPagesFeed to replace the old Special:NewPagesFeed
  • remove $wgPageTriageInfiniteScrolling setting everywhere it occurs
  • remove pagetriage-more from i18n/en.json and i18n/qqq.json (other spots where this occurs will hopefully get deleted when we delete the old Special:NewPagesFeed, although feel free to double check)

image.png (578×682 px, 61 KB)

Details

SubjectRepoBranchLines +/-
ListView.mustache: remove unused divsmediawiki/extensions/PageTriagemaster+1 -21
Remove 3 unused config variablesmediawiki/extensions/PageTriagemaster+0 -22
Customize query in gerrit

Event Timeline

Novem_Linguae created this task.Jul 27 2023, 9:21 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 27 2023, 9:21 AM
gerritbot added a comment.Jan 17 2024, 9:43 PM

Change 991355 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/PageTriage@master] Remove $wgPageTriageInfiniteScrolling

https://gerrit.wikimedia.org/r/991355

gerritbot added a project: Patch-For-Review.Jan 17 2024, 9:43 PM
Novem_Linguae updated the task description. (Show Details)Jan 17 2024, 9:44 PM
Scardenasmolinar assigned this task to Novem_Linguae.Jan 17 2024, 11:56 PM
Scardenasmolinar moved this task from Backlog to Code Review on the PageTriage board.
Scardenasmolinar added a project: Moderator-Tools-Team (Kanban).
Scardenasmolinar moved this task from Ready to Eng review on the Moderator-Tools-Team (Kanban) board.
Scardenasmolinar moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.
gerritbot added a comment.Jan 18 2024, 3:05 AM

Change 991444 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/PageTriage@master] ListView.mustache: remove unused divs

https://gerrit.wikimedia.org/r/991444

gerritbot added a comment.Jan 18 2024, 4:18 AM

Change 991355 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Remove 3 unused config variables

https://gerrit.wikimedia.org/r/991355

gerritbot added a comment.Jan 18 2024, 4:18 AM

Change 991444 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] ListView.mustache: remove unused divs

https://gerrit.wikimedia.org/r/991444

Scardenasmolinar moved this task from Reviewed (waiting for changes) to Done on the Moderator-Tools-Team (Kanban) board.Jan 18 2024, 4:19 AM
Scardenasmolinar moved this task from Code Review to Waiting for enwiki deploy on the PageTriage board.
Maintenance_bot removed a project: Patch-For-Review.Jan 18 2024, 4:30 AM
Novem_Linguae updated the task description. (Show Details)Jan 18 2024, 4:41 AM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.15; 2024-01-23).Jan 18 2024, 5:00 AM
MPGuy2824 closed this task as Resolved.Jan 26 2024, 5:57 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits