Page MenuHomePhabricator
Create Task
Maniphest T343164

Alternative URL for some languages have encoded quote marks
Closed, ResolvedPublicBUG REPORT
Actions

Description

When you look at the HTML of /view/ pages like https://www.wikifunctions.org/view/en/Z10001, the alternative URLs for some languages have encoded quote marks around the language code.
e.g. <link rel="alternate" hreflang="&quot;swh&quot;" href="/view/&quot;swh&quot;/Z10001">

Seems like the affected languages are (in order of HTML appearance)

  • swh
  • gaz
  • uzn
  • be-x-old
  • gya
  • abq-latn
  • zh-yue
  • ory
  • sr-me
  • khk
  • plt
  • pbt
  • npi
  • lvs
  • dik
  • kmr
  • taq-tfng

The same thing also happens on Beta e.g. https://wikifunctions.beta.wmflabs.org/view/en/Z10004

Details

SubjectRepoBranchLines +/-
ZObjectStore: Fix deletion of language objectsmediawiki/extensions/WikiLambdamaster+8 -8
ZLangRegistry::fetchLanguageCodeFromZid(): Add to cache if there's a cache missmediawiki/extensions/WikiLambdamaster+3 -0
ZObjectSecondaryDataUpdate: Delete before adding language cache valuesmediawiki/extensions/WikiLambdamaster+5 -0
ZObjectSecondaryDataUpdate: Add language secondary labels as strings not ZStringsmediawiki/extensions/WikiLambdamaster+4 -2
Customize query in gerrit

Event Timeline

Nintendofan885 created this task.Jul 31 2023, 9:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 31 2023, 9:39 PM
Nintendofan885 changed the subtype of this task from "Task" to "Bug Report".Jul 31 2023, 9:44 PM
Nintendofan885 updated the task description. (Show Details)Jul 31 2023, 9:51 PM
Nintendofan885 updated the task description. (Show Details)Jul 31 2023, 9:54 PM
Maintenance_bot added a project: Abstract Wikipedia team.Jul 31 2023, 10:30 PM
Jdforrester-WMF subscribed.Aug 1 2023, 12:55 PM

This sounds like they've been persisted into the DB as 'swh' rather than swh etc., which was a bug in our code briefly during development but fixed a few weeks ago. Though it's possible this might have persisted to Beta, it certainly shouldn't have happened in production, and definitely not only some of the time.

I can write a quick patch to detect this situation and de-quote it, but something's going wrong with the insertion somewhere.

Jdforrester-WMF added a comment.Aug 1 2023, 1:00 PM

Aha, this is for secondary language codes. Whoops.

Jdforrester-WMF changed the task status from Open to In Progress.Aug 1 2023, 1:00 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from To triage to In Progress on the Abstract Wikipedia team board.
gerritbot added a comment.Aug 1 2023, 1:02 PM

Change 944215 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ZObjectSecondaryDataUpdate: Add language secondary labels as strings not ZStrings

https://gerrit.wikimedia.org/r/944215

gerritbot added a project: Patch-For-Review.Aug 1 2023, 1:02 PM
gerritbot added a comment.Aug 3 2023, 10:58 AM

Change 944215 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ZObjectSecondaryDataUpdate: Add language secondary labels as strings not ZStrings

https://gerrit.wikimedia.org/r/944215

Jdforrester-WMF moved this task from In Progress to To deploy on the Abstract Wikipedia team board.Aug 3 2023, 10:59 AM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 3 2023, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Aug 3 2023, 11:10 AM
Jdforrester-WMF added a comment.Aug 18 2023, 6:01 AM

OK, now the next step is to clear the cache and trigger insertZLanguageToLanguagesCache() for those languages. But I'm not going to do that in production on a Friday whilst I'm at Wikimania. :-)

Etonkovidova subscribed.Sep 28 2023, 11:13 PM

Checked view-source:https://www.wikifunctions.org/view/en/Z10001 in wikifunctions wmf.28
Seems that the following lang still have the issue (much shorter list than reported in the task description):
hreflang="&quot;gaz&quot;" href="/view/&quot;gaz&quot;/Z10001">
hreflang="&quot;sr-me&quot;" href="/view/&quot;sr-me&quot;/Z10001">
hreflang="&quot;khk&quot;" href="/view/&quot;khk&quot;/Z10001">
hreflang="&quot;npi&quot;" href="/view/&quot;npi&quot;/Z10001">
hreflang="&quot;lvs&quot;" href="/view/&quot;lvs&quot;/Z10001">
hreflang="&quot;dik&quot;" href="/view/&quot;dik&quot;/Z10001">

@Jdforrester-WMF - anything else needs to be done for this task? The wikifucntion beta has a longer list, e.g. view-source:https://wikifunctions.beta.wmflabs.org/view/en/Z10055

gerritbot added a comment.Oct 2 2023, 8:27 PM

Change 962695 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ZObjectSecondaryDataUpdate: Delete before adding language cache values

https://gerrit.wikimedia.org/r/962695

gerritbot added a project: Patch-For-Review.Oct 2 2023, 8:27 PM
gerritbot added a comment.Oct 2 2023, 9:07 PM

Change 962695 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ZObjectSecondaryDataUpdate: Delete before adding language cache values

https://gerrit.wikimedia.org/r/962695

Maintenance_bot removed a project: Patch-For-Review.Oct 2 2023, 9:12 PM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.29; 2023-10-03); removed MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Oct 2 2023, 10:00 PM
Jdforrester-WMF moved this task from To deploy to In Progress on the Abstract Wikipedia team board.Oct 16 2023, 8:10 PM
gerritbot added a comment.Oct 17 2023, 7:27 PM

Change 966631 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ZLangRegistry::fetchLanguageCodeFromZid(): Add to cache if there's a cache miss

https://gerrit.wikimedia.org/r/966631

gerritbot added a project: Patch-For-Review.Oct 17 2023, 7:27 PM
gerritbot added a comment.Oct 18 2023, 5:56 PM

Change 966631 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ZLangRegistry::fetchLanguageCodeFromZid(): Add to cache if there's a cache miss

https://gerrit.wikimedia.org/r/966631

Maintenance_bot removed a project: Patch-For-Review.Oct 18 2023, 6:11 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.2; 2023-10-24).Oct 18 2023, 7:00 PM
Jdforrester-WMF moved this task from In Progress to 24Q4 (Apr–Jun) on the Abstract Wikipedia team board.Apr 29 2024, 6:01 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (24Q4 (Apr–Jun)); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Ready, Bugs on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.Apr 29 2024, 6:31 PM
Jdforrester-WMF moved this task from Ready, Bugs to Needs QA on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.May 14 2024, 3:46 PM

OK, with some mild DB fiddling I think this is now complete.

Jdforrester-WMF moved this task from Needs QA to Needs Sign-off on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.Jun 4 2024, 5:52 PM
gerritbot added a comment.Jun 12 2024, 4:14 PM

Change #1042306 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ZObjectStore: Fix deletion of language objects

https://gerrit.wikimedia.org/r/1042306

gerritbot added a project: Patch-For-Review.Jun 12 2024, 4:14 PM
gerritbot added a comment.Jun 13 2024, 7:27 PM

Change #1042306 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ZObjectStore: Fix deletion of language objects

https://gerrit.wikimedia.org/r/1042306

Maintenance_bot removed a project: Patch-For-Review.Jun 13 2024, 7:31 PM
Jdforrester-WMF moved this task from Needs Sign-off to Ready to deploy on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.Jun 14 2024, 3:07 PM
Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.Jun 20 2024, 6:46 PM
Etonkovidova added a comment.Jun 25 2024, 1:38 AM

Checked in wikifunctions wmf.10 view-source:https://www.wikifunctions.org/view/en/Z10001 only one instance is left:

<link rel="alternate" hreflang="&quot;dik&quot;" href="/view/&quot;dik&quot;/Z10001">

wikifunctions beta - view-source:https://wikifunctions.beta.wmflabs.org/view/en/Z10055 doesn't have &quot.

Jdforrester-WMF added a comment.Jun 27 2024, 9:44 AM

Have done a final run of the purge script on Z60s and I think this is now finally fixed.

The last four entries updated to not double-encode were:

  • Z1503/bh
  • Z1554/khk
  • Z1641/pbt
  • Z1728/pes
Jdforrester-WMF closed this task as Resolved.Jun 27 2024, 9:44 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits