Page MenuHomePhabricator

All default Inputs with Menus should carry `role="combobox"`
Closed, ResolvedPublic

Description

Background

Currently there are a few Inputs that already carry aria-expanded attribute to trigger a connected Menu, but the don't feature an ARIA role allowing for this attribute or imply this connection.

Proposal

Let's add role="combobox" to these inputs throughout our demos. From MDN article:

The combobox role is set on input that controls another element, such as a listbox or grid, that can dynamically pop up to help the user set the value of the input.

Acceptance criteria for Done

Code

  • Update Codex accordingly

Event Timeline

Change 944315 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] docs, Menu: Add ARIA `combobox` role to Input with Menu

https://gerrit.wikimedia.org/r/944315

Change 944315 abandoned by VolkerE:

[design/codex@main] docs, Menu: Add ARIA `combobox` role to Input with Menu

Reason:

Abandoned for I630591fc41. Whoops, I haven't seen that patch yet. Was just basing patch on rendered code review :}

https://gerrit.wikimedia.org/r/944315

AnneT updated the task description. (Show Details)