Page MenuHomePhabricator

Personalized praise settings dialog: Validate integers are entered to the numeric input fields
Open, Needs TriagePublic

Description

NOTE: While working on this task, note that empty state is supported in the Mentee overview filters (where empty state means "filter is not applied"). This behaviour should not be affected by this task.

Split from T343305. The settings dialog for Personalized praise module on Mentor dashboard currently does not validate an integer is inserted. As of now, this triggers an exception (see T343305). After the exception is fixed on the backend side, we should also ensure the form only sends a valid configuration state to the server.

Validating the form will help users to understand emptying the form field is not supported; it is easier to understand than the field suddenly having a zero in it (result of (int)null or (int)'').

This is lower priority than T343305, as it doesn't directly break the Mentor dashboard.

Acceptance Criteria
  • When I enter an empty string under Edits within a time frame in Personalized praise settings dialog, I receive an informative error message.