I'm working with the Growth team on features that keep growing the number of Wikipedia contributors.
I couldn't tell if it was a regression or not, if it was one it was from more than 2 months ago. I pushed a patch for it.
@mewoph I will rename the non-Homepage modules
Tue, Nov 30
It definitely has been. Thanks for this. I did some changes in the subpage providers to accept quality gates.
Mon, Nov 29
@MMiller_WMF could you point to some article which is returning video or audio files. I remember one task showing some OGG file recommendation but I can't find it now.
Not in the immediate priorities of the team. Moving it to Triaged. We're open to review any patches that may come in.
Fri, Nov 26
Apparently the imports to wikimedia-ui-base started causing some problems, see T296379: GrowthExperiments: Less_Exception_Parser: File `resources/lib/ooui/wikimedia-ui-base.less` not found. I pushed a possible solution like the one used in the MediaSearch extension. I agree on binging this to a retro to see which steps forward we can make to improve the current status.
Thu, Nov 25
Tue, Nov 23
Mon, Nov 22
Fri, Nov 19
Also fixing the skeleton overflow in this patch
Thu, Nov 18
I added new a row Image recommendation service and created 3 panels in grafana dashboard based on existing ones. All feedback on the naming and metrics aggregation is welcome. @Tgr you mentioned a way to aggregate both get and processApiResponseData; On the rate panel I added a "total" aggregation but I'm not 100% sure how you were thinking of displaying this.
Wed, Nov 17
Tue, Nov 16
Mon, Nov 15
Possible duplicate of https://phabricator.wikimedia.org/T291142. Should be fixed in OOUI 0.42.1 https://github.com/wikimedia/oojs-ui/commit/d69dbcc01996830e96dca5cac4d143eb577d477e
Fri, Nov 12
Thu, Nov 11
@kostajh Besides the call for the API get request ServiceImageRecommendationProvider::processApiResponseData is called from SubpageImageRecommendationProvider::createRecommendation (see code here). Do we need to track performance for this creation?
Wed, Nov 10
Mon, Nov 8
Fri, Nov 5
Nov 2 2021
The copy content of the quick tips coming from T292092 includes several paragraphs in tips 1, 2 and 4. https://gerrit.wikimedia.org/r/736270 adds logic to be able to display n paragraphs with the same styles for a single tip with a limit of 3.
Oct 27 2021
Oct 26 2021
Oct 25 2021
The current implementation is using a standard ButtonWidget from OOUI not the ToggleButtonWidget so we have to handle the toggled state manually. Could be improved in the future but for now I think the behavior mimics well the toggle button.
Oct 22 2021
Oct 20 2021
Oct 19 2021
Thanks for the insights @mewoph
Oct 18 2021
@mewoph I extracted the help cta style and instantiation to a separate component (See 731349). I would need your input to clarify what to do with the getHelpPanelCtaButton in HelpPanel.php:30 since it also holds some button properties.
@RHo there's a slight divergence between the Figma designs and standard OOUI states (active and focus). Very slight difference in the icon color (active and focus) and the border/outline (active). We can add extra styles to match the designs. For the focus border I think it's worth since makes the tab navigation coherent.
Oct 15 2021
Oct 14 2021
@mewoph it totally makes sense. I will start taking the ButtonWidget code from HelpPanel to a separate component.