Page MenuHomePhabricator

Sgs (Sergio Gimeno)
Software Engineer, WMF

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 4 2021, 3:13 PM (8 w, 3 d)
Availability
Available
LDAP User
Sergio Gimeno
MediaWiki User
SGimeno (WMF) [ Global Accounts ]

I'm working with the Growth team on features that keep growing the number of Wikipedia contributors.

Recent Activity

Today

Sgs added a comment to T296688: [wmf.9-regression] oo-ui-image-error icon placed too close to the difficulty level label .

I couldn't tell if it was a regression or not, if it was one it was from more than 2 months ago. I pushed a patch for it.

Thu, Dec 2, 1:03 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments, Growth-Structured-Tasks
Sgs updated the task description for T289012: Rename GrowthExperiments ResourceLoader files to follow MediaWiki conventions.
Thu, Dec 2, 12:22 PM · Patch-For-Review, Growth-Team (Current Sprint), Technical-Debt, GrowthExperiments
Sgs updated the task description for T289012: Rename GrowthExperiments ResourceLoader files to follow MediaWiki conventions.
Thu, Dec 2, 12:07 PM · Patch-For-Review, Growth-Team (Current Sprint), Technical-Debt, GrowthExperiments
Sgs moved T296688: [wmf.9-regression] oo-ui-image-error icon placed too close to the difficulty level label from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Thu, Dec 2, 11:39 AM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments, Growth-Structured-Tasks
Sgs moved T296688: [wmf.9-regression] oo-ui-image-error icon placed too close to the difficulty level label from Incoming to In Progress on the Growth-Team (Current Sprint) board.
Thu, Dec 2, 11:39 AM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments, Growth-Structured-Tasks

Yesterday

Sgs added a comment to T289012: Rename GrowthExperiments ResourceLoader files to follow MediaWiki conventions.

@mewoph I will rename the non-Homepage modules

Wed, Dec 1, 5:38 PM · Patch-For-Review, Growth-Team (Current Sprint), Technical-Debt, GrowthExperiments

Tue, Nov 30

Sgs claimed T296688: [wmf.9-regression] oo-ui-image-error icon placed too close to the difficulty level label .
Tue, Nov 30, 5:10 PM · Patch-For-Review, Growth-Team (Current Sprint), GrowthExperiments, Growth-Structured-Tasks
Sgs moved T296333: Add an image: exclude non-images from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Tue, Nov 30, 12:31 PM · Patch-For-Review, Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
Sgs moved T296218: Add image: Set a minimum width for image suggestions from Code Review to QA on the Growth-Team (Current Sprint) board.
Tue, Nov 30, 12:31 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Growth-Team (Current Sprint), Image-Suggestions
Sgs added a comment to T296333: Add an image: exclude non-images.

I think the easiest way to test it would be to use the SubpageImageRecommendationProvider with some random Ogg file of your choice.

It definitely has been. Thanks for this. I did some changes in the subpage providers to accept quality gates.

Tue, Nov 30, 12:28 PM · Patch-For-Review, Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks

Mon, Nov 29

Sgs added a comment to T296333: Add an image: exclude non-images.

@MMiller_WMF could you point to some article which is returning video or audio files. I remember one task showing some OGG file recommendation but I can't find it now.

Mon, Nov 29, 4:44 PM · Patch-For-Review, Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
Sgs updated the task description for T294755: Projects for interim period.
Mon, Nov 29, 4:10 PM · Growth-Team
Sgs created T296646: Migration of front-end modules to Vue.js components.
Mon, Nov 29, 4:09 PM · Growth-Team
Sgs moved T296553: "Mark all changes as seen" does not get applied to oversighted edits on meta from Inbox to Needs Discussion/Analysis on the Growth-Team board.
Mon, Nov 29, 11:22 AM · MediaWiki-Revision-deletion, MediaWiki-Watchlist, Growth-Team
Sgs moved T296443: Create GrowthExperiments newcomer tasks backend architecture diagram from Inbox to Triaged on the Growth-Team board.
Mon, Nov 29, 11:12 AM · Growth-Team, Documentation, GrowthExperiments-NewcomerTasks
Sgs moved T296441: Add an image: Remove tasks with "no suggestion" errors from Inbox to Triaged on the Growth-Team board.
Mon, Nov 29, 11:12 AM · Patch-For-Review, Growth-Team (Current Sprint), Growth-Structured-Tasks, GrowthExperiments-NewcomerTasks, Image-Suggestions
Sgs moved T296407: Structured Task: Easy return to Special:Homepage from Inbox to Needs Discussion/Analysis on the Growth-Team board.
Mon, Nov 29, 11:11 AM · Growth-Team, Growth-Structured-Tasks
Sgs moved T296377: Add an image: Pop open device keyboard and focus on the caption input when arriving on the step to add a caption from Inbox to Needs Discussion/Analysis on the Growth-Team board.
Mon, Nov 29, 11:11 AM · Growth-Team, Image-Suggestions
Sgs moved T296374: Specific User_talk pages show as redlink on Special:RecentChanges on English Wikivoyage from Inbox to Triaged on the Growth-Team board.
Mon, Nov 29, 11:10 AM · MediaWiki-Recent-changes, Growth-Team
Sgs moved T295722: Suggested edits module card - pageviews icon not vertically centred with the text from Incoming to QA on the Growth-Team (Current Sprint) board.
Mon, Nov 29, 11:10 AM · Growth-Team (Current Sprint), MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Growth-Structured-Tasks
Sgs moved T295722: Suggested edits module card - pageviews icon not vertically centred with the text from Triaged to Current Sprint on the Growth-Team board.
Mon, Nov 29, 11:09 AM · Growth-Team (Current Sprint), MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Growth-Structured-Tasks
Sgs added a comment to T284322: Bug: Update contextual Subscribe/Unsubscribe button in real time when Unsubscribing from Echo Notification.

Not in the immediate priorities of the team. Moving it to Triaged. We're open to review any patches that may come in.

Mon, Nov 29, 11:07 AM · DiscussionTools, Notifications, Growth-Team
Sgs moved T284322: Bug: Update contextual Subscribe/Unsubscribe button in real time when Unsubscribing from Echo Notification from Needs Discussion/Analysis to Triaged on the Growth-Team board.
Mon, Nov 29, 11:04 AM · DiscussionTools, Notifications, Growth-Team
Sgs created T296620: TypeError: $.cookie is not a function.
Mon, Nov 29, 10:56 AM · MediaWiki-extensions-WikimediaEvents, Readers-Web-Backlog, Reading Depth, Wikimedia-production-error
Sgs created T296619: '.event.referer_route' should be equal to one of the allowed values.
Mon, Nov 29, 10:52 AM · Growth-Team, Wikimedia-production-error
Sgs created T296618: Flow: "could not locate workflow" errors when viewing history.
Mon, Nov 29, 10:49 AM · StructuredDiscussions, Growth-Team, Wikimedia-production-error
Sgs closed T296379: GrowthExperiments: Less_Exception_Parser: File `resources/lib/ooui/wikimedia-ui-base.less` not found, a subtask of T293952: 1.38.0-wmf.11 deployment blockers, as Resolved.
Mon, Nov 29, 10:23 AM · Release-Engineering-Team (Next), Release, Train Deployments
Sgs closed T296379: GrowthExperiments: Less_Exception_Parser: File `resources/lib/ooui/wikimedia-ui-base.less` not found as Resolved.
Mon, Nov 29, 10:23 AM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Growth-Team (Current Sprint), Performance-Team (Radar), GrowthExperiments, Beta-Cluster-reproducible

Fri, Nov 26

Sgs moved T296333: Add an image: exclude non-images from Ready for Development to In Progress on the Growth-Team (Current Sprint) board.
Fri, Nov 26, 11:17 AM · Patch-For-Review, Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
Sgs moved T296379: GrowthExperiments: Less_Exception_Parser: File `resources/lib/ooui/wikimedia-ui-base.less` not found from Ready for Development to Code Review on the Growth-Team (Current Sprint) board.
Fri, Nov 26, 11:17 AM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Growth-Team (Current Sprint), Performance-Team (Radar), GrowthExperiments, Beta-Cluster-reproducible
Sgs claimed T296379: GrowthExperiments: Less_Exception_Parser: File `resources/lib/ooui/wikimedia-ui-base.less` not found.
Fri, Nov 26, 11:17 AM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Growth-Team (Current Sprint), Performance-Team (Radar), GrowthExperiments, Beta-Cluster-reproducible
Sgs added a comment to T295183: LESS variables and Import OOUI base styles mechanism.

Apparently the imports to wikimedia-ui-base started causing some problems, see T296379: GrowthExperiments: Less_Exception_Parser: File `resources/lib/ooui/wikimedia-ui-base.less` not found. I pushed a possible solution like the one used in the MediaSearch extension. I agree on binging this to a retro to see which steps forward we can make to improve the current status.

Fri, Nov 26, 10:50 AM · GrowthExperiments, Technical-Debt, Growth-Team
Sgs added a comment to T296379: GrowthExperiments: Less_Exception_Parser: File `resources/lib/ooui/wikimedia-ui-base.less` not found.

cc @Urbanecm_WMF, looks like this particular code was added in rEGREc49129b46b5e: Mentor dashboard: Add subheader style. Although, we have this @import 'resources/lib/ooui/wikimedia-ui-base.less'; statement all over our LESS files.

Fri, Nov 26, 10:43 AM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Growth-Team (Current Sprint), Performance-Team (Radar), GrowthExperiments, Beta-Cluster-reproducible

Thu, Nov 25

Sgs claimed T296333: Add an image: exclude non-images.
Thu, Nov 25, 12:50 PM · Patch-For-Review, Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
Sgs added a comment to T296427: Add an image: use highest ranking valid image.

@MMiller_WMF do you mean, filter out all invalid images and then use the first one? Or should the remaining images be ranked somehow? (How?)

Thu, Nov 25, 12:50 PM · Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
Sgs moved T296218: Add image: Set a minimum width for image suggestions from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Thu, Nov 25, 12:28 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Growth-Team (Current Sprint), Image-Suggestions

Tue, Nov 23

Sgs moved T296218: Add image: Set a minimum width for image suggestions from Ready for Development to In Progress on the Growth-Team (Current Sprint) board.
Tue, Nov 23, 7:10 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Growth-Team (Current Sprint), Image-Suggestions
Sgs claimed T296218: Add image: Set a minimum width for image suggestions.
Tue, Nov 23, 4:38 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Growth-Team (Current Sprint), Image-Suggestions
Sgs moved T294886: Add Image: Track API performance from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Tue, Nov 23, 4:28 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Growth-Team (Current Sprint), Growth-Structured-Tasks, GrowthExperiments-NewcomerTasks, Image-Suggestions
Sgs added a comment to T294886: Add Image: Track API performance.

@Tgr I updated the panels. Maybe we should add some documentation in the Chore list checklist. What's a reasonable upper bound for the API requests?

Tue, Nov 23, 4:28 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Growth-Team (Current Sprint), Growth-Structured-Tasks, GrowthExperiments-NewcomerTasks, Image-Suggestions
Sgs placed T288360: Make Echo alerts/notices overlays keyboard accessible up for grabs.
Tue, Nov 23, 10:52 AM · Growth-Team (Current Sprint), Accessibility, Notifications

Mon, Nov 22

Sgs updated the task description for T294755: Projects for interim period.
Mon, Nov 22, 6:00 PM · Growth-Team
Sgs updated the task description for T294755: Projects for interim period.
Mon, Nov 22, 5:59 PM · Growth-Team

Fri, Nov 19

Sgs moved T296099: Error: Call to undefined method MediaWiki\Page\PageStoreRecord::getField() from Inbox to Triaged on the Growth-Team board.
Fri, Nov 19, 4:29 PM · GrowthExperiments, Growth-Team, Wikimedia-production-error
Sgs moved T296096: Add The Wikipedia Library to the interwiki map from Inbox to Needs Discussion/Analysis on the Growth-Team board.
Fri, Nov 19, 4:29 PM · The-Wikipedia-Library (Kanban), Growth-Team
Sgs updated the task description for T296099: Error: Call to undefined method MediaWiki\Page\PageStoreRecord::getField().
Fri, Nov 19, 4:12 PM · GrowthExperiments, Growth-Team, Wikimedia-production-error
Sgs created T296099: Error: Call to undefined method MediaWiki\Page\PageStoreRecord::getField().
Fri, Nov 19, 4:09 PM · GrowthExperiments, Growth-Team, Wikimedia-production-error
Sgs claimed T295722: Suggested edits module card - pageviews icon not vertically centred with the text.

Also fixing the skeleton overflow in this patch

Screenshot 2021-11-19 at 12.58.47.png (1×1 px, 173 KB)

Fri, Nov 19, 12:15 PM · Growth-Team (Current Sprint), MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Growth-Structured-Tasks

Thu, Nov 18

Sgs claimed T288360: Make Echo alerts/notices overlays keyboard accessible.
Thu, Nov 18, 4:19 PM · Growth-Team (Current Sprint), Accessibility, Notifications
Sgs added a comment to T294886: Add Image: Track API performance.

I added new a row Image recommendation service and created 3 panels in grafana dashboard based on existing ones. All feedback on the naming and metrics aggregation is welcome. @Tgr you mentioned a way to aggregate both get and processApiResponseData; On the rate panel I added a "total" aggregation but I'm not 100% sure how you were thinking of displaying this.

Thu, Nov 18, 12:26 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Growth-Team (Current Sprint), Growth-Structured-Tasks, GrowthExperiments-NewcomerTasks, Image-Suggestions

Wed, Nov 17

Sgs moved T295720: Structured tasks - adjustments for robot icon from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Wed, Nov 17, 8:51 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Growth-Team (Current Sprint), Growth-Structured-Tasks
Sgs added a comment to T295720: Structured tasks - adjustments for robot icon .

Hi @Sgs - unfortunately there is a different base font size for Desktop and Mobile web. I try to use standard 4px grid regardless of mobile and desktop so actually it's intended that mobile and desktop have the same 4px space between the checkbox form element and the machine suggestions label (you have to measure between the entire checkbox component and the machine suggestions below):

Mobile
Screen Shot 2021-11-17 at 12.53.35 PM.png (422×1 px, 72 KB)
Desktop
image.png (514×1 px, 96 KB)
Wed, Nov 17, 4:19 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Growth-Team (Current Sprint), Growth-Structured-Tasks
Sgs added a comment to T295720: Structured tasks - adjustments for robot icon .

@RHo There are some differences on the font-size and line-height scales and the vertical margin between figma desktop spec and mobile spec.

Wed, Nov 17, 11:37 AM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Growth-Team (Current Sprint), Growth-Structured-Tasks

Tue, Nov 16

Sgs moved T295720: Structured tasks - adjustments for robot icon from Incoming to In Progress on the Growth-Team (Current Sprint) board.
Tue, Nov 16, 6:30 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Growth-Team (Current Sprint), Growth-Structured-Tasks
Sgs edited projects for T295720: Structured tasks - adjustments for robot icon , added: Growth-Team (Current Sprint); removed Growth-Team.
Tue, Nov 16, 6:29 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Growth-Team (Current Sprint), Growth-Structured-Tasks
Sgs claimed T295720: Structured tasks - adjustments for robot icon .
Tue, Nov 16, 11:35 AM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Growth-Team (Current Sprint), Growth-Structured-Tasks

Mon, Nov 15

Sgs added a comment to T287759: Button of the title of the process dialog has bottom padding when font-size is big.

Possible duplicate of https://phabricator.wikimedia.org/T291142. Should be fixed in OOUI 0.42.1 https://github.com/wikimedia/oojs-ui/commit/d69dbcc01996830e96dca5cac4d143eb577d477e

Mon, Nov 15, 4:56 PM · OOUI
Sgs moved T295544: Long filenames break save dialog layout from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Mon, Nov 15, 4:12 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
Sgs moved T295670: timeout in GrowthTasksApi.handleError from Inbox to Triaged on the Growth-Team board.
Mon, Nov 15, 10:21 AM · GrowthExperiments-Homepage, Growth-Team, Wikimedia-production-error
Sgs moved T295667: MentorPageMentorManager: Wikimedia\RequestTimeout\RequestTimeoutException: The maximum execution time of 60 seconds was exceeded from Inbox to Triaged on the Growth-Team board.
Mon, Nov 15, 10:21 AM · Growth-Team, Wikimedia-production-error
Sgs moved T295665: Wikimedia\Rdbms\DBTransactionStateError: Cannot execute query from GrowthExperiments\Maintenance\UpdateMenteeData while transaction status is ERROR from Inbox to Triaged on the Growth-Team board.
Mon, Nov 15, 10:21 AM · GrowthExperiments-MentorDashboard, Growth-Team, Wikimedia-production-error
Sgs moved T295621: Add a secondary link to The Wikipedia Library notification from Inbox to Triaged on the Growth-Team board.
Mon, Nov 15, 10:20 AM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), The-Wikipedia-Library (Kanban), Privacy, Notifications
Sgs moved T295564: Echo: Broken left-to-right/right-to-left character mix in ping notification from Inbox to Triaged on the Growth-Team board.
Mon, Nov 15, 10:18 AM · I18n, RTL, Notifications, Growth-Team
Sgs merged T295669: TypeError: format.replace is not a function into T272904: PageTriage extension causes TypeError: format.replace is not a function in randomToken function im SearchSatisfaction schema.
Mon, Nov 15, 10:17 AM · Patch-For-Review, Unstewarded-production-error, PageCuration, Growth-Team, MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), JavaScript, Wikimedia-production-error
Sgs merged task T295669: TypeError: format.replace is not a function into T272904: PageTriage extension causes TypeError: format.replace is not a function in randomToken function im SearchSatisfaction schema.
Mon, Nov 15, 10:17 AM · Growth-Team, Wikimedia-production-error
Sgs created T295670: timeout in GrowthTasksApi.handleError.
Mon, Nov 15, 9:51 AM · GrowthExperiments-Homepage, Growth-Team, Wikimedia-production-error
Sgs created T295669: TypeError: format.replace is not a function.
Mon, Nov 15, 9:43 AM · Growth-Team, Wikimedia-production-error
Sgs created T295667: MentorPageMentorManager: Wikimedia\RequestTimeout\RequestTimeoutException: The maximum execution time of 60 seconds was exceeded.
Mon, Nov 15, 9:29 AM · Growth-Team, Wikimedia-production-error
Sgs created T295665: Wikimedia\Rdbms\DBTransactionStateError: Cannot execute query from GrowthExperiments\Maintenance\UpdateMenteeData while transaction status is ERROR.
Mon, Nov 15, 9:22 AM · GrowthExperiments-MentorDashboard, Growth-Team, Wikimedia-production-error

Fri, Nov 12

Sgs moved T294886: Add Image: Track API performance from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Fri, Nov 12, 10:36 AM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Growth-Team (Current Sprint), Growth-Structured-Tasks, GrowthExperiments-NewcomerTasks, Image-Suggestions
Sgs moved T295544: Long filenames break save dialog layout from Ready for Development to In Progress on the Growth-Team (Current Sprint) board.
Fri, Nov 12, 10:36 AM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks

Thu, Nov 11

Sgs updated subscribers of T294886: Add Image: Track API performance.

@kostajh Besides the call for the API get request ServiceImageRecommendationProvider::processApiResponseData is called from SubpageImageRecommendationProvider::createRecommendation (see code here). Do we need to track performance for this creation?

Thu, Nov 11, 6:50 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Growth-Team (Current Sprint), Growth-Structured-Tasks, GrowthExperiments-NewcomerTasks, Image-Suggestions
Sgs claimed T295544: Long filenames break save dialog layout.
Thu, Nov 11, 1:02 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks

Wed, Nov 10

Sgs moved T294886: Add Image: Track API performance from Ready for Development to In Progress on the Growth-Team (Current Sprint) board.
Wed, Nov 10, 5:02 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Growth-Team (Current Sprint), Growth-Structured-Tasks, GrowthExperiments-NewcomerTasks, Image-Suggestions

Mon, Nov 8

Sgs claimed T294886: Add Image: Track API performance.
Mon, Nov 8, 6:19 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Growth-Team (Current Sprint), Growth-Structured-Tasks, GrowthExperiments-NewcomerTasks, Image-Suggestions

Fri, Nov 5

Sgs created T295183: LESS variables and Import OOUI base styles mechanism.
Fri, Nov 5, 5:46 PM · GrowthExperiments, Technical-Debt, Growth-Team
Sgs moved T290791: Add an image: guidance content from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Fri, Nov 5, 4:09 PM · QTE-TestingOverview, MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks

Nov 2 2021

Sgs added a comment to T290791: Add an image: guidance content.

The copy content of the quick tips coming from T292092 includes several paragraphs in tips 1, 2 and 4. https://gerrit.wikimedia.org/r/736270 adds logic to be able to display n paragraphs with the same styles for a single tip with a limit of 3.

Nov 2 2021, 5:41 PM · QTE-TestingOverview, MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks

Oct 27 2021

Sgs moved T290791: Add an image: guidance content from Ready for Development to In Progress on the Growth-Team (Current Sprint) board.
Oct 27 2021, 5:30 PM · QTE-TestingOverview, MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks

Oct 26 2021

Sgs claimed T290791: Add an image: guidance content.
Oct 26 2021, 11:31 AM · QTE-TestingOverview, MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks

Oct 25 2021

Sgs added a comment to T292933: Help panel: lighter styling for help panel button.

Thanks for the feedback @RHo, I pushed another patch to address both issues. You can check the demo here

Hi @Sgs - thanks for spinning this up for review. A couple of things:
i. the Desktop version of the help panel is different from expected on the selected and selected focus states:

Expected styling for selected (with "?" turning into the downwards chevron
image.png (508×842 px, 64 KB)
Actual
image.png (1×834 px, 217 KB)

Having said that, I am fine with this as a button instead of a toggle button if it will add substantial work to change the code.

The current implementation is using a standard ButtonWidget from OOUI not the ToggleButtonWidget so we have to handle the toggled state manually. Could be improved in the future but for now I think the behavior mimics well the toggle button.

Oct 25 2021, 4:17 PM · MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks

Oct 22 2021

Sgs added a comment to T292933: Help panel: lighter styling for help panel button.

@RHo I have created a patchdemo instance (https://patchdemo.wmflabs.org/wikis/f7c0c93022/w/) so the updated styles can be confirmed.

Oct 22 2021, 2:42 PM · MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks

Oct 20 2021

Sgs raised the priority of T292933: Help panel: lighter styling for help panel button from Medium to High.
Oct 20 2021, 10:10 AM · MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
Sgs lowered the priority of T292933: Help panel: lighter styling for help panel button from High to Medium.
Oct 20 2021, 10:10 AM · MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
Sgs moved T292592: Add a link: rejection reasons should be checkboxes from Ready for Development to In Progress on the Growth-Team (Current Sprint) board.
Oct 20 2021, 10:09 AM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Growth-Structured-Tasks, Add-Link, Growth-Team (Current Sprint)
Sgs moved T292933: Help panel: lighter styling for help panel button from In Progress to Code Review on the Growth-Team (Current Sprint) board.
Oct 20 2021, 10:09 AM · MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks

Oct 19 2021

Sgs added a comment to T292933: Help panel: lighter styling for help panel button.

Thanks for the insights @mewoph

Hi @Sgs, for the button from getHelpPanelCtaButton, unfortunately the attributes would have to be kept in sync manually with the new component (we have several of this pattern where PHP & JS attributes need to align). Right now when the button is returned in the initial HTML, it's infused by OO.ui.ButtonWidget so I think instead this can be infused by the new HelpPanelButton class.

Oct 19 2021, 5:30 PM · MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks

Oct 18 2021

Sgs added a comment to T292933: Help panel: lighter styling for help panel button.

@mewoph I extracted the help cta style and instantiation to a separate component (See 731349). I would need your input to clarify what to do with the getHelpPanelCtaButton in HelpPanel.php:30 since it also holds some button properties.

Oct 18 2021, 10:40 AM · MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
Sgs claimed T292592: Add a link: rejection reasons should be checkboxes.
Oct 18 2021, 10:25 AM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Growth-Structured-Tasks, Add-Link, Growth-Team (Current Sprint)
Sgs added a comment to T292933: Help panel: lighter styling for help panel button.

@RHo there's a slight divergence between the Figma designs and standard OOUI states (active and focus). Very slight difference in the icon color (active and focus) and the border/outline (active). We can add extra styles to match the designs. For the focus border I think it's worth since makes the tab navigation coherent.

Progressive help cta.jpg (720×960 px, 51 KB)

Oct 18 2021, 9:50 AM · MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks

Oct 15 2021

Sgs moved T292933: Help panel: lighter styling for help panel button from Ready for Development to In Progress on the Growth-Team (Current Sprint) board.
Oct 15 2021, 7:23 AM · MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks

Oct 14 2021

Sgs added a comment to T292933: Help panel: lighter styling for help panel button.

@mewoph it totally makes sense. I will start taking the ButtonWidget code from HelpPanel to a separate component.

Oct 14 2021, 4:38 PM · MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
Sgs changed the status of T292933: Help panel: lighter styling for help panel button, a subtask of T289823: Add an image: frontend tasks for initial release, from Open to In Progress.
Oct 14 2021, 4:38 PM · Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks
Sgs changed the status of T292933: Help panel: lighter styling for help panel button from Open to In Progress.
Oct 14 2021, 4:38 PM · MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks

Oct 12 2021

Sgs claimed T292933: Help panel: lighter styling for help panel button.
Oct 12 2021, 9:26 AM · MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), Image-Suggestions, Growth-Team (Current Sprint), Growth-Structured-Tasks

Oct 6 2021

Sgs added a watcher for GrowthExperiments: Sgs.
Oct 6 2021, 11:11 AM

Oct 5 2021

Sgs created T292541: Grant Access to wmf for sgimeno.
Oct 5 2021, 2:51 PM · SRE, LDAP-Access-Requests

Oct 4 2021

Sgs updated Sgs.
Oct 4 2021, 3:29 PM