The similar task T321762: [wmf.17- regression] Homepage - no Task type selection is allowed.

Testing notes - to check after the fix:
(1)

• No selection of topics and task types results in "No suggestions found" - reload the page: the suggestions are displayed; also note the count of available articles after reloading the page - 10,077

	after reloading the page.

• open Select topic - the count of articles drops to 1 and only one SE article will be displayed:

Done button is active only when no topics is selected	Done button is not active if any of the topics are selected

(3) @Trizek-WMF reported - the case when selecting Task type results in the incorrect, i.e. zero count, of available tasks.

Change 1010889 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] NewcomerTaskStore: update the task queue before finishing loading

https://gerrit.wikimedia.org/r/1010889

Change 1010889 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] NewcomerTaskStore: update the task queue before finishing loading

https://gerrit.wikimedia.org/r/1010889

No selection of topics and task types results in "No suggestions found", after the fix this won't possible. Which are the steps to get to this state (1), if not the ones stated in the description?
Are scenarios (2) & (3) a fall-out from (1)? cc @Etonkovidova

In T359992#9627655, @Sgs wrote:

No selection of topics and task types results in "No suggestions found", after the fix this won't possible. Which are the steps to get to this state (1), if not the ones stated in the description?
Are scenarios (2) & (3) a fall-out from (1)? cc @Etonkovidova

Yes, I think so.

@Sgs - checked in beta- works, i.e. Done button in 'Select types of edits" is inactive if no topic selection is made. It seems that some cache warming is needed, so the issue might be present on couple of first attempts.

All other testing scenarios (listed in https://phabricator.wikimedia.org/T359992#9627690) are not reachable due to the fix. They all were fall-out results of the bug.

Change 1012778 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Revert "NewcomerTaskStore: update the task queue before finishing loading"

https://gerrit.wikimedia.org/r/1012778

Caused T360469, and Kirsten decided we should revert the fix and fix this issue correctly.

Change 1012779 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.42.0-wmf.23] Revert "NewcomerTaskStore: update the task queue before finishing loading"

https://gerrit.wikimedia.org/r/1012779

Change 1012778 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Revert "NewcomerTaskStore: update the task queue before finishing loading"

https://gerrit.wikimedia.org/r/1012778

Change 1012779 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.42.0-wmf.23] Revert "NewcomerTaskStore: update the task queue before finishing loading"

https://gerrit.wikimedia.org/r/1012779

Mentioned in SAL (#wikimedia-operations) [2024-03-20T18:14:48Z] <urbanecm@deploy2002> Started scap: Backport for [[gerrit:1012779|Revert "NewcomerTaskStore: update the task queue before finishing loading" (T360469 T359992)]]

Mentioned in SAL (#wikimedia-operations) [2024-03-20T18:17:12Z] <urbanecm@deploy2002> urbanecm: Backport for [[gerrit:1012779|Revert "NewcomerTaskStore: update the task queue before finishing loading" (T360469 T359992)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-03-20T18:30:51Z] <urbanecm@deploy2002> Finished scap: Backport for [[gerrit:1012779|Revert "NewcomerTaskStore: update the task queue before finishing loading" (T360469 T359992)]] (duration: 16m 02s)

Change #1026853 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Suggested edits: update task queue before loading

https://gerrit.wikimedia.org/r/1026853

Change #1026853 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Suggested edits: update task queue before loading

https://gerrit.wikimedia.org/r/1026853

Checked in enwiki betalabs - the current (fixed) behavior is:

• deselect all type tasks - Done button is active, a user can click on it and saves the no-task type selected filter. The count of found tasks is zero. The Done button is inactive.
• after that, selecting any topics won't change the count - zero tasks is found.

Testing notes: - ✅ DONE in wmf.6
Testing scenarios to check in production:

• Check all scenarios from https://phabricator.wikimedia.org/T359992#9625341|
• Check for a new user (or a user who restores all default preferences)
  • doesn't select any topics in the intro tour - the task counter shows correct number
  • a user deselect the default task types - the counter shows the warning and the counter is zero. The Get suggestions button is inactive

Re-opening since the issue is reproducible in frwiki wmf.7 - added some clarification in the issue description.

Testing note: When an empty task type filter selection is saved, the set fetched tasks (and the counter) display incorrect behavior (see the summary below):

• the counter indicates lots of tasks, but when navigating through them, the counter suddenly changes from an initial big number to, for example, 15 (in some cases 20) - see the animated gif below:

• not possible to add/remove topic selection

Change #1053644 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] SuggestedEdits: disable primary button when no task types selected

https://gerrit.wikimedia.org/r/1053644

In T359992#9860861, @Etonkovidova wrote:

Re-opening since the issue is reproducible in frwiki wmf.7 - added some clarification in the issue description.

I think the issue is present broadly not just in frwiki. There are several code issues leading to this situation. I've tried to capture some of them in T369742 and T369806. Resolving these two tasks should improve the amount of occurrences of users being able to save an empty selection, however there could be other situations leading to the same outcome. Since the task description mentions : when none of "Select types of edits" filters is selected, the Done button should not be active., I'm scoping the fix for this task (1053644) to the no task types scenario, and leaving the other derived counter issues for T369742 and T369806. Does this sound acceptable @Etonkovidova ?

Testing note: When an empty task type filter selection is saved, the set fetched tasks (and the counter) display incorrect behavior (see the summary below):

• the counter indicates lots of tasks, but when navigating through them, the counter suddenly changes from an initial big number to, for example, 15 (in some cases 20) - see the animated gif below:

• not possible to add/remove topic selection

The "sudden counter drop" is definitely not good as UX, my observation is that this problem is scoped to collections of tasks that include the "link recommendation" type. I think there are at least two possible sources for this happening, (1) the protected pages and valid tasks filters filtering over a random task set (2) the amount of dangling search index records in the wiki, which would directly impact the invalid link recommendation filter, filtering out almost all suggestions. We've taken action on this dangling index records issue in the past by running the fixLinkRecommendationData.php but we keep on seeing this happen, we should probably prioritize T347601 and related T314158 to figure out why this keeps coming back. @Etonkovidova could you confirm the hypothesis that the "sudden drop" issue is scoped to filters including "link recommendation" task type? If that's the case I can file a task for this bug with more context and details.

Change #1053644 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] SuggestedEdits: disable primary button when no task types selected

https://gerrit.wikimedia.org/r/1053644

Checked in beta and on frwiki wmf.16 - works as expected; the Done button is not active if all of the task types are de-selected.