Page MenuHomePhabricator

Community updates module: Title & Body text
Closed, ResolvedPublic5 Estimated Story Points

Description

User story & summary:

As a new editor visiting my Newcomer homepage, I want to see community updates relevant to new editors, so that I can deepen my involvement in the wikis.

Parent task: T360485: [EPIC] Newcomer homepage: Community updates module (FY23/24 WE1.3 / FY24/25 SDS2.1.3)

Designs:

Community updates: Figma designs for Homepage module.

Community updates: Figma designs for the configuration form.

NOTE: Figma designs show the end state of the MVP release.
Acceptance Criteria:

Mobile and desktop UI for the basic homepage text fields:

  • Community updates module title (needs to be translatable, but not configurable)
  • Title
  • Body text
NOTE: this task can use static data from designs. Community Configuration handled in a separate task: T367223: Community updates module: Title & Body text - support for Community Configuration

Event Timeline

CommunityConfiguration controls do not provide a character counter and as other engineers have surfaced in the past (@moriel/110804974371434815), there are many edge cases. Can we exclude the visual character count from the scope of this task? And probably file a task upstream if we find this feature relevant. Setting a maximum value for the field is already possible in CommunityConfiguration and although the text won't be capped in the form input, there will be a validation error showing for the field and (only in English) specifying "Maximum length for this field is XX". cc @KStoller-WMF

KStoller-WMF set the point value for this task to 5.Jun 11 2024, 4:22 PM
KStoller-WMF renamed this task from Community updates module: Title & Body text, including character limits to Community updates module: Title & Body text.Jun 11 2024, 6:20 PM
KStoller-WMF updated the task description. (Show Details)

Can we exclude the visual character count from the scope of this task?

Yes. I've updated acceptance criteria and the title accordingly.

I've also created a separate subtask for handling Community Configuration: T367223: Community updates module: Title & Body text - support for Community Configuration

Change #1042183 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Create CommunityUpdates Module

https://gerrit.wikimedia.org/r/1042183

Change #1042206 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Create CommunityUpdates Module

https://gerrit.wikimedia.org/r/1042206

Change #1042183 abandoned by Cyndywikime:

[mediawiki/extensions/GrowthExperiments@master] Create CommunityUpdates Module

Reason:

Abandoning in favour of I8738dc68d06d84853036b52525bcedc15356a1e8

https://gerrit.wikimedia.org/r/1042183

Change #1046628 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/CommunityConfiguration@master] JsonSchema: add minLength and maxLength validation keywords

https://gerrit.wikimedia.org/r/1046628

Change #1046628 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] JsonSchema: add minLength and maxLength validation keywords

https://gerrit.wikimedia.org/r/1046628

Change #1047961 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[operations/mediawiki-config@master] GrowthExperiments: add community updates module flag

https://gerrit.wikimedia.org/r/1047961

Change #1047981 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Community Updates: Add community updates feature flag

https://gerrit.wikimedia.org/r/1047981

Change #1047981 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Community Updates: Add community updates feature flag

https://gerrit.wikimedia.org/r/1047981

Change #1047961 merged by jenkins-bot:

[operations/mediawiki-config@master] GrowthExperiments: add community updates module flag

https://gerrit.wikimedia.org/r/1047961

Mentioned in SAL (#wikimedia-operations) [2024-07-02T13:17:31Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 Started scap sync-world: Backport for [[gerrit:1048059|[wikifunctions] Grant wikifunctions-staff enum and converter rights (T366610 T367270)]], [[gerrit:1047961|GrowthExperiments: add community updates module flag (T365877)]]

Mentioned in SAL (#wikimedia-operations) [2024-07-02T13:20:02Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 sgimeno, jforrester, lucaswerkmeister-wmde: Backport for [[gerrit:1048059|[wikifunctions] Grant wikifunctions-staff enum and converter rights (T366610 T367270)]], [[gerrit:1047961|GrowthExperiments: add community updates module flag (T365877)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-07-02T13:27:54Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 Finished scap: Backport for [[gerrit:1048059|[wikifunctions] Grant wikifunctions-staff enum and converter rights (T366610 T367270)]], [[gerrit:1047961|GrowthExperiments: add community updates module flag (T365877)]] (duration: 10m 22s)

I just noticed the CTA button is different on the mobile desgin from the desktop. On mobile it is frameless. Is that intentional? @JFernandez-WMF

In Codex docs for frameless buttons the mention is to not detract user focus from content into the CTA action, which seems appropriate for our use case. However I don't see the relation between platform and button type in this case. Also to mind that buttons across modules should be as consistent as we can, we currently have many button metaphors: frameless arrow icons (OOUI), progressive (blue) block buttons like the "See all suggestions"(OOUI) and the CommunityUpdates frameless and standard Codex buttons.

Change #1042206 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] CommunityUpdates: Create CommunityUpdates module

https://gerrit.wikimedia.org/r/1042206

Etonkovidova subscribed.

@JFernandez-WMF - the figma design displays a two-column layout for Special:Homepage.Such layout will be displayed on desktop with <1465px width. Is it ok to have have the Community updates to be less prominent (and have much smaller area to display image/text) than it's in the design?

fima design>1465px width
Screen Shot 2024-07-15 at 3.23.50 PM.png (1×1 px, 298 KB)
Screen Shot 2024-07-12 at 5.34.17 PM.png (1×3 px, 381 KB)

The mobile looks according to the specs:

Screen Shot 2024-07-12 at 5.34.40 PM.png (1×810 px, 181 KB)

thanks @Etonkovidova as always! Kirsten and I had a conversation re: layout/breakpoints and have concluded that how it is displayed right now looks good and does not need changes.

I just noticed the CTA button is different on the mobile design from the desktop. On mobile it is frameless. Is that intentional? @JFernandez-WMF

In Codex docs for frameless buttons the mention is to not detract user focus from content into the CTA action, which seems appropriate for our use case. However I don't see the relation between platform and button type in this case. Also to mind that buttons across modules should be as consistent as we can, we currently have many button metaphors: frameless arrow icons (OOUI), progressive (blue) block buttons like the "See all suggestions"(OOUI) and the CommunityUpdates frameless and standard Codex buttons.

sorry @Sgs I am just responding to this! I agree we should use the quiet/frameless button for both mobile and desktop — sorry for the confusion here. I created T370376: Community Updates module: both desktop and mobile should use 'quiet' button type for making that change.